From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 660AFC61D97 for ; Wed, 22 Nov 2023 15:06:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E3C436B0623; Wed, 22 Nov 2023 10:06:40 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC4C36B062A; Wed, 22 Nov 2023 10:06:40 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C19CF6B062B; Wed, 22 Nov 2023 10:06:40 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A525D6B0623 for ; Wed, 22 Nov 2023 10:06:40 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7478A80D7B for ; Wed, 22 Nov 2023 15:06:40 +0000 (UTC) X-FDA: 81485916960.14.82BC7C7 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by imf13.hostedemail.com (Postfix) with ESMTP id A9779200E8; Wed, 22 Nov 2023 15:05:12 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gghhkSG4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ylDzK1dN; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700665513; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=kiNIjoy22VhgtIuHBArgiaoyvsvGoNJHeARkzxhMWGY=; b=QUkzzXteVhkMT/GAA/Ezvi9HsXbkvN7R7fGIrfM/stjDVtjYx6NbgbP67y5FaUR6Qe7WBE RVKDZI3eZ8JAWNyIp3CoYRroiqFnbkm7YxjphOEYKzpkCCXpkqfp27SdmEzvKhpHsGKoRn JmPdiQVO6DAyRbTT16xUuqWTMttBMtM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700665513; a=rsa-sha256; cv=none; b=OIy+7x5jm2OtMIzdB+LXOiTyKLAw0Cagg3dsZZDmraoTVBTz1I6zGKFdG85ZXHrwrsb87H eFONxNhzdh7eIv7x8rvJRiIzhkgKQNPdZwczoPi47tgKRWxLhwmPLqwEBFlhR/4Z3YyeI1 iOPxP1HkWD4DzNjJ9zwzD0EJR2foz1s= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=gghhkSG4; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=ylDzK1dN; spf=pass (imf13.hostedemail.com: domain of jack@suse.cz designates 195.135.220.28 as permitted sender) smtp.mailfrom=jack@suse.cz; dmarc=none Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id A54792197D; Wed, 22 Nov 2023 15:05:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1700665509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kiNIjoy22VhgtIuHBArgiaoyvsvGoNJHeARkzxhMWGY=; b=gghhkSG43KQIBBJGVUaWHWPez5aSJU2oWxN0I2xdIkHy4nT299HGHkEPzB5ju783UEdGub quQGKg0KLRMPxc924bp7I28UpnSbuczFPYoBfNJEla47Q0VzoDIda1+kyxPGX1KLh3kS2P Jr9MMfR+boGxUZF/uwCU5ZOK4WMlf80= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1700665509; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=kiNIjoy22VhgtIuHBArgiaoyvsvGoNJHeARkzxhMWGY=; b=ylDzK1dNfUswNgsV2CMCxU1vr72Y1bh7nO7MfzJ/ZCx/IAxOmdSUWmUdkcoayATrj7nzRj dFlzvSaj+6lPeYAw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 7B1BA13461; Wed, 22 Nov 2023 15:05:09 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id UHgCHqUYXmUkGgAAMHmgww (envelope-from ); Wed, 22 Nov 2023 15:05:09 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id E6C71A07DC; Wed, 22 Nov 2023 16:05:08 +0100 (CET) Date: Wed, 22 Nov 2023 16:05:08 +0100 From: Jan Kara To: Christian Brauner Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jan Kara , Vitaly Kuznetsov , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, David Woodhouse , Paul Durrant , Oded Gabbay , Wu Hao , Tom Rix , Moritz Fischer , Xu Yilun , Zhenyu Wang , Zhi Wang , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Daniel Vetter , Leon Romanovsky , Jason Gunthorpe , Frederic Barrat , Andrew Donnellan , Arnd Bergmann , Greg Kroah-Hartman , Eric Farman , Matthew Rosato , Halil Pasic , Vineeth Vijayan , Peter Oberparleiter , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Tony Krowiak , Jason Herne , Harald Freudenberger , "Michael S. Tsirkin" , Jason Wang , Xuan Zhuo , Diana Craciun , Alex Williamson , Eric Auger , Fei Li , Benjamin LaHaise , Johannes Weiner , Michal Hocko , Roman Gushchin , Shakeel Butt , Muchun Song , Kirti Wankhede , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-fpga@vger.kernel.org, intel-gvt-dev@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-usb@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-aio@kvack.org, cgroups@vger.kernel.org, linux-mm@kvack.org, Jens Axboe , Pavel Begunkov , io-uring@vger.kernel.org Subject: Re: [PATCH v2 1/4] i915: make inject_virtual_interrupt() void Message-ID: <20231122150508.bdkhrdrhlyva7biz@quack3> References: <20231122-vfs-eventfd-signal-v2-0-bd549b14ce0c@kernel.org> <20231122-vfs-eventfd-signal-v2-1-bd549b14ce0c@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231122-vfs-eventfd-signal-v2-1-bd549b14ce0c@kernel.org> X-Stat-Signature: cdt64oj999ptwpwn887h86j4dks78u6b X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: A9779200E8 X-Rspam-User: X-HE-Tag: 1700665512-478833 X-HE-Meta: U2FsdGVkX1+f6Wk0wglVzd8P2BzArBRbJDfO50QFtYTZ7TkVJItFbMogGb2QIXYvsAVVpauu/THXhj3OIc4qSOKSkDzr9Fjd/CnqcH2ypS6udUKDd9vDk55SByXFVnmwwcp3adTVJUNLoqgWeRnSyZIl7Zr5s90hBa2SSdMSTc+4N8eDs13Xz+mCaUilUFUK/yE80QcB3NZw3/A38+8PTjNFg76qIIdSIQesWE5jnhdCzu5pjSw41HMBQndUeE6oWbsgNaX7t43U0q1zjklI+d0D/GD84k6z4Biaqko9EfVaxFKmrHxm0P7fnSEIpmQ954+35QIiXsqNMMocjwz5XM81hTvzRYNDR/B0cGBfR9uiNHQupMsWydnV1k1Aim7IVHEl3TZBi+2boTN8VxZ3tsoPxDGk2g7F0MtvUtboAnkFR7c6qZf1izFK4wX21WK/IX705rjiJXM3CaVPtN5gVX5RNhnrZNyzGwuGZMKCvVhSONO7ZAgS5ldQhrPqcg14pd6f3kJnxFlnWWjMfWYWA5/gRMyiE08oFUOcgBeqT434Jl0vfjhKPMTlhKPgGkXqLwv2lbS8NQg0DuIOCuevyMT+XvdWz1fweAxN6nNyXSF+CCSLX/NBQSi/+ChGnPN8k8WVAfOou9R/BFUZRJPCVg9+vpenkoAuWEMcC/PYpRREg96ZRfOlRSxEvpDws//G9UWzyhV9rSWMRIDYjM8YvKXOTqyeyD7ygyPbfAgiLDKvsYXou6K+4oEBgWqKSeR/dToZPgMoTsPKD9O42e0O9c8BK9jHsRHpMkCC5ifSJxMa+oWsBLiQ8yANwdMYMXsFt0hKQg7Ga32Tntycvjuoj9IRXWjETLig25jLodS7SatRNrN3IGp/zeDax/s+O9+HeyYrDVqUF+ROiqoQjsnW50nUyZuVqyj6P/VPOV7mA6a3CTz0WxmmXHusLf2GhKDwqKUpMPDkM3pWRoFONit y8Z+L0mo MFL7Ug8jAH8w8gqEyE+lD4/VydY+QApfrQ8v9tb2y21enHPVFv6e+DZXdv12I8aJML9WflZ4g7MxT/9cLQ8x17RlNo4yLdYwx21DSxmwWKpKO/FkEz8mj7mSLnb/u76RpYX0Wnk/eDlzB+73Do7CE8IG+swsgyMxomn0WXxtUEVqgk7KjhEb0EL5PwAbtHo3IwFydpzwgjaJbw7uRKnldfWDEnKNWTJZ2ujIP5VDemxh5OFmJh8nQ/wQiIcvpmURyxY0pjYgyYIDiKHehN4pZ/SMN1o/LQZeVV13OVCIXSWSPICiqvNEtOjMhO81h1vnD5/mgmiapvCJhcazQJdPF/Z3z5/fYsIsZJg/uEl/IBjG+vX/qiUYe9UU249uprAcl4PB07KP5Nz1tnlAQSouR3R3cKiGIiE4bOTuit/+v7jfJ6t6kcb3z6+auow== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed 22-11-23 13:48:22, Christian Brauner wrote: > The single caller of inject_virtual_interrupt() ignores the return value > anyway. This allows us to simplify eventfd_signal() in follow-up > patches. > > Signed-off-by: Christian Brauner Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > drivers/gpu/drm/i915/gvt/interrupt.c | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/gvt/interrupt.c b/drivers/gpu/drm/i915/gvt/interrupt.c > index de3f5903d1a7..9665876b4b13 100644 > --- a/drivers/gpu/drm/i915/gvt/interrupt.c > +++ b/drivers/gpu/drm/i915/gvt/interrupt.c > @@ -422,7 +422,7 @@ static void init_irq_map(struct intel_gvt_irq *irq) > #define MSI_CAP_DATA(offset) (offset + 8) > #define MSI_CAP_EN 0x1 > > -static int inject_virtual_interrupt(struct intel_vgpu *vgpu) > +static void inject_virtual_interrupt(struct intel_vgpu *vgpu) > { > unsigned long offset = vgpu->gvt->device_info.msi_cap_offset; > u16 control, data; > @@ -434,10 +434,10 @@ static int inject_virtual_interrupt(struct intel_vgpu *vgpu) > > /* Do not generate MSI if MSIEN is disabled */ > if (!(control & MSI_CAP_EN)) > - return 0; > + return; > > if (WARN(control & GENMASK(15, 1), "only support one MSI format\n")) > - return -EINVAL; > + return; > > trace_inject_msi(vgpu->id, addr, data); > > @@ -451,10 +451,10 @@ static int inject_virtual_interrupt(struct intel_vgpu *vgpu) > * returned and don't inject interrupt into guest. > */ > if (!test_bit(INTEL_VGPU_STATUS_ATTACHED, vgpu->status)) > - return -ESRCH; > - if (vgpu->msi_trigger && eventfd_signal(vgpu->msi_trigger, 1) != 1) > - return -EFAULT; > - return 0; > + return; > + if (!vgpu->msi_trigger) > + return; > + eventfd_signal(vgpu->msi_trigger, 1); > } > > static void propagate_event(struct intel_gvt_irq *irq, > > -- > 2.42.0 > -- Jan Kara SUSE Labs, CR