From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E715EC61D9B for ; Wed, 22 Nov 2023 14:51:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7EEA86B027F; Wed, 22 Nov 2023 09:51:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 775136B0286; Wed, 22 Nov 2023 09:51:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5C8376B028E; Wed, 22 Nov 2023 09:51:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4619F6B027F for ; Wed, 22 Nov 2023 09:51:55 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 1B5F61A0C8F for ; Wed, 22 Nov 2023 14:51:55 +0000 (UTC) X-FDA: 81485879790.24.B9096B8 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2052.outbound.protection.outlook.com [40.107.244.52]) by imf24.hostedemail.com (Postfix) with ESMTP id 1709118001B for ; Wed, 22 Nov 2023 14:51:51 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=J0clCN2n; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of jgg@nvidia.com designates 40.107.244.52 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1700664712; a=rsa-sha256; cv=pass; b=02Qh0TzFg5cjuB61QBfewPfmLngA34wZtP8VdKYfXMKpnrhC/Uqunqr8+EAjGADUblxiWW AhSKFe1hXadXnM8P3Anfx/AlmBJ2AGXu3CZiyPKCIMKXISHyXXjEQ0+g2MHrqLZvtg0GGL vST49TlDwcGYPZw5uBDGeYNvWrQIoDs= ARC-Authentication-Results: i=2; imf24.hostedemail.com; dkim=pass header.d=Nvidia.com header.s=selector2 header.b=J0clCN2n; arc=pass ("microsoft.com:s=arcselector9901:i=1"); dmarc=pass (policy=reject) header.from=nvidia.com; spf=pass (imf24.hostedemail.com: domain of jgg@nvidia.com designates 40.107.244.52 as permitted sender) smtp.mailfrom=jgg@nvidia.com ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700664712; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=s25QxNYVtawiJ3VaNYfhl/cCyvp1Fu1181QznpXnxak=; b=G70UKe0cOoE/gF7+gspnObwQ0RXUZ8OAnQlFnd3Qk7S+HSF3BlMGRyMGce5AAt7qhPOx3y m/K9t/bhfn4tVjkjFnLWe/M/+VnRDuPXyfPUscDdFLUNFRuqN6J7vhgGvPj2dnRJT5dMd5 MbFDJS0glhEMK2cMrSVV2BIzy+yX5BQ= ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ceoLE+r2xhpdXYQ2cE3ayxaK1BW2EWirUUffiKEfOoyOVQ24PFKVJ0iHV/gfemHAlaLxLp4akszDPkdqxqKkXR/an7rH883y5qe/md6cfmsQ03apx5WoF7t4YkKT9ziQLQ9xL/X69hQoY3GafObc0GnM+z4um8VhJzJ0IPpxbhZKOExix6m+my6PZupn5DmODWWJJ1I97EX4nrvD0L8vPHfpWbFsEyxZR0iK4oODLkkymdVZF461UG1RDn5y2Lt8OYrYEI6qEw4SN6GnDmKOgTWrr/H2L4wuCk9DOKOCth8cy41getmnIug52KhjC8q6qWZlhaxIhw5u4YFTDvjhTA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s25QxNYVtawiJ3VaNYfhl/cCyvp1Fu1181QznpXnxak=; b=EOo0huaa1JsRXxYM9W3q8I3FqMzUQQ8fX/nLhBoTrFRzyJWr6A+nL8hrSgZ0+nHnH94FKxuEgoJbdBnBd1n3lbaGzbHCA2d8/Hua0/jAB7iQ3Or3F2DHVrABY796aiAfpIRfJMmNPYHK9WdUSQGSp29yQscLgf9JBVT4EuwOYzqqjPMi7poCKeTXvFwfjj3yyVqG6y8jQRmBBzF+DgZ38ABZm6iDqstViOKG0X1AVeKBwu1yyMhd+kI7e23bKY3QeWRFPGfwiyP3j5V5S0ko/qsH+lXoOVbUyN6mJrMQl4y5PD2XDLbI91p2RanjQideJnaNy1vJZkzkND7DnRg6IQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s25QxNYVtawiJ3VaNYfhl/cCyvp1Fu1181QznpXnxak=; b=J0clCN2n+3ZH6dibxy+3kka1HoqeIK/fuh29OEyNnRV71uQJRqKc36b7pn0bWa0b13ZFRUa++5KsS0CLEVJydp/sIuOioMr6rg9aoEHO4/EZCiIvgN/W5O3JYAFNvO8oZeGqrWX2kMwxRKVnxDGgyeRc1pIfnGAEV4O9+Ltb/4DN80CIaNKI+3fkr3C0ArgFpnTPBjFmE/rl3k/epnRzHhbs6otM6PCObnjWz8VsVlZvIqDQFOkCNdnJVY4FXezHXZhn0hxaEI1mTlbsqkX7zLDgQqsObYhclFqQQbCRByTJYJ0xT/8x+AGOQMC2Yrs6SgE+B+nJNq5gk+wLBx9Oag== Received: from LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) by MN0PR12MB6174.namprd12.prod.outlook.com (2603:10b6:208:3c5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.28; Wed, 22 Nov 2023 14:51:48 +0000 Received: from LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::60d4:c1e3:e1aa:8f93]) by LV2PR12MB5869.namprd12.prod.outlook.com ([fe80::60d4:c1e3:e1aa:8f93%4]) with mapi id 15.20.7002.027; Wed, 22 Nov 2023 14:51:47 +0000 Date: Wed, 22 Nov 2023 10:51:46 -0400 From: Jason Gunthorpe To: Peter Xu Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Mike Rapoport , Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Vlastimil Babka , Andrew Morton Subject: Re: [PATCH RFC 00/12] mm/gup: Unify hugetlb, part 2 Message-ID: <20231122145146.GN6083@nvidia.com> References: <20231116012908.392077-1-peterx@redhat.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231116012908.392077-1-peterx@redhat.com> X-ClientProxiedBy: SN1PR12CA0108.namprd12.prod.outlook.com (2603:10b6:802:21::43) To LV2PR12MB5869.namprd12.prod.outlook.com (2603:10b6:408:176::16) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV2PR12MB5869:EE_|MN0PR12MB6174:EE_ X-MS-Office365-Filtering-Correlation-Id: 8738efca-cc10-4878-6f63-08dbeb6a8d88 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: prVvL3PgEPXFTW76Uhq4nIsjrWM6g7T3JPYi1b0WE9IEEUfHEvXEJBE/3TvC2pDljHRkiKlrUvzj/QyexveWOraWMRuGfte4Dn6LJrBxDPGo7leecEBxatVATclUinJ6I+pRQhgFauB3r6KK8/bzHclXTehBoFC22A3QseX+FJZs82GUHcOpxm/1pzUU1/fwXEwKRFJ/ckJCvRMCJgZP/094F3PUUsOCYxXvtYzn6HxQmXkfpIDBdbJm2ikazpuABkOo0DcMV3k/Zxavs0mIoXn9vcvyXTnjDxWE5fHoatTL4WzsFgku06wqJhsbxbh/a8BIGV10roQNRdlOUDX5OhonrIhxmE/ALdBWY6kJuolfX/FyPYFoExr0JeNCAK6esfHdCsWLiSerGxpVfhLgSkWf8650dnAUiqzsVXH7gWMMjaNrcdECieS9A29BgkT4GwlhWOdxNw4QOBVAFWCVQfM8nSWvIMPHYto2NjT2TknzVZH1GaVoT4NvQa5DhVgg0GmhxDKoxdcADKw049WHOe5ag3LMy9rHTi46RyyGHRBgGk9P7DOcdPuMz52TBLppMcq9WU3jJ5rZKvWlQ7j3orEEkX8+LCnhv23/Omc5+1M= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV2PR12MB5869.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(39860400002)(136003)(376002)(346002)(366004)(396003)(230922051799003)(1800799012)(186009)(451199024)(64100799003)(7416002)(5660300002)(2906002)(8936002)(4326008)(316002)(41300700001)(66946007)(66476007)(8676002)(66556008)(54906003)(966005)(6486002)(6506007)(478600001)(26005)(2616005)(1076003)(6512007)(6916009)(83380400001)(38100700002)(86362001)(36756003)(33656002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?SqHUqgTpfVCfwLKinqDEw0rzGUk+VT6TkklKF/YHSeUasqIJEHTHtI38o6FH?= =?us-ascii?Q?qEt1FuNsFS9lNmVdMhFqdJJSvSH1Q6JpgamLc1gVDfFveoyCl92gL0QQh5wL?= =?us-ascii?Q?a+RnGKW3cCHTHYOJ3+B4LrpLVepTdIcsQv6T2hdXST82mj7eveffTZiAjrOL?= =?us-ascii?Q?uUXvTKS7hRpSTGc6B+5eBJsaRrnVmb6tKktKZSQE8qQw+jBxmoyFkGNon2Xk?= =?us-ascii?Q?EuCKEv7QQ7+Lu877NY3H9sywsjJQ9+M76Ih9mBU6RcXhZA8HfxJNY2W2cmJU?= =?us-ascii?Q?znTCYmM3iQJroSGI3ju8XO7hFN8lSJ3QD/p7jNr9KgAqGk73cEuDuKYZvibG?= =?us-ascii?Q?gEWptzXQKTUq95/RonptYhLJCMjmso0f0exkxdmzEEN0b1hr+Fpj3L02fi3i?= =?us-ascii?Q?e8Z3YR++ojHXh5YYwa4QQ+9/jYXHfkVawM59U8jp/R/ayPG9wvh0GfKtswe5?= =?us-ascii?Q?u24EMTxPRlG59gJzuCwwJCJN91weoaIFhklpyT5BVSnwguetnroGm6Qq2Mey?= =?us-ascii?Q?s+J4fSdajytzxvFG/tAXBMVNcP+W3+3iyaWg5NIZKuHR2aias1oWHH2+9gMe?= =?us-ascii?Q?scfI60R7vGHssQbYAX/sgFUa8l/NQqsS16JUTn7z+yH+K4gnhRTiwLT40XLx?= =?us-ascii?Q?wJIAEsNWJk6hYLdKeEIw2y4ETPfjh9PKS0mzWZKEM+1litY8yF2T9mu9cndl?= =?us-ascii?Q?UWbGjA7OnN8ajw5HqZ0+f7MyqzUamzl/+lZSijKW2GNgNjdoBQPq5tcN8Mti?= =?us-ascii?Q?NZZ8d9ob+hhPmOH5EFsLV0uxR/nnGpK996O3bFmt8gLT3b6+H7hRsnJTSbdn?= =?us-ascii?Q?FQDfd6EXK5VMq32lB9ExXMXL8GrH4d808CEl04TA1o9fD6EYa5UTomyjcmoZ?= =?us-ascii?Q?HZqkH1JfxVGdKLNlwXFwlfBGzVvG83MK/uDcepF7sA5CzfXSS05653ffsNIy?= =?us-ascii?Q?LY5hRScurxD4nyjImc7RvZ0YpcSxQ8s/DboSdXMgN3GLO/hjms6AZLMVIXYh?= =?us-ascii?Q?uVGMI4scIMDlLLNKA/hn6JJJw8pY1INDvpxCkZY3LpOH5l1RNT4sPo/th7wF?= =?us-ascii?Q?jwA5JvcH1MrIKQ/5g/SsaQf/YXPql20ohcV+1OXUY2VO4mSM+JP+pvclWf85?= =?us-ascii?Q?jFzUxxkXogGSt1Uc/P8OW37hX4J5zgj3L2fsiqvrt0KqfBEGQtNk81hCnvxI?= =?us-ascii?Q?4Uctw+vtqedgDuv4d2Ua9JLI4frLvPVMcyouMNxiByw/MgGIgfMQcxtPBmC1?= =?us-ascii?Q?/LLXDYdocYh7NUIkupHWSvT7ACmcmr3mo07kqH3rUzMobP7dBSZj9WMh+/gA?= =?us-ascii?Q?+mWHu0TF1yMQi+g4WGtUQnPvpl8pCJBQiv/K0vLMw03E4AGUSoJ0wVThu+lf?= =?us-ascii?Q?rA+u/DyNWdeGVCknODRO6yHt2dztD1qZ1H59Fq/Kpv9i5jr/XMLSSBp1c55c?= =?us-ascii?Q?FL7js25ylaVYUXL1gC8t1FbfPasRSXEv+ysa6IJNNqVOOgqoiMsVXqqbEc0Z?= =?us-ascii?Q?vSGkeDYWdUhmEVd/AfOXSPkrarHV9rWINzZmOjKorJ7Adg3WSeQEGISqTobx?= =?us-ascii?Q?q21y33x3x5n3NiM0pKzpVmVgMT9azDzfgoU4Qrkv?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8738efca-cc10-4878-6f63-08dbeb6a8d88 X-MS-Exchange-CrossTenant-AuthSource: LV2PR12MB5869.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Nov 2023 14:51:47.8098 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: dPbNH4co4CDqJojZtrmuOeuprJQNv9KR6Mir3f/VCfmVJ6t/IqhH9UchhPNhnGnc X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB6174 X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 1709118001B X-Stat-Signature: g3bff4pyjs5aou6d3ud37y31fm6ixxaa X-HE-Tag: 1700664711-969094 X-HE-Meta: U2FsdGVkX1+2QN3B1Eax3Ggg1wlPPKb4V59TJ8FkcZE5gqzDD2Z9wdtF9/u4X99U8EhmK4rAstWrIZJqVtH09rqC4uu0PY2l1D8BRw3vin9a7MH/mTc9N1WHzyasD4ZUkX2wP63JajHPJdbSvUoU8Mqvl6jUM0K17z+AXMFh5+5haQ14hsERrtbGeKs0AOrJ2yHNcMbDlrIm08ANj6NMpRX4LgwKt0hs8/364+2LxWR2Uy3+ABDGAlf0v3Zc9wnvO2STZdE8eWDEUDaixa4xtUPOzjnx4E8KxMSojO7i45o9Pv53dSsbqdI3AfdG+9kknfit7d1+rSW0rXjxVRmVYMxE0upjYfed5JOMlRaOk8PlSdK76KugFNdOz7r3vKvAF9djgHfjvcLfVI5AB2PVTxiUU4baredXkZSHmbMF/eZNk8MJ3S9Qyk1Q85dBOxb0Ajgg+2EbXmk9AsI0Xmq4laG6S13AOAg6CsFtYvdW84TEW/sTJpkFvZCo/+D3R7kxN7dQtp2kGSXplCoPgO8T2fHs+uOls+uRfeJqawNSzKI7Mtr+ZVmWdXpPbt/Uzp/G2LQIvfJwSw376K5jQNquCUzIWs8n/lCxkMdTfhrS8NRG5YIc8wV5JAC4XXV9ENxuKPNluZR+8G0asGjXfvz8SDJaHvGoBowVkPPaQUPTFqXA/8J5y2FLnVav8Sc0sviNnqHVPFsopt+gWnhWTQzqgoR/nRRWr5FqCN9lqzyguVaUBa3ivNPEZ3AELBI1jG+dPlxcgcm4hXDOXmY22MU0Udn6iMrLLKr7VmA2CLJ+xKeKq/RdSN+UZ64YDgsLLdhSZu2r5Fw9YlPKX8SBUTze7vjmarx2o6Dusu1bL7ce7/es2dBgk0GlVRPCyyBB+qz79N+Wr2mB06D7DHdrKk32RmwZID9jeig5G8U6UrcSrl5O1Wn7R05XY2pTF1hQvmDlK9+5wBXWnkOQenxdRD3 m8AAafRD zCcCAp9O8GhVX9rQV5U/g68e5uWxG4RmEwwGOk04ut/EqWAup9Thv4pbRwWvd/5WKjEnI3Alo9ycHq25B5NHkaGIkeqvDQ2ojAC/oQ3xLOzzlt8QYu6FXgRluGbGqIqNfuNHy3VBRPFcfzyTB8JZVZQn6fCIB/z+wftdQhDEMQtQPL5LZ48dw/KnJklZorp4HM1GZ07ne7rq9tWSUoqqJbCY8iExT0GiHCnrYO8bXHqz256C/lRlgucO6raWm6FA5fUAHv6SaJFiX8S7WnB3oTHuYmgrTicjaOuqP7J/Ry0Btxek= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 15, 2023 at 08:28:56PM -0500, Peter Xu wrote: > This patchset is in RFC stage. It's mostly because it is only yet tested on > x86_64 in a VM. Not even compile tested on PPC or any other archs, it > means at least the hugepd patch (patch 11) is mostly untested, or even not > compile tested. Before doing that, I'd like to collect any information > from high level. > > If anyone would like to provide any testing either over hugepd or CONT_PMD > / CONT_PTE on ARM (before I reach there..), or RISCV over 64K Svnapot, > that'll be very much appreciated. I'm copying PPC, ARM, RISCV list for > that. It can be as simple as "./run_vmtests.sh -t gup_test -a" for now, > making sure hugetlb pages can be allocated along the way; the non-hugetlb > gup tests will guaranteed to be covered more or less, I suppose. > > In summary, this is a continuous work for previous series: > > https://lore.kernel.org/all/20230628215310.73782-1-peterx@redhat.com > > And this more or less is my current take to move one more small step > towards merging hugetlb code into generic mm code, as much as we can. > > That part-1 series dropped follow_hugetlb_page(). The plan of this one is > to further drops hugetlb_follow_page_mask(). The hugetlb GUP will use the > same code path for generic mm after whole set applied. > > It means the generic code will need to at least understand hugepd, and > that's already done like so in fast-gup. Fortunately it seems that's the > only major thing I need to teach GUP to share the common path for now > besides normal huge PxD entries. Non-gup can be more challenging, but > that's a question for later. This is great, I looked through quickly and didn't have any profound remarks Thanks, Jason