From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB308C27C40 for ; Wed, 22 Nov 2023 21:47:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 32D418D000B; Wed, 22 Nov 2023 16:47:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2DCAC8D0005; Wed, 22 Nov 2023 16:47:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1CB7F8D000B; Wed, 22 Nov 2023 16:47:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0D4CC8D0005 for ; Wed, 22 Nov 2023 16:47:21 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D9249816AB for ; Wed, 22 Nov 2023 21:47:20 +0000 (UTC) X-FDA: 81486926640.11.05D5064 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf05.hostedemail.com (Postfix) with ESMTP id 0EF73100012 for ; Wed, 22 Nov 2023 21:47:18 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="rzcL/Wyb"; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700689639; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=5fmH7jSv1hywixlC5YtKSf05jqkGAReZ6Pbiwgv10s8=; b=OsfEu4kPtN8uBAqqjc8Y/ALdkNSbNakcp1JcXrvPspv17xbjzhB+f0PeU5Dy3JZpotU7sF iUKEra9pEgTfG4NscG9ZMnv3eLMDkHgT6Ny8wZtCYx3jdB6IKtAm4/IGbXohtgR1nszXbx Te33/53egtdjTsM9k77wLEmP8NFrGZU= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b="rzcL/Wyb"; dmarc=none; spf=pass (imf05.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700689639; a=rsa-sha256; cv=none; b=k5OEoJ8Qcyy4Q/O6KUaIXGFV6toAWM+gF4gT67VMBnCJfeBMukd/4pCEwFlP2ho4tN7cQO b0zWVsuVWSBEveg+WgtSXhWhfcrH1g2r0njeKuwLRHBFtjr1YfTCkq5TfTqkrbcpOLTkRH PmT4jjetMJQ8HD/s3J3tGzPebSKBIjc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 2743DB827AC; Wed, 22 Nov 2023 21:47:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4EC7FC433C7; Wed, 22 Nov 2023 21:47:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1700689636; bh=9VzYb6GVbDcnppeRQnlTkvIRXkoMc3iK59bHSb8T6Rs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=rzcL/Wybyt9UUlUKYPs5udDFmAVA4CHPuJizrgnyV0S0qHksiNrRomWRr/6Hos7A3 LAHUfiZgOT0m6UY9p0GAofa1xfXfjp90eYK4sDlE3nhZaJF9KI+6iFPkyi4fe6Tm+R yAnpIA3xQ0T+cJ3v+J8d2MUvRq3ueQ/Y+2CYBvl8= Date: Wed, 22 Nov 2023 13:47:15 -0800 From: Andrew Morton To: gaoxu Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , Suren Baghdasaryan , yipengxiang , Michal Hocko Subject: Re: [PATCH] mm,oom_reaper: avoid run queue_oom_reaper if task is not oom Message-Id: <20231122134715.487677f38de74a6f8e0111cd@linux-foundation.org> In-Reply-To: <400d13bddb524ef6af37cb2220808c75@hihonor.com> References: <400d13bddb524ef6af37cb2220808c75@hihonor.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0EF73100012 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: k3crku8d8tqjpn1bj65usg4gef16t5c7 X-HE-Tag: 1700689638-392666 X-HE-Meta: U2FsdGVkX18zzJgI8IWCAOgZn0EJNzMvziEWrTpp8EfivBf/W+m9eLRX7AnSZVvDmf4WvBBa5lMH8Kc4mumfrzTbCLg5it7MlDzkulWoZlCYZdbnoBTIP0WYa3MMylGHUEj1sk+2NNFaLa6Vfxpn+z9i2Z58mL0ORFCiYBqYF9oaEfKba8eDfNzsQsdU4Ia3aOjObZu0jPj3dhXgLJmtpOcVQq3ce0/nFANg5EbsBzPG5/AeQO9OT6DlJpmwAFUN/bnwpPoR5+wPTzEk9H1a5RSD0z/E49eeYHk9V+SNeCa8SxBIjiDu6moQitRARE5aPckh/FNqP+f83JW18p5wfhEw6cy+jT0a693JpO+0qjGRH1Zut7EqZlO0K9+wvJmE9CGFDI21ZhKNIeWVeijEX20fh4Ak71nZla/lHaR4gX7Z5Yj6wKWDAoI54Rk5VV/0kdtGCNtY95u5V31Hzm8FZa3AwjQmY9J0dtvFlRBJBdzgfFSFLQ3D+dbtv6ob7iQZOpyMkDTRjNJUMPs5hgDdi11z8WpnW+dR4awwfUTdXFIy+xDJ1HCYvpEjf+JpZUfAbG59Mk6vrjohZ4Caj59nG3fTCDdk/YrF7i0c1gac070fjiLydI/bUIwf0woQ1dK68D369RpOJLsypcJAP1LWn5ARxzcMX1ARjZsqvypa3WJsIUgIL7ytblA+ZYTrr36VLFa/sKJn67mEg1oecad6Ij5c6jDaVO9DE4osU+XjYEtifLpiWA07ofTzWrCb+mitEd+JF8/JK+wYePbJVHe4s6Lx++SsLDnq14K2WZJxiu2LGInsOueaLSw0jAa7BILbjXsetUNWu/ydyVZvmcTba2JG5k/NR7Yxb2E9XZFInYUm2psoBMxcGnPDPqNoWUjEfS2iZqJRR30Q/xBNltkwWeP3UHHQyhx/d0ZufeeWE7OLtLQUZMTDPzWxZbqtNhBe+lnxph2qKBkJXG8ofV8 G+Yqmf8G oLYqGyWr8sHMGiDjpP7/XKGqSGdZsddaOAnCub2mgeGNDgL1yU+svpJNaqjItAKlcQs1lpnj1T8SVF69hcohEHK5njs7dQ7W1NWmcPjbUOcVkwvU6zkEm5e4EDtpjrUWsLn1k3CQoxgm/A5vhhk4AoRVpvDiaURj5g+aKLNWPxMva3PGnu2HB/nhPsj0/mAWNJdm3gbN41oUL0xwecAA0vQ/y/0AX2jdkJvBIGblPVd9XkxsmT4btz5TO63CtrsySJ46BP2fFTOmLbX5CtwPrHCJEu2ETcFPfrJ1DeAgNKVuABkMXQzokTbvlRy1wFq0uwcRBjGu8Dmi0RczziOxw/LFRavW4CIJHX+ZdcNSXkJKjuVCJn8ButPCSCQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 22 Nov 2023 12:46:44 +0000 gaoxu wrote: > The function queue_oom_reaper tests and sets tsk->signal->oom_mm->flags. > However, it is necessary to check if 'tsk' is an OOM victim before > executing 'queue_oom_reaper' because the variable may be NULL. > > We encountered such an issue, and the log is as follows: > [3701:11_see]Out of memory: Killed process 3154 (system_server) > total-vm:23662044kB, anon-rss:0kB, file-rss:0kB, shmem-rss:0kB, > UID:1000 pgtables:4056kB oom_score_adj:-900 > [3701:11_see][RB/E]rb_sreason_str_set: sreason_str set null_pointer > [3701:11_see][RB/E]rb_sreason_str_set: sreason_str set unknown_addr > [3701:11_see]Unable to handle kernel NULL pointer dereference at virtual > address 0000000000000328 Well that isn't good. How frequently does this happen and can you suggest why some quite old code is suddenly causing problems? What is your workload doing that others' do not do? > [3701:11_see]user pgtable: 4k pages, 39-bit VAs, pgdp=00000000821de000 > [3701:11_see][0000000000000328] pgd=0000000000000000, > p4d=0000000000000000,pud=0000000000000000 > [3701:11_see]tracing off > [3701:11_see]Internal error: Oops: 96000005 [#1] PREEMPT SMP > [3701:11_see]Call trace: > [3701:11_see] queue_oom_reaper+0x30/0x170 > [3701:11_see] __oom_kill_process+0x590/0x860 > [3701:11_see] oom_kill_process+0x140/0x274 > [3701:11_see] out_of_memory+0x2f4/0x54c > [3701:11_see] __alloc_pages_slowpath+0x5d8/0xaac > [3701:11_see] __alloc_pages+0x774/0x800 > [3701:11_see] wp_page_copy+0xc4/0x116c > [3701:11_see] do_wp_page+0x4bc/0x6fc > [3701:11_see] handle_pte_fault+0x98/0x2a8 > [3701:11_see] __handle_mm_fault+0x368/0x700 > [3701:11_see] do_handle_mm_fault+0x160/0x2cc > [3701:11_see] do_page_fault+0x3e0/0x818 > [3701:11_see] do_mem_abort+0x68/0x17c > [3701:11_see] el0_da+0x3c/0xa0 > [3701:11_see] el0t_64_sync_handler+0xc4/0xec > [3701:11_see] el0t_64_sync+0x1b4/0x1b8 > [3701:11_see]tracing off > > Signed-off-by: Gao Xu I'll queue this for -stable backporting, assuming review is agreeable. Can we please identify a suitable Fixes: target to tell -stable maintainers which kernels need the fix? It looks like this goes back a long way.