From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57DF6C61D97 for ; Tue, 21 Nov 2023 22:02:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D64146B04D3; Tue, 21 Nov 2023 17:02:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CEED16B04D5; Tue, 21 Nov 2023 17:02:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3FCF6B04D6; Tue, 21 Nov 2023 17:02:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 93E976B04D3 for ; Tue, 21 Nov 2023 17:02:51 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6823A1A0B49 for ; Tue, 21 Nov 2023 22:02:51 +0000 (UTC) X-FDA: 81483336942.19.F1733F6 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf28.hostedemail.com (Postfix) with ESMTP id ED63DC0019 for ; Tue, 21 Nov 2023 22:02:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=mgOxiBg4; spf=pass (imf28.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700604169; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VZEQ7DLTQn6OqQgSLo67A6SEZnv9L1qroObhIZ1xXOM=; b=4/jJXOWWfH7piReCsIRGcQmPifCATchqV3F5laKXz+Xc/fbz1lloF12R0o6OfV4pkO6Qct 5r8U84OcEJ68OifbJ77gRZB7aZiB3NTRKL6sT06kAiAyjgblTXurrsIXxlp3T3W2lov187 zorAWd8dFTqKyIGu65lf4+uxLuo0tCo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=mgOxiBg4; spf=pass (imf28.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700604169; a=rsa-sha256; cv=none; b=iLFAqnZoHhMNJfeBFljn4f3SriZD6KTsoRcSVjEZ02+79knqiVPIkCy4b57tv3X0XlGCJr qZmsRWQo8H0Sz1ZToKUZ1pzsjYAOlIHiWch7qCSI4N9CYoXo42Wd/Vf7v/GYV79RS5Ci0W XFyece/CZpMXsFJ6KI3wAN11OReplPk= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALJ7T9P028372; Tue, 21 Nov 2023 22:02:36 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=VZEQ7DLTQn6OqQgSLo67A6SEZnv9L1qroObhIZ1xXOM=; b=mgOxiBg4YQz5R/dVa2UBOrxvIwaMV8gKaOSpP0nUGRkAfy8E2smngYYBkApy1Txj7klW w0u13EF6RKbN36fMUJN1lj3GsGNr4s5np+a9B8SIIMK5GjEm+XxWQL8kIz0rkGZVxazl 0D6rORF698IZcZDvAAztrAt/s9DZr3ZhZL2o3G9xwTw6SuyFRn/jz1ukEsYCIKmutRc5 2s+svlOInKpxadqUns6viTOHy9npVdnDYWDFF0ATufYBghBMBCKsBz9CoHyJa/Q1OaPn HAt4AuqpEqzznpoDgPVAzisghk75pPtb0sfd8uE3842O5CoqRRtzE2vFSpH9dvwHJ0m8 6w== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uh11we6y4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:02:35 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3ALLuF5n031183; Tue, 21 Nov 2023 22:02:34 GMT Received: from ppma21.wdc07v.mail.ibm.com (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uh11we6s7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:02:34 +0000 Received: from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1]) by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALLnGnm007559; Tue, 21 Nov 2023 22:02:15 GMT Received: from smtprelay03.fra02v.mail.ibm.com ([9.218.2.224]) by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uf8knuq1f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:02:15 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay03.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3ALM2C8u22545102 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Nov 2023 22:02:12 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 7D8DA20063; Tue, 21 Nov 2023 22:02:12 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 0EC9520065; Tue, 21 Nov 2023 22:02:11 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.179.23.98]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 21 Nov 2023 22:02:10 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v2 05/33] kmsan: Fix is_bad_asm_addr() on arches with overlapping address spaces Date: Tue, 21 Nov 2023 23:00:59 +0100 Message-ID: <20231121220155.1217090-6-iii@linux.ibm.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231121220155.1217090-1-iii@linux.ibm.com> References: <20231121220155.1217090-1-iii@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: pQxE31YLEFvKPgXf6AYghjpxqouNt4v2 X-Proofpoint-ORIG-GUID: BV6bqdLe0fSLFh1pyvZJn_aJSFvjCpVt X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-21_12,2023-11-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 clxscore=1015 mlxlogscore=912 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210172 X-Rspamd-Queue-Id: ED63DC0019 X-Rspam-User: X-Stat-Signature: ezp8nocg8iucgk4b6hr7ne1krjg8g755 X-Rspamd-Server: rspam01 X-HE-Tag: 1700604168-996984 X-HE-Meta: U2FsdGVkX1/Yul04VmHfobqGe9oBD6b5BGQkC5ACzophSRjoit3Jozsxf45smmuTgpyPI2u/OhoC2oVQwmv1pOrTR9NQEozSCSIyc2Hwu8mZZeeessIA3i4Q9+7NoPJ1ZQBVGM9hCoW245RBHGNJynOY8+ExYIqOIuEYFcNfT3GIV5HxlntpAuR+KODpyp/nij54MyWvcHyg/sYXarTOKGhmttB/hGIHCzQtpGjf9TXcJrmEtCyG6TL5CdQV3eytauhpuj+5PElv3ERsV3VIYhyxRcZvLu9Yk3y+r3nodDP7uNNmUNXKvQ0gIJ3pUicqefXAAdK0UFZyDUf5cy5KbHzzWWJ/BDVItbPDGrcgugnsMvmO/SbKIEzjr3GFJiLHrQC85TFf7mDY7UTWNpJv0i1Otc8jylepgyDEj32LyfwoAUgCTuZ1dG1Tlixkm+SzPKwZhyHlRQqoApP/5btdWU3j96MhCiAUUCpqXOh1R94FN0+COFE37ZflsSPYIZBNtvOuQbX1fU7dHJQ5UB7jkmFY9VfOcZ6UDaxc+EswLxAQBumrgNTto53XFft0sT3YdqSU6lwaKVUzQ1juBRtD5mT3x6jgJJlb/LINrWZnBW++gROPx2OHpK3bNGE5OWsuC0pKDuLGwbQuArtDM0I1ToM8xdllwN1K2zEn6IEnnzZzp9ucUVDioHwy3o/mkEiqYRSUVV4l0/puqBYW3K5XdqIhhZFI/UVr5D+0K/lv8nGZISyPbnCdWuOlLexzAw9DWaWxLiKwdgj65eyAkcQYsfEwqZQF/l+/CVpJXGZWzl0Up9ltyYiskpjUiuvQncV0AZpd9JKLpwN77TaqBUUzNAnGJ2RFemdGCElOgzyOncJto1lPigFZIBMYmfkLGmbfAQyjEENPaFjWxIHqL6pBGrR8+g6v4qqYa7dYAfl/p8OzlqnfdsPIKyBU8336Ia4J7PQpz+DWUTBrKMQ/0C+ EoOArLZW C0awopt8A4yigEJTwmt7HP4/rpdvdGFfZ+n42/4xHZ7T+w8alF0pd8BFpxq+xBiYOCn1ckQMsb96wr05t3uHo8tjYUak7/pAXEAdwiKZahh2m4XfNmx/RBLHrcvlMuwZ/v6exL1w2a2u+3UC0BiqK1CxCRRLwr3VZOeMrV3Fd+Ym6/jyl+d0B3xq+tXhSzG8Pd668jNJpjCZVfqJr6reIty2t8QqI2WwqYTcmZKqfw5NbVuSE+ju3qZ4itmuj1MfZ+ay+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000005, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Comparing pointers with TASK_SIZE does not make sense when kernel and userspace overlap. Skip the comparison when this is the case. Signed-off-by: Ilya Leoshkevich --- mm/kmsan/instrumentation.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/kmsan/instrumentation.c b/mm/kmsan/instrumentation.c index 470b0b4afcc4..8a1bbbc723ab 100644 --- a/mm/kmsan/instrumentation.c +++ b/mm/kmsan/instrumentation.c @@ -20,7 +20,8 @@ static inline bool is_bad_asm_addr(void *addr, uintptr_t size, bool is_store) { - if ((u64)addr < TASK_SIZE) + if (IS_ENABLED(CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE) && + (u64)addr < TASK_SIZE) return true; if (!kmsan_get_metadata(addr, KMSAN_META_SHADOW)) return true; -- 2.41.0