From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C5DBC61D97 for ; Tue, 21 Nov 2023 22:44:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8BF6A6B0515; Tue, 21 Nov 2023 17:44:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 86E9E6B0516; Tue, 21 Nov 2023 17:44:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 70FE26B0517; Tue, 21 Nov 2023 17:44:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5D4146B0515 for ; Tue, 21 Nov 2023 17:44:02 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 283EB160138 for ; Tue, 21 Nov 2023 22:44:02 +0000 (UTC) X-FDA: 81483440724.07.40533DC Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf04.hostedemail.com (Postfix) with ESMTP id DF22F4001A for ; Tue, 21 Nov 2023 22:43:59 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="W/CF/I1E"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf04.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700606640; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CK3CSFhKHiUxb3M2GZk8QRFPFYlA6+i6yOOL0Bh28Bg=; b=o9AeTEMr03qkV002cSmjMyJUFx0uvIzTYU9iQhBo5NEm9Ne32NLoMrZ2JmrgVcb+YVF5wv a9FojBmekkKq8oSQAlvK+HSBebDZCo/d5CqzJ5a/rsWXl/luKL11wnpZL9B9/AT1L/rBU0 Tg6oREAfHbS6gIEifmGeCFEj3O3CaxI= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b="W/CF/I1E"; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf04.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=iii@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700606640; a=rsa-sha256; cv=none; b=DSZirUiuctHOIrkPpV0usheO2y4Ad53xNVyrWII4SDP43Q7HuIFhd6bLn95z/wuvMSNuO9 E4GJ7SCzFRFjy0Z0ATUbG7DmyBgGJ9U5lh3kyFIHWTUd2cMRwiDXGfCt1wHXP4qSGBizsp vpxWMBSkmnQFEjIQYIZD3jwR6sjgXio= Received: from pps.filterd (m0353725.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALKekZm011151; Tue, 21 Nov 2023 22:02:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=CK3CSFhKHiUxb3M2GZk8QRFPFYlA6+i6yOOL0Bh28Bg=; b=W/CF/I1EX6biMLOKc9PUQRAalGor/8oSut7ySySGNTNa4a8x5PNV8FSF8CLRDVNBlTmi GlgJnHfMnpbju7kaInn0IqkNAVnTxKM7MMVtdp8k/WIxdFRwDzzO/NvjxKFanK2xG9JH mpXBB8439wXZB8FdsKiF2ow/OWEG3WChBUlEb0M+9T7QUqnULSegINy6SBVQro6jQsnL M5GLuxl6Vqtve/OvqaneWOUQmwK+EoV624y/S2M1uyxbaD6CB39T+3soEVeaFGRG75YB XCJB1PdWYuUVgvYnDf2wOQO8bW/FaMalWhMZCsU1oSprj1j0jyDdE6Wsi6l9Pn1Y+I8F tw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uh11we714-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:02:39 +0000 Received: from m0353725.ppops.net (m0353725.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3ALL31Hj002005; Tue, 21 Nov 2023 22:02:39 GMT Received: from ppma11.dal12v.mail.ibm.com (db.9e.1632.ip4.static.sl-reverse.com [50.22.158.219]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3uh11we70q-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:02:38 +0000 Received: from pps.filterd (ppma11.dal12v.mail.ibm.com [127.0.0.1]) by ppma11.dal12v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3ALLnbrP007085; Tue, 21 Nov 2023 22:02:38 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma11.dal12v.mail.ibm.com (PPS) with ESMTPS id 3ufaa236g9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 21 Nov 2023 22:02:38 +0000 Received: from smtpav06.fra02v.mail.ibm.com (smtpav06.fra02v.mail.ibm.com [10.20.54.105]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3ALM2ZH943909796 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 21 Nov 2023 22:02:35 GMT Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 490F82005A; Tue, 21 Nov 2023 22:02:35 +0000 (GMT) Received: from smtpav06.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id CFA4420063; Tue, 21 Nov 2023 22:02:33 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.179.23.98]) by smtpav06.fra02v.mail.ibm.com (Postfix) with ESMTP; Tue, 21 Nov 2023 22:02:33 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Heiko Carstens , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH v2 17/33] mm: kfence: Disable KMSAN when checking the canary Date: Tue, 21 Nov 2023 23:01:11 +0100 Message-ID: <20231121220155.1217090-18-iii@linux.ibm.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231121220155.1217090-1-iii@linux.ibm.com> References: <20231121220155.1217090-1-iii@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: iUsqkWYyrhNADZGpwnA5Io58eqlH7Hnh X-Proofpoint-ORIG-GUID: CgIeml__PbROJN7brRp4YdQnBlj9DIyx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-21_12,2023-11-21_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 bulkscore=0 impostorscore=0 suspectscore=0 adultscore=0 malwarescore=0 priorityscore=1501 phishscore=0 clxscore=1015 mlxlogscore=999 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311210172 X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: DF22F4001A X-Stat-Signature: btuser8r1g5g61nw1tpdkx9r4qb46irn X-HE-Tag: 1700606639-909665 X-HE-Meta: U2FsdGVkX19//KnNERccue4UAdCKcRjF9sqUQM9tOMkbHb2VnbLpOnFutiMqyx3PNtFlnUC56I5ph2FHfYuvNalo6ftMliMiAH5k9drIrcSh1FuK6zBfRz9evslFnqD3mGBPmew+ZmAE8O2t+C2S6vvQW1TS9A/p02uEPvdAtZti0HO3Mk0n8BaNReR5jtBhljthjV19OxfJiJaSHHzGeP3wHDGtVbPvYv9eHIulkIoaqhq/TjVnkaWt+XbMyuQtX5C8rWgFo5zTd6eaKc2wzZYF75MWFAD81ZBN9SiY9+Vepg/eCXGFfo8EXB09V18D9ZwzCQAyDVawsupTyq5qAKy63bDJbEAZsCIpgQgGKhk+V/Q8LeRziKm//mKc/7TNYaDZuKD3Ag4Lx8QmUm3wJzdD03wjeugsb/6jQfFCuJxtgHCnJTtfGxjDq1Nf0np+ByBeFi8a4ap1QOGs4E+1CGGNR9haJZZO7YJVAFxuSHuv1Syx6bmy4u4T508B6FjLBVZzcM5abX9k8VcumQibN/+LelcVdSl98ObHNi3e83MkZpsjwB3k06+XC7pLTmvVYvQ4IxFVYyj4e+0aRGoV1JhtmftW/gN4cyWoqnwzUTmWee+0J7riqNBFiAjlF0LvsYDUUqygH1L7PX7dYrLePAZePuXoGIYxPzlWnOgh9xxB+kcgBiaxYXPig16sOX5nWrexCNmwQhmZSx5eDNs5QlGoO6pDJp01hu4ptAWes2+TY94ipxPKyT3fzj4x8pADqQjGmWbX4/eu9LAvuzLknqZzt/w8uPu14mFUedfe7NBUCLKVjwgsFbGf3Kzs2VcdjunH8CThuZgqEqb4TFxV/R42cxfogKxd5o+C8dAzMaQceMfuDGNeyGsICUQRDJxf67YhFLCztu0p2Gx3TEOzRT8Y0w29P9OmYvd34MNYxMtrVpz1lZAKa1aFbVOpi2EaxkhlGr8gQY/VtdJZzDD kiY4Cjid /hbqd97F4joR4jhNw5ghfwgGobUwqbaor73WejHrVFmVLnN5nGyerNlnFzEMmwjVfv3qh+vPs3qPr2d8oAap4q0zLT7vVpcpvoSjW+O90090Jieny4PvYdiX/9YrfE5lo+aR64B5kEHg2XYsQtc2ABtgQSSooCzjGQDBOi0wQAvTkSlS1L/5drlrAzaZXP2bxX/EpUME132+d2dp2/mVvwP6oyni5C+G+mzCZPGzEzejc2aQhCh/JhwvpCS0lPo4FFpzsho/GLANEqd2TXGMbyX/dy5IJ/njC2l/HlkLCuAopawedThrC4ePUZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000033, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: KMSAN warns about check_canary() accessing the canary. The reason is that, even though set_canary() is properly instrumented and sets shadow, slub explicitly poisons the canary's address range afterwards. Unpoisoning the canary is not the right thing to do: only check_canary() is supposed to ever touch it. Instead, disable KMSAN checks around canary read accesses. Signed-off-by: Ilya Leoshkevich --- mm/kfence/core.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/mm/kfence/core.c b/mm/kfence/core.c index 3872528d0963..a2ea8e5a1ad9 100644 --- a/mm/kfence/core.c +++ b/mm/kfence/core.c @@ -306,7 +306,7 @@ metadata_update_state(struct kfence_metadata *meta, enum kfence_object_state nex } /* Check canary byte at @addr. */ -static inline bool check_canary_byte(u8 *addr) +__no_kmsan_checks static inline bool check_canary_byte(u8 *addr) { struct kfence_metadata *meta; unsigned long flags; @@ -341,7 +341,8 @@ static inline void set_canary(const struct kfence_metadata *meta) *((u64 *)addr) = KFENCE_CANARY_PATTERN_U64; } -static inline void check_canary(const struct kfence_metadata *meta) +__no_kmsan_checks static inline void +check_canary(const struct kfence_metadata *meta) { const unsigned long pageaddr = ALIGN_DOWN(meta->addr, PAGE_SIZE); unsigned long addr = pageaddr; -- 2.41.0