From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED9E3C61D97 for ; Tue, 21 Nov 2023 21:20:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 809F16B03C1; Tue, 21 Nov 2023 16:20:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 791D86B0461; Tue, 21 Nov 2023 16:20:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65A7E6B0464; Tue, 21 Nov 2023 16:20:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 58CF76B03C1 for ; Tue, 21 Nov 2023 16:20:38 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2DDA014084A for ; Tue, 21 Nov 2023 21:20:38 +0000 (UTC) X-FDA: 81483230556.20.E3C54EA Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by imf04.hostedemail.com (Postfix) with ESMTP id 5552840022 for ; Tue, 21 Nov 2023 21:20:36 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Wcw0IlGu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of mhkelley58@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=mhkelley58@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700601636; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=huLzv0PM0TYdV6aZ2lF/u0VoqugwXORYCB79pbYxdec=; b=bPGUs79H6+yF/G07cd2wxsQc1GL3tYu8J5N76uMgreWVpsD0pa9sGqcy6UY+Siy8VujEJs iJTXSLmB2VLpcNB7qjW7FP4zgVSSo6ZXa//GbtuwEGOrg3Wey04CPtOxgrk6KUnvnydlfk /PlNT5RzK5GctPMhDPOYk+M6g6iUJ+k= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=Wcw0IlGu; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf04.hostedemail.com: domain of mhkelley58@gmail.com designates 209.85.214.177 as permitted sender) smtp.mailfrom=mhkelley58@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700601636; a=rsa-sha256; cv=none; b=iSHL3VdLvMn/VUH+6QeVU9AalLYcTw1bzre2k5CjFgQ80Rjj6QMnFIU6d8rpWiNVUzqCoO tZpv0ZvKsnWdCHIS0f3gSKw+qUILN4FFCIRVTUAw5HJG3hutCFQNtETUstv7HMJxRpQRCB IaD+sagGUizgW4YemX8qR7Yq5nGEb34= Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-1ce3084c2d1so50992165ad.3 for ; Tue, 21 Nov 2023 13:20:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700601635; x=1701206435; darn=kvack.org; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:to:from:from:to:cc:subject:date :message-id:reply-to; bh=huLzv0PM0TYdV6aZ2lF/u0VoqugwXORYCB79pbYxdec=; b=Wcw0IlGuaOTKBJp6sSgci/Df5YcbggAM+w4VklghgiqtxiVHkwmEIn6irGjV01nzCZ bxxK1ahtAjT0TRXvitU9Ze5RJ93otVbik5tPDXlnAHITo6AH2mOfV/IVX2rZS1kLVWuD q2W7LyFp33h8nq+T187vPokDrLK6q15T/V5JeUK8OV14OcE0rb99j2JLhNavXvYFyZWA cEY3i7llyQ43+YpZ65OyUhEqIfj+TTH7hle0E07/Ch641IZBeStrOdX3IVE7UHMj+6aY 2HjQSoCqBB6ufofj51FSVx6NYJNjuU3bSeQhcfhwZGNDL20ytS60HAyT3E/IVSKbhR5K QCCQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700601635; x=1701206435; h=content-transfer-encoding:mime-version:reply-to:references :in-reply-to:message-id:date:subject:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=huLzv0PM0TYdV6aZ2lF/u0VoqugwXORYCB79pbYxdec=; b=mKOrI9BVBf+387CfT8fYBA7qFJMeT0AQm8BGClPCEhSwxGzfCNbI3/ocks9cmgntgl 9e8rhaxCpLpv4UVZKIrWOpNgIgR6HV4JXKPkrZ0oWIzoOGqR3vuteofhnBMHX+1iLUFC jysnpyjV/1WvnaQKQKiffX96kBBcxRhphREucIGOmWYYaFxcjIsA0eXommgo/Zj6Use5 6mqM4pQVIV6O54xZHY3jbh97WeGt6IMOL1sg7y4Y+fD+cYedMrLW7Dgj5T6rX6SdubkC T1Uxvy0RSrDHDX8vqE5iJOQ3/j1d3H5OuTvw4wryGW6kcG4cTlOKF2ghhwUmcsZVWXYP a2Bg== X-Gm-Message-State: AOJu0YxLuSVbbOXuawZPJwJ88grkVapJ3CrV+TdKIx3FcGRj4MsO91dR X7gqC1o4aCv6a2SJbh+PCdVC8NeQ0EA= X-Google-Smtp-Source: AGHT+IGu3jcvDWzMmd2brW4AbNgRjSnITFzU3bEr293ek/NBxeKno17B5zHl10Y2Oi8nNIq+gnZz2g== X-Received: by 2002:a17:902:b687:b0:1cf:6d46:9f2f with SMTP id c7-20020a170902b68700b001cf6d469f2fmr351299pls.48.1700601635304; Tue, 21 Nov 2023 13:20:35 -0800 (PST) Received: from localhost.localdomain (c-73-254-87-52.hsd1.wa.comcast.net. [73.254.87.52]) by smtp.gmail.com with ESMTPSA id j2-20020a170902758200b001bf52834696sm8281924pll.207.2023.11.21.13.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Nov 2023 13:20:35 -0800 (PST) From: mhkelley58@gmail.com X-Google-Original-From: mhklinux@outlook.com To: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, dave.hansen@linux.intel.com, x86@kernel.org, hpa@zytor.com, kirill.shutemov@linux.intel.com, kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, luto@kernel.org, peterz@infradead.org, akpm@linux-foundation.org, urezki@gmail.com, hch@infradead.org, lstoakes@gmail.com, thomas.lendacky@amd.com, ardb@kernel.org, jroedel@suse.de, seanjc@google.com, rick.p.edgecombe@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com, linux-kernel@vger.kernel.org, linux-coco@lists.linux.dev, linux-hyperv@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 2/8] x86/mm: Don't do a TLB flush if changing a PTE that isn't marked present Date: Tue, 21 Nov 2023 13:20:10 -0800 Message-Id: <20231121212016.1154303-3-mhklinux@outlook.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20231121212016.1154303-1-mhklinux@outlook.com> References: <20231121212016.1154303-1-mhklinux@outlook.com> Reply-To: mhklinux@outlook.com MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 5552840022 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: nmnzae9onzazcwm5tqgnaoumey73exjs X-HE-Tag: 1700601636-563813 X-HE-Meta: U2FsdGVkX1/HVaxPCOXiy3FCVImzrPnU+/t9QBJBSeEnEy2zhe4YaRP/Q7NbMezNeFNgcqMZ1m3HowPBRfc5tiqvY7/HPIPS3YQQLsb3h86oUT1bZjurLsLCegntrkmkqRMrpzBBABShjipF8oS2zz74sXVnWF6y7c6SZyj9HM2qFgCrmtIQPo8cTPb63OBefjR+XN7qB8E+C8g1SWcdkCHRhdH8HfM3FAvC2kGuU1moFdtz8DW6+rQnbuoGcXC7ch/sIkL+fnsouxfmr/pZg5ArxJevI6HTXo09TRXIlk7QPsOqxghE/Ae6w6BbHhtdJHMOe6RlR6XMh0Kb0qWe87pD5ZjYtEFgIL0+UZ33Nz8jUziz5xPQf+xHvmSMxzhPKxHslvoVtJ+95S7Ka8gnC6tTPo9rDuyik5BVFIaNBWMgvj3fvNNpVQ6B886G9BRTXn0fj//egwJriC+jX6Nz/CJEov13edwIOqcNrin3RO9Zxm9WEa+hqr0y/tMVGPoPOdGtexj8Jt9t+Y+zSOngcMxS1oQS6RtzaJKR5rJO9p5sgMndhAAiake6zEVkSvkCQXIjca04P4HuPbugroQATKPWQ3H3+apmRypzCAY6BrcLq21KQ3jT4MG/xGYMuxCG2zlcTNC2tXtXnuy0IjEbBcCQjo2LFvKIbuwg+Nj3AMwMqWOB97XYfCJYN4shdUvpQ8KzepeNfWXXt7zRlP7r0liilxWvJNWYxm+ALf4BNDxeEWaq+QU7Y1kcaxmvqRM+qpy1T7fAt+oT64LBGPfrIGlap9ccAk0FrX9UIKgbCYpy2Q1aNirf6bbVHYsHbldsD6x7rMfJ4gDGnUmNEpnjA5WoZCBny9/zmd/rMpfW7aeImeEZ4GYx+zchd0E1i7u6WNGDBD80U7/9evJKic5fMRjhICsJXqfE2/ZjKm58XIKTHrcZpErp1QNDO6QZuLebWr1y8tZSQkuKgBkuCX+ 2fYRle55 rZe5qOZh8O7DIRgSBy/11r+UTZ99aFTtcQQtUoAY+DQPX/HttyJZt6oX0jzNPU2fRmoN5JOsgcH52aFSFw6NcZAtJhdtxm9UF0LRip7JvlyWfFkvW0WQQ7X6Dd8DnfW6SOLXR0PDYB+EY68GikZpe5HibRWteGJr+TkSmahgNRmztFjpdUy6JJiGYTaCxB3cRQC/nV81IBAzOTN3yya7dFIqLCPygoztzEqStHNNzb4SPcLX2R3JqhgWuAWEXtM6d/NjrvEphMCM6ItH2lMe9wE5ra9cZHiWez4Kw2nWTLhhJHUN8PP0uIkYJzuFhNYlbMiEB/S08jXPy6tVu5AMxQBi2iAhd16BM6Xz+V08XdXyNIIJi9oJkCaXgyjjmqqq38MUfBR164jar1yPJKZjNFY/zTRVPZLoq7hjXx+QhxL2j+Pw4N4q+FVHv7QdYihrm1aJyF6vu74yG32PWjqAaUz3Pf96iEhMhm4kLcfBpIUfNhhpIg5jLkPOTJkw2YjAf1/SbcXOgPGnQjYhYqiRm1ucbGKRTNOrB7AAKMZuJMJj2DNS4jBf5TB5Jva++KccqyXtMm5bAtds7/z+rOFck9XjgLcGeCu6EuRBrif4NfocfXP/jyHwOxtmGSIvKxG1qR8S8EFsnHCmFKEE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: From: Michael Kelley The core function __change_page_attr() currently sets up a TLB flush if a PTE is changed. But if the old value of the PTE doesn't include the PRESENT flag, the PTE won't be in the TLB, so a flush isn't needed. Avoid an unnecessary TLB flush by conditioning the flush on the old PTE value including PRESENT. This change improves the performance of functions like set_memory_p() by avoiding the flush if the memory range was previously all not present. Signed-off-by: Michael Kelley --- arch/x86/mm/pat/set_memory.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/x86/mm/pat/set_memory.c b/arch/x86/mm/pat/set_memory.c index 8e19796e7ce5..d7ef8d312a47 100644 --- a/arch/x86/mm/pat/set_memory.c +++ b/arch/x86/mm/pat/set_memory.c @@ -1636,7 +1636,10 @@ static int __change_page_attr(struct cpa_data *cpa, int primary) */ if (pte_val(old_pte) != pte_val(new_pte)) { set_pte_atomic(kpte, new_pte); - cpa->flags |= CPA_FLUSHTLB; + + /* If old_pte isn't present, it's not in the TLB */ + if (pte_present(old_pte)) + cpa->flags |= CPA_FLUSHTLB; } cpa->numpages = 1; return 0; -- 2.25.1