From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F66CC54FB9 for ; Tue, 21 Nov 2023 08:46:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BA8A96B047B; Tue, 21 Nov 2023 03:46:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B57096B047D; Tue, 21 Nov 2023 03:46:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1D956B047E; Tue, 21 Nov 2023 03:46:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 930EF6B047B for ; Tue, 21 Nov 2023 03:46:55 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 3EFAFC04FF for ; Tue, 21 Nov 2023 08:46:55 +0000 (UTC) X-FDA: 81481331190.05.8CAE6B8 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.10]) by imf06.hostedemail.com (Postfix) with ESMTP id DD79518001A for ; Tue, 21 Nov 2023 08:46:52 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bRO3leBx; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700556413; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lkxC+fZ+zg87Q5mFiex2mnpp8fak6LTN0d8YB3fE0GU=; b=UzpkCXHM1IuJN66GQJyksVeFViQ6u2VytQce4j7+vjnGT73RDacOrB15nUJlHBYVD6Qdnr zmjKgTugHKq/e9kdjNQphrMCLNUuqPAFAMLO3qaEtCKnNoQ8wa6jxHqMzGy3KWeHQiXBaA 98CXrcGfdosl569FbHwl0OnCGMCTvDw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700556413; a=rsa-sha256; cv=none; b=hHHonDyk0mLM6fHZRkluuYRcvsOQisG35gw304OkqlUTs83PTiLY6j7yMsZAwz2VpTrFEy b5F7mOXpAOvHqA1E02fXYAb3orPkoz84dJx1suCtei7K+WqlfFqAqAaPC4liLKp/RBAf3h vzMI1sJ0AeT+5fqPskvXtAjaDyPnDG0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=bRO3leBx; spf=pass (imf06.hostedemail.com: domain of lkp@intel.com designates 198.175.65.10 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700556413; x=1732092413; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=hac0kukbZz6JY7rDm54ZjRjFk4pFlz0OMpo25ey4LNg=; b=bRO3leBxGDb8dwVJvhENgdF0Pen1Qa4CeIsH1N5f0R414TIPiQUsxhtz 6OqkQ9GGmuxYVE98pVkkz6/1JNI/Q5QgKXHTzPZ+NPwYKuHBf6SZN+EVN i0BzflddIBkm1tcaJolrSKMGio4D7g0l7qWNIbkyshj5fWE1FXMfjjaC4 jP1E0DUh3ELmR4xBSuYDKfWnNYBpoF3aCeTsXT+QHBm1EWrFa8K2Wwwe2 uHfEe5I+KnnZ5X7X3txRr82uVk5iJQ+wvoUZNO4xrGtk0WvZHb082UJDD iq8oEWYfWuL4g6GjhO+7FJTyQ5sXSaZ+3DH1n9KpTkRxgzglU6QUUfzGU Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="4988546" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="4988546" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orvoesa102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Nov 2023 00:46:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="760032494" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="760032494" Received: from lkp-server02.sh.intel.com (HELO b8de5498638e) ([10.239.97.151]) by orsmga007.jf.intel.com with ESMTP; 21 Nov 2023 00:46:43 -0800 Received: from kbuild by b8de5498638e with local (Exim 4.96) (envelope-from ) id 1r5MP1-0007aE-13; Tue, 21 Nov 2023 08:46:39 +0000 Date: Tue, 21 Nov 2023 16:46:01 +0800 From: kernel test robot To: Philipp Stanner , Bjorn Helgaas , Arnd Bergmann , Andrew Morton , Randy Dunlap , Jason Gunthorpe , Eric Auger , Kent Overstreet , Niklas Schnelle , NeilBrown , John Sanpe , Dave Jiang , Yury Norov , Kees Cook , "Masami Hiramatsu (Google)" , David Gow , Herbert Xu , Thomas Gleixner , "wuqiang.matt" , Jason Baron , Ben Dooks , Danilo Krummrich Cc: oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Subject: Re: [PATCH 1/4] lib: move pci_iomap.c to drivers/pci/ Message-ID: <202311211641.ThSnuFs7-lkp@intel.com> References: <20231120215945.52027-3-pstanner@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231120215945.52027-3-pstanner@redhat.com> X-Stat-Signature: iue6sfbrdzsbtjhtnr5k36uptz386r9p X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: DD79518001A X-Rspam-User: X-HE-Tag: 1700556412-265205 X-HE-Meta: U2FsdGVkX1/VP/10oj0oaEQ11KiL55JS+lKTaZsXEK+G4vQhu63fKSzOTGfeNNZc9WI6Z9qkaiCNtFGhZAngAwGcXsK1OxX/nAapWDPmkZFz0N3rNNPAg6z6rOWKXf0O1oNL+Zsj3HqI7zbPzTkGlsZe2/ottQnmcyD5FMw/Ha7AADhVYzC59qwKifCYmz3HmlZ2jnRM8ZtJdC0cvUx0PeNt5SUU684UwHC7vDAZTIjT2Ayadq6iCqUxco81LcuErHqpQUQnoNQ+EfPfla9nYl+Ka+WHdM8eHP5ewszu7UdI+rWjSbi5KAyChdBDXUhA1j6KgcBqwaaEYUUf8Qc9cCeDHZBDHiwdenWhKhSOsf9ArpqsUbrnAPAi4uaijQu047aDGoAg8RYDK2FWzaCL39yzhcNKYY6SFmruHXuDYT5vDEo/1UsznEuSSYp5Mqfl4XMyvGRwisV773gEhULin4+c9xASSSvpX84VHXHciEJq3WsctbHKUKvpre8L1DUJT/aYksf8/wDdRaF9ARv0I/Fao25oiK1yZ9GA0Ih5HAP2GS0jO15SjgsLsGKYeWb0P5WyvevNMCkpH+csjNi1QFAuZoz13DHZK21qLXGCpFSOPJa9w9NymAZR7cS2pKrpRRL5IuycgoojbvW6OGicusbnF1+e1OCjRCU8qM7E37lI0gpBngXunPryJsa4tJWuHdWUDJCW8tNBdhkq9zNA41wwbRO3nqTcOZTrFoN2ABRoP1BUaolXBd0eMD6TUKdIrtzp47r3sQmdATUt51hURfIcDPa/BUNCnSfOyiBRvCdL3FVGRPW/kCEFQcUcinuGK1ulQzRXhMTZ8Qf4JP722gzjIgRqONM+342IQh9ilqtBzwAkDS4GgRlGprJIYnDmEzUYfkUyjgKqW4pz9hCFHNH25DmTWSn1i7dpzQC4uSwHmC8q5zWSyqZMm/kRdvzVnW/afmMRKq3kHCFmheS r+zju3Li lNhhTXjFkv/tlNjNj94GKBwH/wAy/+iKKIS9EOez0ixGZPaVH8gF2RLBwZ0Ovd72wfYhVIZN3lukGj55iY6BoTqCrTSj8zRcK68s/wT97CZt3/eLtpKbxpjhYO9JNJPIThnrvRCPPcAVb5+PNaw1chNTKJ55NAa/W8fgVjmVzCj4TLNOKcvAHNdJXYBLUDU2bGNvIV4EK/obq/WUSRfh1I5lu621H2I5yhCvv8ZWXpoyxAOiJu0iLU7vxEkn/CYgoOXna4kLT7PD+nQtv2S8KsgMRa6fUTCGO5iaRDc9UgyNTcD90+lFagOjElcpr2vplMtpx+emVFMHGpkXwpsMx2DIiOjma4tPBlF9necUhuYEXJamuO3s1FJK5MR43/ju5Am7KKjQHv1COFSdaFfiNpMbjnjr/ZyuvGat2Sb34XNNhyGkhkgIyJOTm0GZf/5wzSSMrYQ30CqqmRxtTq60TwD31I8wJN2WCE2uhjgqlcHZJ++5E+d3wO4/3kIDt1aJQnZ0U X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Philipp, kernel test robot noticed the following build warnings: [auto build test WARNING on pci/next] [also build test WARNING on pci/for-linus linus/master v6.7-rc2 next-20231121] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Philipp-Stanner/lib-move-pci_iomap-c-to-drivers-pci/20231121-060258 base: https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git next patch link: https://lore.kernel.org/r/20231120215945.52027-3-pstanner%40redhat.com patch subject: [PATCH 1/4] lib: move pci_iomap.c to drivers/pci/ config: x86_64-buildonly-randconfig-004-20231121 (https://download.01.org/0day-ci/archive/20231121/202311211641.ThSnuFs7-lkp@intel.com/config) compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/202311211641.ThSnuFs7-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311211641.ThSnuFs7-lkp@intel.com/ All warnings (new ones prefixed by >>): drivers/pci/iomap.c:27:15: error: redefinition of 'pci_iomap_range' void __iomem *pci_iomap_range(struct pci_dev *dev, ^~~~~~~~~~~~~~~ In file included from include/asm-generic/iomap.h:113:0, from include/asm-generic/io.h:16, from arch/x86/include/asm/io.h:327, from include/linux/io.h:13, from include/linux/pci.h:39, from drivers/pci/iomap.c:7: include/asm-generic/pci_iomap.h:44:29: note: previous definition of 'pci_iomap_range' was here static inline void __iomem *pci_iomap_range(struct pci_dev *dev, int bar, ^~~~~~~~~~~~~~~ drivers/pci/iomap.c: In function 'pci_iomap_range': drivers/pci/iomap.c:43:10: error: implicit declaration of function '__pci_ioport_map'; did you mean 'devm_ioport_map'? [-Werror=implicit-function-declaration] return __pci_ioport_map(dev, start, len); ^~~~~~~~~~~~~~~~ devm_ioport_map >> drivers/pci/iomap.c:43:10: warning: return makes pointer from integer without a cast [-Wint-conversion] return __pci_ioport_map(dev, start, len); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/pci/iomap.c: At top level: drivers/pci/iomap.c:67:15: error: redefinition of 'pci_iomap_wc_range' void __iomem *pci_iomap_wc_range(struct pci_dev *dev, ^~~~~~~~~~~~~~~~~~ In file included from include/asm-generic/iomap.h:113:0, from include/asm-generic/io.h:16, from arch/x86/include/asm/io.h:327, from include/linux/io.h:13, from include/linux/pci.h:39, from drivers/pci/iomap.c:7: include/asm-generic/pci_iomap.h:50:29: note: previous definition of 'pci_iomap_wc_range' was here static inline void __iomem *pci_iomap_wc_range(struct pci_dev *dev, int bar, ^~~~~~~~~~~~~~~~~~ drivers/pci/iomap.c:110:15: error: redefinition of 'pci_iomap' void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long maxlen) ^~~~~~~~~ In file included from include/asm-generic/iomap.h:113:0, from include/asm-generic/io.h:16, from arch/x86/include/asm/io.h:327, from include/linux/io.h:13, from include/linux/pci.h:39, from drivers/pci/iomap.c:7: include/asm-generic/pci_iomap.h:35:29: note: previous definition of 'pci_iomap' was here static inline void __iomem *pci_iomap(struct pci_dev *dev, int bar, unsigned long max) ^~~~~~~~~ drivers/pci/iomap.c:131:15: error: redefinition of 'pci_iomap_wc' void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long maxlen) ^~~~~~~~~~~~ In file included from include/asm-generic/iomap.h:113:0, from include/asm-generic/io.h:16, from arch/x86/include/asm/io.h:327, from include/linux/io.h:13, from include/linux/pci.h:39, from drivers/pci/iomap.c:7: include/asm-generic/pci_iomap.h:40:29: note: previous definition of 'pci_iomap_wc' was here static inline void __iomem *pci_iomap_wc(struct pci_dev *dev, int bar, unsigned long max) ^~~~~~~~~~~~ cc1: some warnings being treated as errors Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for GENERIC_PCI_IOMAP Depends on [n]: PCI [=n] Selected by [y]: - GENERIC_IOMAP [=y] vim +43 drivers/pci/iomap.c 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 11 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 12 /** eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 13 * pci_iomap_range - create a virtual mapping cookie for a PCI BAR 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 14 * @dev: PCI device that owns the BAR 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 15 * @bar: BAR number eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 16 * @offset: map memory at the given offset in BAR eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 17 * @maxlen: max length of the memory to map 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 18 * 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 19 * Using this function you will get a __iomem address to your device BAR. 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 20 * You can access it using ioread*() and iowrite*(). These functions hide 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 21 * the details if this is a MMIO or PIO address space and will just do what 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 22 * you expect from them in the correct way. 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 23 * 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 24 * @maxlen specifies the maximum length to map. If you want to get access to eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 25 * the complete BAR from offset to the end, pass %0 here. 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 26 * */ eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 27 void __iomem *pci_iomap_range(struct pci_dev *dev, eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 28 int bar, eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 29 unsigned long offset, eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 30 unsigned long maxlen) 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 31 { 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 32 resource_size_t start = pci_resource_start(dev, bar); 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 33 resource_size_t len = pci_resource_len(dev, bar); 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 34 unsigned long flags = pci_resource_flags(dev, bar); 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 35 eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 36 if (len <= offset || !start) 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 37 return NULL; eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 38 len -= offset; eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 39 start += offset; 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 40 if (maxlen && len > maxlen) 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 41 len = maxlen; 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 42 if (flags & IORESOURCE_IO) b923650b84068b lib/pci_iomap.c Michael S. Tsirkin 2012-01-30 @43 return __pci_ioport_map(dev, start, len); 92b19ff50e8f24 lib/pci_iomap.c Dan Williams 2015-08-10 44 if (flags & IORESOURCE_MEM) 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 45 return ioremap(start, len); 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 46 /* What? */ 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 47 return NULL; 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 48 } eb29d8d2aad706 lib/pci_iomap.c Michael S. Tsirkin 2013-05-29 49 EXPORT_SYMBOL(pci_iomap_range); 66eab4df288aae lib/pci_iomap.c Michael S. Tsirkin 2011-11-24 50 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki