* Re: [PATCH 1/5] jump_label,module: Don't alloc static_key_mod for __ro_after_init keys
[not found] <20231120105528.760306-2-vschneid@redhat.com>
@ 2023-11-20 21:38 ` kernel test robot
2023-11-20 22:47 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-11-20 21:38 UTC (permalink / raw)
To: Valentin Schneider, linux-kernel, kvm, linux-arch, x86
Cc: oe-kbuild-all, Peter Zijlstra, Thomas Gleixner, Borislav Petkov,
Josh Poimboeuf, Pawan Gupta, Ingo Molnar, Dave Hansen,
H. Peter Anvin, Paolo Bonzini, Wanpeng Li, Vitaly Kuznetsov,
Arnd Bergmann, Jason Baron, Steven Rostedt, Ard Biesheuvel,
Frederic Weisbecker, Paul E. McKenney, Feng Tang, Andrew Morton,
Linux Memory Management List, Mike Rapoport (IBM),
Vlastimil Babka, David Hildenbrand, ndesaulniers, Michael Kelley,
Masami Hiramatsu (Google)
Hi Valentin,
kernel test robot noticed the following build errors:
[auto build test ERROR on tip/x86/core]
[also build test ERROR on linus/master v6.7-rc2 next-20231120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Valentin-Schneider/jump_label-module-Don-t-alloc-static_key_mod-for-__ro_after_init-keys/20231120-190044
base: tip/x86/core
patch link: https://lore.kernel.org/r/20231120105528.760306-2-vschneid%40redhat.com
patch subject: [PATCH 1/5] jump_label,module: Don't alloc static_key_mod for __ro_after_init keys
config: s390-allnoconfig (https://download.01.org/0day-ci/archive/20231121/202311210541.RAdnu4yL-lkp@intel.com/config)
compiler: s390-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/202311210541.RAdnu4yL-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311210541.RAdnu4yL-lkp@intel.com/
All errors (new ones prefixed by >>):
init/main.c: In function 'mark_readonly':
>> init/main.c:1406:17: error: implicit declaration of function 'jump_label_ro'; did you mean 'jump_label_lock'? [-Werror=implicit-function-declaration]
1406 | jump_label_ro();
| ^~~~~~~~~~~~~
| jump_label_lock
cc1: some warnings being treated as errors
vim +1406 init/main.c
1394
1395 #ifdef CONFIG_STRICT_KERNEL_RWX
1396 static void mark_readonly(void)
1397 {
1398 if (rodata_enabled) {
1399 /*
1400 * load_module() results in W+X mappings, which are cleaned
1401 * up with call_rcu(). Let's make sure that queued work is
1402 * flushed so that we don't hit false positives looking for
1403 * insecure pages which are W+X.
1404 */
1405 rcu_barrier();
> 1406 jump_label_ro();
1407 mark_rodata_ro();
1408 rodata_test();
1409 } else
1410 pr_info("Kernel memory protection disabled.\n");
1411 }
1412 #elif defined(CONFIG_ARCH_HAS_STRICT_KERNEL_RWX)
1413 static inline void mark_readonly(void)
1414 {
1415 pr_warn("Kernel memory protection not selected by kernel config.\n");
1416 }
1417 #else
1418 static inline void mark_readonly(void)
1419 {
1420 pr_warn("This architecture does not have kernel memory protection.\n");
1421 }
1422 #endif
1423
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH 1/5] jump_label,module: Don't alloc static_key_mod for __ro_after_init keys
[not found] <20231120105528.760306-2-vschneid@redhat.com>
2023-11-20 21:38 ` [PATCH 1/5] jump_label,module: Don't alloc static_key_mod for __ro_after_init keys kernel test robot
@ 2023-11-20 22:47 ` kernel test robot
1 sibling, 0 replies; 2+ messages in thread
From: kernel test robot @ 2023-11-20 22:47 UTC (permalink / raw)
To: Valentin Schneider, linux-kernel, kvm, linux-arch, x86
Cc: llvm, oe-kbuild-all, Peter Zijlstra, Thomas Gleixner,
Borislav Petkov, Josh Poimboeuf, Pawan Gupta, Ingo Molnar,
Dave Hansen, H. Peter Anvin, Paolo Bonzini, Wanpeng Li,
Vitaly Kuznetsov, Arnd Bergmann, Jason Baron, Steven Rostedt,
Ard Biesheuvel, Frederic Weisbecker, Paul E. McKenney, Feng Tang,
Andrew Morton, Linux Memory Management List, Mike Rapoport (IBM),
Vlastimil Babka, David Hildenbrand, ndesaulniers, Michael Kelley,
Masami Hiramatsu (Google)
Hi Valentin,
kernel test robot noticed the following build errors:
[auto build test ERROR on tip/x86/core]
[also build test ERROR on linus/master v6.7-rc2 next-20231120]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Valentin-Schneider/jump_label-module-Don-t-alloc-static_key_mod-for-__ro_after_init-keys/20231120-190044
base: tip/x86/core
patch link: https://lore.kernel.org/r/20231120105528.760306-2-vschneid%40redhat.com
patch subject: [PATCH 1/5] jump_label,module: Don't alloc static_key_mod for __ro_after_init keys
config: i386-allnoconfig (https://download.01.org/0day-ci/archive/20231121/202311210601.9dbatTYU-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231121/202311210601.9dbatTYU-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311210601.9dbatTYU-lkp@intel.com/
All errors (new ones prefixed by >>):
>> init/main.c:1406:3: error: call to undeclared function 'jump_label_ro'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
jump_label_ro();
^
init/main.c:1406:3: note: did you mean 'jump_label_lock'?
include/linux/jump_label.h:315:20: note: 'jump_label_lock' declared here
static inline void jump_label_lock(void) {}
^
1 error generated.
vim +/jump_label_ro +1406 init/main.c
1394
1395 #ifdef CONFIG_STRICT_KERNEL_RWX
1396 static void mark_readonly(void)
1397 {
1398 if (rodata_enabled) {
1399 /*
1400 * load_module() results in W+X mappings, which are cleaned
1401 * up with call_rcu(). Let's make sure that queued work is
1402 * flushed so that we don't hit false positives looking for
1403 * insecure pages which are W+X.
1404 */
1405 rcu_barrier();
> 1406 jump_label_ro();
1407 mark_rodata_ro();
1408 rodata_test();
1409 } else
1410 pr_info("Kernel memory protection disabled.\n");
1411 }
1412 #elif defined(CONFIG_ARCH_HAS_STRICT_KERNEL_RWX)
1413 static inline void mark_readonly(void)
1414 {
1415 pr_warn("Kernel memory protection not selected by kernel config.\n");
1416 }
1417 #else
1418 static inline void mark_readonly(void)
1419 {
1420 pr_warn("This architecture does not have kernel memory protection.\n");
1421 }
1422 #endif
1423
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
^ permalink raw reply [flat|nested] 2+ messages in thread