From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BAA4C197A0 for ; Mon, 20 Nov 2023 10:27:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19F236B0385; Mon, 20 Nov 2023 05:27:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 155356B042F; Mon, 20 Nov 2023 05:27:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E05476B0385; Mon, 20 Nov 2023 05:27:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CA0536B0385 for ; Mon, 20 Nov 2023 05:27:55 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9F4D912019E for ; Mon, 20 Nov 2023 10:27:55 +0000 (UTC) X-FDA: 81477956910.20.800E87D Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf26.hostedemail.com (Postfix) with ESMTP id 66C3B140011 for ; Mon, 20 Nov 2023 10:27:53 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=rQ0zh17j; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf26.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700476073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=Uo1wtnwccDNWWlbVDxfBne1aY1UjuhZc/WQo8sZV3KY=; b=xVxvWla2ZVHIN9ZdRYV9vAB2wtAClTmTNY/T3iz3y8KfmJEZCLEwC452QvI2rVmfSM+wjn rfAn2ohAmwWJs26Egn44XbMYbo+hPARwQAiFBEfTGVlH1NGxvUyhZWfI3P7mgW3oDqWjWQ eT/7e9ivBN3ZKHmbMQesonlIcAseYYU= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=rQ0zh17j; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf26.hostedemail.com: domain of sumanthk@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=sumanthk@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700476073; a=rsa-sha256; cv=none; b=S2yhZ0wHCBXqXAZXVHv2JdFVYpQv0ujvUwUvNt+SMzA8MMOAlqdHvSpm901NgH0RI5BdXq 2tfqxH3f8NNQ93NugNE9a2hWALAJ9FkTmSgIklrSA65n8UF9WU+6U6i4Si1x/HNrwc3FdP LokzkULUILyH3kzXWAIM7fEbpG/ZmvI= Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AKACF43009197; Mon, 20 Nov 2023 10:27:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=pp1; bh=Uo1wtnwccDNWWlbVDxfBne1aY1UjuhZc/WQo8sZV3KY=; b=rQ0zh17jeREnaIa5XxqPASiFNVN0N1mCBPy4sgj5FegwQGwsGzvoOIGNtCQAcBjdUUgA LY5upxgEWc/kauyW2RYPDvo1jQO9OSERJnXvnGIr8WaPLtUzm9OXUY6AJ+MdUxYhZgVY VJuJcXQ7k5vAhCWohUTiLtH0pGUhFvCM/tzTPyWtd2KZNDyz8k40Il8jmkLJwd8zBgGn si9fCo/DsROCVpVxl4/VG7t6is/H+PLPb9WbJh0bg6ZTFVwNui21208NotOR/Q166BOu 5ZnZAp7JL8A3u6pvPRmifJ0fVydbEwXhM700MlhJjSa7pHoI035VKBCkr91X5LQAE/6G zA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ug5g98abn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 10:27:49 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AKALb9T002614; Mon, 20 Nov 2023 10:27:49 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ug5g98ab6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 10:27:48 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AKAJJtm008904; Mon, 20 Nov 2023 10:27:47 GMT Received: from smtprelay01.fra02v.mail.ibm.com ([9.218.2.227]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uf7yy8nhq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 20 Nov 2023 10:27:47 +0000 Received: from smtpav03.fra02v.mail.ibm.com (smtpav03.fra02v.mail.ibm.com [10.20.54.102]) by smtprelay01.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AKARiRu46989688 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 20 Nov 2023 10:27:44 GMT Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 73CF120043; Mon, 20 Nov 2023 10:27:44 +0000 (GMT) Received: from smtpav03.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3947C2004B; Mon, 20 Nov 2023 10:27:44 +0000 (GMT) Received: from tuxmaker.boeblingen.de.ibm.com (unknown [9.152.85.9]) by smtpav03.fra02v.mail.ibm.com (Postfix) with ESMTP; Mon, 20 Nov 2023 10:27:44 +0000 (GMT) From: Sumanth Korikkar To: linux-mm , Andrew Morton , David Hildenbrand Cc: Oscar Salvador , Michal Hocko , "Aneesh Kumar K.V" , Anshuman Khandual , Gerald Schaefer , Alexander Gordeev , Heiko Carstens , Vasily Gorbik , linux-s390 , LKML , Subject: [PATCH v2 0/3] mm/memory_hotplug: fixes for memory hotplug altmap support Date: Mon, 20 Nov 2023 11:27:31 +0100 Message-Id: <20231120102734.2001576-1-sumanthk@linux.ibm.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: JsnuuIsft4kusm8B_UhVLlI3082NoJ1X X-Proofpoint-GUID: KaDoiLzFpFH_N9VrVmPT-0BP05SnvgC7 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-20_08,2023-11-20_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 adultscore=0 impostorscore=0 mlxlogscore=594 bulkscore=0 clxscore=1015 phishscore=0 priorityscore=1501 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311200070 X-Rspamd-Queue-Id: 66C3B140011 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: fy9bsjcznpxrxnjp38rcnp11wnkf7t3f X-HE-Tag: 1700476073-927659 X-HE-Meta: U2FsdGVkX18tRpVGGFqBxpEnC/59JX0+vmMTNBQHuGBFxOJ6k4nYARjNoQjECP4aOann0FkdBfFE6CPI0XEWleCObeJnVD9fYEsogx4zqK6uok8jtNvjVmY19Dq3JiCnpBJjItjsNXcUwY14VbC0513CkBHSBtxbGKbZbhD/TUv5KvC61qRla3XvpacaICFuaOgBfqRWCF7G6GMkoRZvY9M8aJRgoLpEjLqtUKR/IWlIPAjhb88TFjS41BUSiHjzBN5bMy1/ELaX4pupbbbGmpmWowTJ3D3w73u8E5snaWFlYT0mIL1/GUM2kysgPY/OnU1HQrrfVenuv3hVg2JYI1Wuv+8yQM0bZt1Yu7kKRBKxFeNlt+m0H35huOwWDuCuqP0dP3GIs4GKR0zphjMjSDRAxEj07xR6BeNigYGrAyLmwHIUxNrINNZX7JRmvNA8TF+WIsvdomZtqnf3LLAfUmmGtuSKFTZWSHJSCeU0BPD67aYqAJGrpvqNc8tizpVWL+I76V7bdgyBmLS7kWdIjE9GKsWr4q9qqV7VUA9uC3Gyd4xYI3R/oA76ijx0x8PFFFQhToR1S5h1gkeHmWxVMomO2/G9t3fn1Lvp4fx1dWkv5LdGje4CY9Iqcb70mD/UmZ0prBCnQkLBtBHPdNH2841xAMxth4fEH/4QwGhlNzbl+y/FF5qnN2feQsvs1opYiCt4LQ3C/TwBehOiNyw2TBS72IkkNYJtPJPX3fTsKE1esrlXGKFW+l4rAFxQaWP8tUGO1Om03TL6kh/J6aZHzj7Fh+chAjRyOlFACnRNEnwRysx20aRNmKBM9CSUcEi8DdlupCMtpc7e9MZajBI5t4hMREuV6SM329M4OaJotpZWa/5kQkcq2kBWgxVS0XzuvTq6IMXVMTbN5UyHsnKuMfWVAE8cj/9xvq8r0PSJFq119sVT5w594RSzggzS8Y1SfQPd58AlkoYPNuF5BN2 +7ih2398 UZn8Az9pbJM3F4BDO99zgxSpcz5sUuB7qlHvlMFfO5mqWc0+LUw+1Y00xE0qP1VyASXOJ8ncDENgwI7fiD4uOBBeGBMb39WIbNrwLZSuXnCl1CDp8O/HE6Dlfj/gV+s4RPG29S1OcCSPWlRY4buB0O0SDfLy8oDxn06A1/G0u0zu27qRRHS7DjF/JDKIGnk4fw6A+HQS40viQ3LYRpAS0E4KAgQxy2Ghz8Oun X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Patch 1 adds the missing lock in memory hotplug operations, ensuring that the mem_hotplug_lock is held during critical operations like mhp_init_memmap_on_memory() and mhp_deinit_memmap_on_memory() Patch 2 deals with error handling in add_memory_resource() and considers the possibility of altmap support. This ensures proper deallocation of struct pages, aligning with the allocation strategy. Patch 3 relocates the vmem_altmap code to sparse-vmemmap.c, enabling the utilization of vmem_altmap_free() and vmem_altmap_offset() without the dependency on CONFIG_ZONE_DEVICE. v2: * cc: stable@vger.kernel.org * made vmem_altmap_offset()/vmem_altmap_free() inline. * added Acked-by for patch 1 and patch 2. v1: Changes since patch series "implement "memmap on memory" feature on s390: Patch 1 (Feedback from David): * Fixed subject for memory hotplug lock. * Added locking comments before memory_block_online()/memory_block_offline(). Patch 2 (Feedback from David): * Fixed Fixes-by commit. Patch 3 (lkp report): * when CONFIG_SPARSEMEM_VMEMMAP is disabled, resolve undefined reference to `vmem_altmap_offset' error. * Request for Reviewed-by once again due to the change in patch3. Thank you Sumanth Korikkar (3): mm/memory_hotplug: add missing mem_hotplug_lock mm/memory_hotplug: fix error handling in add_memory_resource() mm: use vmem_altmap code without CONFIG_ZONE_DEVICE drivers/base/memory.c | 18 +++++++++++++++--- include/linux/memremap.h | 12 ------------ include/linux/mm.h | 26 ++++++++++++++++++++++++++ mm/memory_hotplug.c | 15 +++++++-------- mm/memremap.c | 14 +------------- 5 files changed, 49 insertions(+), 36 deletions(-) -- 2.41.0