From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 633FEC54E76 for ; Mon, 20 Nov 2023 01:08:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 948846B03D9; Sun, 19 Nov 2023 20:08:04 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F9736B03E0; Sun, 19 Nov 2023 20:08:04 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BFC66B03E8; Sun, 19 Nov 2023 20:08:04 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6DF596B03D9 for ; Sun, 19 Nov 2023 20:08:04 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 42D7E1CAE9A for ; Mon, 20 Nov 2023 01:08:04 +0000 (UTC) X-FDA: 81476546088.30.EB00631 Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.88]) by imf20.hostedemail.com (Postfix) with ESMTP id A728D1C000F for ; Mon, 20 Nov 2023 01:08:01 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XRoUfQjA; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700442482; a=rsa-sha256; cv=none; b=NhPXKsW51BbBQI3jNIBW8ijUG6MYnW0Aa+xfePulkAT1XVjhtc8B5gu1CZX0XTblJAxnrW IesjgGlVM3gbQw2yzHbiGFgwxOTXYnyIqAlMVwzmZcr6FliR8E+H7LfgA32APdnBXdAXNq Q19PYw3Va1Pa9Dolk6DcZpM1qiZB8vE= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=XRoUfQjA; dmarc=pass (policy=none) header.from=intel.com; spf=pass (imf20.hostedemail.com: domain of lkp@intel.com designates 192.55.52.88 as permitted sender) smtp.mailfrom=lkp@intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700442482; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p1G9Dv8bznhy57kJY/suM5OVwcqZD4nt1Si2VWDsa5M=; b=Y2UFZQScoMW9EswVv6JCp/wt/5vO9HtSIoFwQ4JHf1EeMUC+6t3B1E/409MuLW3DEbgOqi 3aKEPqWw6nREo6d6iyWExKZxR1WHZqbU1b4Yam/ksUy1LVvqczeiltGFauY5r0yyLWCW/m JrV3onFh7RTAmjuyd1255083ruHjo9Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700442481; x=1731978481; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Afwg7Fdj8Ft7cQDd8qfi6qWAHO+5mdbO4VPlEFQ6/MY=; b=XRoUfQjAhG1iSAwJDQvhYy9A6xK3MeTSQwSjHT3qG2fGiqx6zRXGAzcO 5TPAsNSlsgl+8SIuTA3E3vMyHZM4v8THvNmuYpYJTU/S81GlLPJnsxwUj gJ7j5cHIblNaMAHRVqtATG1VVErDy85WfyOc0k+GNckg8FumVfUnYS7AW 6q9x31KBJXJ6x9V+oNJT0ZS55p5FDa/uw9T8JqQloqsIr5XrQpVR+gGbp vXlDVIB8in8w0zeDpPZ1j5owUtA7GNU4jI8sbJWdrF+NF8inTmwd8x9az Mep4I2IRNtPVdnwmZLp5Y2aMhUkK0Dva3LPH5K2U9Ssnr3WI/IN9jA2DC A==; X-IronPort-AV: E=McAfee;i="6600,9927,10899"; a="422627227" X-IronPort-AV: E=Sophos;i="6.04,212,1695711600"; d="scan'208";a="422627227" Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Nov 2023 17:07:59 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10899"; a="939646615" X-IronPort-AV: E=Sophos;i="6.04,212,1695711600"; d="scan'208";a="939646615" Received: from lkp-server02.sh.intel.com (HELO b8de5498638e) ([10.239.97.151]) by orsmga005.jf.intel.com with ESMTP; 19 Nov 2023 17:07:55 -0800 Received: from kbuild by b8de5498638e with local (Exim 4.96) (envelope-from ) id 1r4slV-0005mJ-1C; Mon, 20 Nov 2023 01:07:53 +0000 Date: Mon, 20 Nov 2023 09:07:27 +0800 From: kernel test robot To: Kairui Song , linux-mm@kvack.org Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Andrew Morton , Linux Memory Management List , "Huang, Ying" , David Hildenbrand , Hugh Dickins , Johannes Weiner , Matthew Wilcox , Michal Hocko , linux-kernel@vger.kernel.org, Kairui Song Subject: Re: [PATCH 18/24] mm/swap: introduce a helper non fault swapin Message-ID: <202311200850.FrQj7bMD-lkp@intel.com> References: <20231119194740.94101-19-ryncsn@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231119194740.94101-19-ryncsn@gmail.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: A728D1C000F X-Stat-Signature: ksqe6m3sp66d915f33mpohfgq35zyrz7 X-HE-Tag: 1700442481-631443 X-HE-Meta: U2FsdGVkX19duyLQjqzaQxAVXTo2Tzc1ZBSSeSN+ahfSJJkBRDMoRDZfBZfoA5Ae0m7SYyzHVoX2OfO3xUiTTpz5WvhJNQKyq+EJvhyF79JpTCWMrS6FYlSAF3Mm7raNFO8qGUkmYSrMSSA55vg+4p+PUBsjV6/fCHWs5Ft4gOpZuPQQdLM+9Ab1Qzo7xmcsGN7DsdKKJR4jx7mv+omqwyw9Lar64syBaeTbwxW7wPBJnT+H+lMpAEPUA5C9JAD+HzVNDKpqv6uAmTqcOhJ5MOwJJo7fGX7cwpCEA+FLGekiF7nOD7rm8ZUhL22pW05wCRNJ8PjRqWHq/IzHlgr4W+PByibj+i1L7hpWz9q9j3ZvGZlmT7zjor2H/5F3W7kl3iwcUsPTf+055foKGYfuM6PWOlVsy/MlAeVnx00n5xPrRoFBzUTP4EwlmyG9jqo/SiL89QOD2LL3UIENE35DK2hhSc43bA1sIcyBLTDk58u76BtVBFnbkdFgWYSKea5G+p21zxIynHKNnw7epIFH29kiDwd/B63Tp8QoiPAT6sESkFDNhnDPQbozWPDPaMs9t+cs4x1oPhl/6IkJ89nFxnodowAJLd4NUAn5jqHgnfPgvhzJMFZyLB6EgnwCQL6FCgb94TlCBjxyFhbg7N0reqNmpswChsfSZphqxYsYc2e89AzXRtVWDPlAL4XsdnWxwV2yIVoqoAYcD/m+mJk2tStYlbVnVrtD/IM+ZXtbJ4WxDx7E3x2Lczq90nv9uTCNbXKcg9TJCr/BEgEdU4KvErk+hAzyWYOckfMPru3tGsGeG2d+3KRwxWFjLCikHE76X11LWCxOI3+aHNhFE979pVFm0U3OvqHFVI3xBt4E6fStEF/z2LqCzVRdmJGXv7UYKv18z9G7c+uXcD/kGakalMQXo+rcY9D4eyk3VhWFTzlUaOF6BNkxZOScqU8LkEbvEf3HFkdFt78Z/AZL2LF yuvH9s3u wYIdP7tiW1SJXE7RcYkB8KcJOpT21n9ZPtGC2Lj8kadloL5q92vI3uDUw3b0cZHrvS9kYZMh2m7vHTnur/vYn9YsSkdpRVBRBOwvNYVY53HaPs54IVqvE24VL19SrpJPx8ZhSJuOMXZ5xy2kABbHt7QDeYl/ND6+smWF8Bwoa4O/BgOIQ/z5o+AqQ1Qrw6fSAGnHWnCcwLZ050iFsJkXt76OV93XALC1yG12MQOuknoftjOGSSuCFfPhkhOYpQlMYym53tDmrEAme9q2m3YoWKXXQ0TsrNCZQ8J+5TFOWko6UAg0eeZAvXuJMYTO9e6XH5oYcZJ3NvFaqeNXR0H9cNhrdgGyPhPuFz8CBM+1mOPCZbYDVE7FeLEqIAAKJ2rWVziLyO6UMvcfP1BE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Kairui, kernel test robot noticed the following build errors: [auto build test ERROR on akpm-mm/mm-everything] [also build test ERROR on linus/master v6.7-rc2 next-20231117] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Kairui-Song/mm-swap-fix-a-potential-undefined-behavior-issue/20231120-035926 base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything patch link: https://lore.kernel.org/r/20231119194740.94101-19-ryncsn%40gmail.com patch subject: [PATCH 18/24] mm/swap: introduce a helper non fault swapin config: i386-buildonly-randconfig-002-20231120 (https://download.01.org/0day-ci/archive/20231120/202311200850.FrQj7bMD-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231120/202311200850.FrQj7bMD-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311200850.FrQj7bMD-lkp@intel.com/ All errors (new ones prefixed by >>): In file included from mm/shmem.c:43: mm/swap.h:105:31: warning: declaration of 'enum swap_cache_result' will not be visible outside of this function [-Wvisibility] struct vm_fault *vmf, enum swap_cache_result *result) ^ mm/swap.h:112:8: warning: declaration of 'enum swap_cache_result' will not be visible outside of this function [-Wvisibility] enum swap_cache_result *result) ^ >> mm/shmem.c:1841:25: error: variable has incomplete type 'enum swap_cache_result' enum swap_cache_result result; ^ mm/shmem.c:1841:7: note: forward declaration of 'enum swap_cache_result' enum swap_cache_result result; ^ >> mm/shmem.c:1870:31: error: use of undeclared identifier 'SWAP_CACHE_HIT' if (fault_type && result != SWAP_CACHE_HIT) { ^ >> mm/shmem.c:1879:17: error: use of undeclared identifier 'SWAP_CACHE_BYPASS' if ((result != SWAP_CACHE_BYPASS && !folio_test_swapcache(folio)) || ^ 2 warnings and 3 errors generated. vim +1841 mm/shmem.c 1827 1828 /* 1829 * Swap in the folio pointed to by *foliop. 1830 * Caller has to make sure that *foliop contains a valid swapped folio. 1831 * Returns 0 and the folio in foliop if success. On failure, returns the 1832 * error code and NULL in *foliop. 1833 */ 1834 static int shmem_swapin_folio(struct inode *inode, pgoff_t index, 1835 struct folio **foliop, enum sgp_type sgp, 1836 gfp_t gfp, struct mm_struct *fault_mm, 1837 vm_fault_t *fault_type) 1838 { 1839 struct address_space *mapping = inode->i_mapping; 1840 struct shmem_inode_info *info = SHMEM_I(inode); > 1841 enum swap_cache_result result; 1842 struct folio *folio = NULL; 1843 struct mempolicy *mpol; 1844 struct page *page; 1845 swp_entry_t swap; 1846 pgoff_t ilx; 1847 int error; 1848 1849 VM_BUG_ON(!*foliop || !xa_is_value(*foliop)); 1850 swap = radix_to_swp_entry(*foliop); 1851 *foliop = NULL; 1852 1853 if (is_poisoned_swp_entry(swap)) 1854 return -EIO; 1855 1856 mpol = shmem_get_pgoff_policy(info, index, 0, &ilx); 1857 page = swapin_page_non_fault(swap, gfp, mpol, ilx, fault_mm, &result); 1858 mpol_cond_put(mpol); 1859 1860 if (PTR_ERR(page) == -EBUSY) { 1861 if (!shmem_confirm_swap(mapping, index, swap)) 1862 return -EEXIST; 1863 else 1864 return -EINVAL; 1865 } else if (!page) { 1866 error = -ENOMEM; 1867 goto failed; 1868 } else { 1869 folio = page_folio(page); > 1870 if (fault_type && result != SWAP_CACHE_HIT) { 1871 *fault_type |= VM_FAULT_MAJOR; 1872 count_vm_event(PGMAJFAULT); 1873 count_memcg_event_mm(fault_mm, PGMAJFAULT); 1874 } 1875 } 1876 1877 /* We have to do this with folio locked to prevent races */ 1878 folio_lock(folio); > 1879 if ((result != SWAP_CACHE_BYPASS && !folio_test_swapcache(folio)) || 1880 folio->swap.val != swap.val || 1881 !shmem_confirm_swap(mapping, index, swap)) { 1882 error = -EEXIST; 1883 goto unlock; 1884 } 1885 if (!folio_test_uptodate(folio)) { 1886 error = -EIO; 1887 goto failed; 1888 } 1889 folio_wait_writeback(folio); 1890 1891 /* 1892 * Some architectures may have to restore extra metadata to the 1893 * folio after reading from swap. 1894 */ 1895 arch_swap_restore(swap, folio); 1896 1897 if (shmem_should_replace_folio(folio, gfp)) { 1898 error = shmem_replace_folio(&folio, gfp, info, index); 1899 if (error) 1900 goto failed; 1901 } 1902 1903 error = shmem_add_to_page_cache(folio, mapping, index, 1904 swp_to_radix_entry(swap), gfp); 1905 if (error) 1906 goto failed; 1907 1908 shmem_recalc_inode(inode, 0, -1); 1909 1910 if (sgp == SGP_WRITE) 1911 folio_mark_accessed(folio); 1912 1913 delete_from_swap_cache(folio); 1914 folio_mark_dirty(folio); 1915 swap_free(swap); 1916 1917 *foliop = folio; 1918 return 0; 1919 failed: 1920 if (!shmem_confirm_swap(mapping, index, swap)) 1921 error = -EEXIST; 1922 if (error == -EIO) 1923 shmem_set_folio_swapin_error(inode, index, folio, swap); 1924 unlock: 1925 if (folio) { 1926 folio_unlock(folio); 1927 folio_put(folio); 1928 } 1929 1930 return error; 1931 } 1932 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki