From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7FEAC197A0 for ; Mon, 20 Nov 2023 14:37:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 656706B01A1; Mon, 20 Nov 2023 09:37:35 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 606566B01A5; Mon, 20 Nov 2023 09:37:35 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CDB66B01F4; Mon, 20 Nov 2023 09:37:35 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3AB856B01A1 for ; Mon, 20 Nov 2023 09:37:35 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 039331CB2F4 for ; Mon, 20 Nov 2023 14:37:34 +0000 (UTC) X-FDA: 81478586070.30.64A7CC5 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf26.hostedemail.com (Postfix) with ESMTP id D8B76140027 for ; Mon, 20 Nov 2023 14:37:32 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Itx5yq5l; spf=pass (imf26.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700491053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9gT2Yjc+rYxcPkn7g9Th8UEqg0lYsK1+p53eAO2drBk=; b=gl1ETvV67Ubjk96Fa5CgOFJQVqVxKDWEzdxnJBsRaTTgnwiZBdbll+EEE8Fbz6EudN7FoL Gh8LMatWAShJZyY1EaJWD2glTjVZhG9nxsFVHpoNKQpVwk/plOdzTtzUCrB3IrHwNQwL2V f1I5kzg0YtKRo/HarI3pfeWCL8h8qng= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700491053; a=rsa-sha256; cv=none; b=3Y5cgKd690h6908Ew+Wf7hGCDp0AcSyKCzsclX9ocY0bp7imHIIvGVlMFt1dExCE6uMQjD M+Sc2AMYleddmUtqTxr5tKrJvIOBliEBk49Ol2OqF+ypM2s2LE/Es0FpxandO+sGUtVOWI VSkbqgLVBQSI5FRC+0eMUybcfzbOT5w= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Itx5yq5l; spf=pass (imf26.hostedemail.com: domain of brauner@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=brauner@kernel.org; dmarc=pass (policy=none) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 3882AB816F6; Mon, 20 Nov 2023 14:37:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EC54C433C9; Mon, 20 Nov 2023 14:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700491050; bh=DLE1c+o1kmmWKQU5FsHxdwyQev10aAv8a+4Bsb27Pn8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Itx5yq5l6xnqscNORqVb5VmwZhXLupoQFckVYMxzef9qAm8tfCAHsX660QBqi66oI ZR1IhfrD7+0KX8AjzjDcFYMbcBE7YbqJEOmoPdZka24/mKfkOd05TGpCSj6oL7vn2b cWJX/pXVdrD4JB3d/f74eoXdBYkoNWv6hJwuPNvwkN0jJM4kamJ3it/FD1ir06jJ7r awGYEb2grK9P4j4ziVsxXqd3RbYn3nrbu5qWOIIVtV0cxvN3Xs3mkqEwN1T2W4S1TH i1Eb+6Md590FynuzxhRQmZDiI8AKtrvlfaEbUQZAT8ladOkALDKE/YOlyh1ov4lOHs imfgJpGfMF3bA== From: Christian Brauner To: Chuck Lever Cc: Christian Brauner , Tavian Barnes , Chuck Lever , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, hughd@google.com, viro@zeniv.linux.org.uk, Jeff Layton Subject: Re: [PATCH v4] libfs: getdents() should return 0 after reaching EOD Date: Mon, 20 Nov 2023 15:37:14 +0100 Message-ID: <20231120-lageplan-grinsen-25b44b4fac10@brauner> X-Mailer: git-send-email 2.42.0 In-Reply-To: <170043792492.4628.15646203084646716134.stgit@bazille.1015granger.net> References: <170043792492.4628.15646203084646716134.stgit@bazille.1015granger.net> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1347; i=brauner@kernel.org; h=from:subject:message-id; bh=DLE1c+o1kmmWKQU5FsHxdwyQev10aAv8a+4Bsb27Pn8=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaRG50sW8Bcu4VibquLoq7V+jsex9S4hqW+11q5eU7a58 EPZsbbmjlIWBjEuBlkxRRaHdpNwueU8FZuNMjVg5rAygQxh4OIUgIlsOs/I8Gy3TlZd4s3cRymX K/c43BCLX8/ouvLTXm+LWfXbeafz/2P4KyWxwPr28oitm9eaBLll3KnaJBh46ZR52oIlCvN9ZT7 WcwIA X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Stat-Signature: 6n18gxnxpxjdxrkhfb6aia5khcuo7jix X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: D8B76140027 X-Rspam-User: X-HE-Tag: 1700491052-534865 X-HE-Meta: U2FsdGVkX1/WuhRLRxkxRSr8FHX6lthW6p+LDxAVGXIe7MdTVt+QFwY++D5TwfiYf/IoTMlAB9E5SkB1gvb6dbenLSoR80IDMFPG+GXPFWJ8pcmao2rq32ViTBPtZo71vOsM2J5D9U9KnhejulLqhgw/DvERFZOQK9E7h8XaByksL8Ml/xgBduDioAjkyVnLIVdmWwutNz+EsKpX6dKhbHWJrkLuywTfOwMloP3w3lBJOxz6COVWbX4DBNfsQPAw7eoUjsol1w1PzCRS7K6iSrEbUJvf+Vivz/s/mz6jrncIf61Lh+JebrJ3OJeHCPZxEl7L6VmRxSA39JLzVJMM++pqubtWfxIEXVgQvbida3IQ7wxPVxMzqw0uD+nTi3NC5yahH9JZDR0VSIOh1MyJEFxFPHNicLIGSpK020H7wY0/NvD6FQjTe7RxWwTdFwIikr5+N0Dacz9wcotAgoLcNjGe8wfQ++cPqsKZ1Gzt+hdwFzVayLX1j47CEeK6CvcfaNB1cie3jRXYrL1p8lmq45wk/Et07CgTkL+RmKjI+cPjhAEbNi4/NZiAs4HpGfM++zGdi2WP8P9QD3IQi7C5IRXUJzOx90P93paaxAk4D/LCEqK1UGcolQye5xIz6vHcf2xKx0HQAwVIUUrgC9BMme1CEASpelUGE913w5DUGj0yTmRKhG5dIenlMXAkxZ8Hmhx6AUscyR0VVvAcRXItfKlyA3LZi02jMdgKErCLt9U7WWP0HMV+U1a8CbdRYfgaDuwglN+7K5HSgUBxnCnk3Ukdca/Q7yqmj8gAveDQzd9lYAv13Lgrb0i8XBKOx/DmNOiOf1CYmMhgAMSbBZH+zFUXAC7d8RylCzneEMrbuqdh2Pio5miI8Ph9aBbpLCUVtOWO6mlKXlhCFM/ANIZWqzfMwD63ZvWfj8AKxgdSG0a9+D8DITtPUoCi5I+S/1kokDjrOk0B2Zn05b6ZWSk httQw0dw MigjL0FLwIfgSYcl68kxIOfTKk5CrqPpm7+TKHbCxuVsg9I+b0/aA/rgeU3gCipM081MjV8CkhTyxEJM5fHZHgf+QOsW6fOGLhiruaXYi2ibYoprdTSI1pfWH3u8hIELwdyukxc6EyUYQ45enjc9Qxj6nCHVab35ZOnHoCNfJT51S1WwV4Iv1mLnUWpKVVqml+TcwpBd/rmxdJTIbY31cfs0nT/WaOwBnc+wLhpSG9KP/Wl8x8K5GbTxJWw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 19 Nov 2023 18:56:17 -0500, Chuck Lever wrote: > The new directory offset helpers don't conform with the convention > of getdents() returning no more entries once a directory file > descriptor has reached the current end-of-directory. > > To address this, copy the logic from dcache_readdir() to mark the > open directory file descriptor once EOD has been reached. Seeking > resets the mark. > > [...] Should fix the regression report I also received earlier today. Thanks for the reviews with LPC and MS I couldn't really do any meaningful review. --- Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] libfs: getdents() should return 0 after reaching EOD https://git.kernel.org/vfs/vfs/c/796432efab1e