From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 589E0C54FB9 for ; Sun, 19 Nov 2023 21:14:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DCD406B028D; Sun, 19 Nov 2023 16:14:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D7DB16B030C; Sun, 19 Nov 2023 16:14:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C6CB36B03BE; Sun, 19 Nov 2023 16:14:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id B98A76B028D for ; Sun, 19 Nov 2023 16:14:32 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 8D0DEC086C for ; Sun, 19 Nov 2023 21:14:32 +0000 (UTC) X-FDA: 81475957584.11.739F4FB Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf04.hostedemail.com (Postfix) with ESMTP id A90A64000C for ; Sun, 19 Nov 2023 21:14:30 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=GhHe25Av; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf04.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700428471; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pT+V7kAPtRPjewuTj5A9OhUWljqsGYnraOTy8eAk7ZI=; b=XbE4ic65qHDeZPXnWH5nup7b0RGRglr4l2GotJtT2XaLWQlh0LgmpQMEq4IsiBwN5DEMjJ 0+Sfas/M7MHMZO/FXzvzAAN22yGhWndQqHDFsRiRqr+WaVIYXr/d4hOpq3LK26ZuvXYw0l z8CZxSD2Shk0QmpYgtczJgIQ/1cDLpg= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=GhHe25Av; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf04.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700428471; a=rsa-sha256; cv=none; b=N51Pg5+z2MLM0KhRS0stl1MiBjSykI7kk6a5jhDfUVIGa29q6s5QrNu4dwdCl2Gek6lpcH Yb86+wxs9IVCCsjU/u4R0CnM9Pkp9Vp521pMGSgi/8okKoMjQSG90aYgb1ORxIfmPMpwXr ki/d8bKx0SE7wbjSf1nFbYEreMvAQMM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=pT+V7kAPtRPjewuTj5A9OhUWljqsGYnraOTy8eAk7ZI=; b=GhHe25AvVS7MbpW8FHxBw8zkm9 mlwEWxkRiq1gmwZEbSNIiK90OP2A+LasWTO7UdkUo8gBsJHG41xDDPmura9od7ews1Gjk3e6pzdIQ xxhD40RDOPhI565+E4BIG9F57Z067/uJsoiMC+w4DJ7MIpIOQzbMRH1XJVNW0ezXn0iZ5SNlFv7I1 XcmRvEpOyEgplZ2iIPRdq5Fnodh0iBD/DnD6GSWK2qVuq/GUVLy6+TaJQc6Yqm2wHLAlpu/mw7dJI TmlVGQbVDXcuNhXxDGoJAyj+SC4ehMya594QVe+j8Wpeyle3XdMDZf6KtP39qR7qwZTcsQELML2AD hyIQ93rw==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1r4p7P-000PMc-2q; Sun, 19 Nov 2023 21:14:15 +0000 Date: Sun, 19 Nov 2023 21:14:15 +0000 From: Al Viro To: Chuck Lever III Cc: Chuck Lever , Andrew Morton , Christian Brauner , Hugh Dickins , Jeff Layton , Tavian Barnes , linux-fsdevel , "linux-mm@kvack.org" Subject: Re: [PATCH v3] libfs: getdents() should return 0 after reaching EOD Message-ID: <20231119211415.GB38156@ZenIV> References: <170033563101.235981.14540963282243913866.stgit@bazille.1015granger.net> <20231118233626.GH1957730@ZenIV> <8F8B8E49-7AC9-4ECE-9CAE-8512D9C1DACB@oracle.com> <46914DA1-E529-43FD-97B6-F995AD933156@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46914DA1-E529-43FD-97B6-F995AD933156@oracle.com> X-Rspamd-Queue-Id: A90A64000C X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: y4exnjg6r7whmfoy8o1jkwy4dgpbd3ax X-HE-Tag: 1700428470-633030 X-HE-Meta: U2FsdGVkX19g/4RFdAsMNUXgDY9RYQF9pexIjlPd54P8AYGJ3UM8w9yfQ92vP9xA4p+Y8Z0JjN3FhAVcKnhnbjNiPmPjLvHvMw5Pk5K1Y7PeBTIDnqMGKYEZirH/GDSV/qFiWXcqzr5nAT6XYs2HdizaiGbRkp5NiawziFEXOEa+WHcE9RQhBaktEI0WdN6kCiGZuEbvhwSbpuF7nqRtjbqHQNvqWDkF6AKEGO4DQorHjfKYkSpRAVf769s6qpqH9pHyvfkd8LwMm5IUV6RGSYdGugYEvVs7mYWlBR9AevkfeWnALtU5V5Z2sI4Z3g+D51On9KagSRXI9LOkXk094lFYkzvV+ldyHvl1ktgi50kuxHXeUc42bqLuhpKNyb2jhxxLjACmujDBhRiEc52aVpu3LnrL92KELpkT8C3lm8aZUpiIW5Zl3rN/xSCjJPisvCJfinl8xa2nP9i67L4tY5On3foalTeiroLj0eX6bMm2aXAmiSFvVx2p77vsseZZFhwYJtDC5lsUNh6qUVVXSt5/nAKRwB44YIEXZutaKc8gxYTYeK8D7VOTYISFsoSyVc49re59YZjD6qlwTDbPmhkbKNzA2nITscrAz4wAKw/MhhNPGBsDZh55DyIKBQrQb6wwYaIluxIvoX/huPnG7TvjBqA5QM7kWREcN2GCCtLktM8ygXaFJguNhwcQIzlkfiINMswtawbEGofwJPlxjczA8af75GXdurpLJOgDyytRHM8x0y6GwXSU9Hs+L1wPyHe03+AB6D+qQTjWm6WZvA2WMXsjnkv2vDt5FOsEPb1xM9Zs9pXzZFhF4zXKY7o7YzoHwTNeRLxi4HthO/KWkFv4+1qLR2Qcu3VXRtnFWEftD0Tvhd+oVQUfI7KJbmHlcGWCikt79ejmnhc0xLiVSfANhNtncMmoTN4+2dXfQ2YHvTjgLOG+ZdpLcP8AHo6WLKDLZhWUoZIUlhLgIkH DEWmmdMI bCTzDzbtAEN3eXk9P5mYvsslPwQChE4f3ONDSSdH/7/zjIunIGsIYl2B/e9waXs+MmKmvLY9aCCwXqbi4N2tCiw7QKUlfAdpjL0jqj5P6smtafCJ5bLVLWT5QANlv/kvUYmPznr7jtQCnn3+N8EfjnUmu6DegJeh4NdtMDZW3xlp1UPGXLrUPbSaDG6uPeAJ9yLBCs6DxQ7vRwK+wLR4gNVzTqRZZEgikyWszSvBHytSZiwyu/wT6Y+r9D7SjUc3eYOhW/9+nY9p5P6vut4UqR336ySUVfGaVK/0fu4kahV5XS7ECl6/4THHSsijiTs3ikb8TITcUhvwC5d34XfCf5liMCmffsJtT+UqJInRyVHctULWBFOCa6wYvOYeEfQ2oCzrsz0F36RA9nRk3yG3tk468+eAUcn6rP+rA X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Nov 19, 2023 at 08:22:30PM +0000, Chuck Lever III wrote: > lockdep assertion failure > > Call Trace: > > ? show_regs+0x5d/0x64 > ? offset_dir_llseek+0x39/0xa3 > ? __warn+0xab/0x158 > ? report_bug+0xd0/0x144 > ? offset_dir_llseek+0x39/0xa3 > ? handle_bug+0x45/0x74 > ? exc_invalid_op+0x18/0x68 > ? asm_exc_invalid_op+0x1b/0x20 > ? offset_dir_llseek+0x39/0xa3 > ? __pfx_nfs3svc_encode_entryplus3+0x10/0x10 [nfsd] > vfs_llseek+0x1f/0x31 > nfsd_readdir+0x64/0xb7 [nfsd] Lovely... Said that, file here is thread-local, so all accesses to it are serialized. The same file has ->iterate_shared() called without ->f_pos_lock a well... So that's whatever serialization between ->iterate_shared and ->llseek, really; for normally opened files that's going to be on fdget_pos() in relevant syscalls, for something private it's up to whatever's opened them.