From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D06C54E76 for ; Sun, 19 Nov 2023 16:59:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1ED966B037A; Sun, 19 Nov 2023 11:59:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 19DDD6B037D; Sun, 19 Nov 2023 11:59:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 066D76B0380; Sun, 19 Nov 2023 11:59:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id E9EE86B037A for ; Sun, 19 Nov 2023 11:59:00 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C9419140248 for ; Sun, 19 Nov 2023 16:59:00 +0000 (UTC) X-FDA: 81475313640.09.F548D64 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf30.hostedemail.com (Postfix) with ESMTP id 50F8B80009 for ; Sun, 19 Nov 2023 16:58:59 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700413139; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rXIx+fxQgDvHX15G0bvSf9Cxzf8KW0oOjXsIUL4Yp6k=; b=5JpX1vT0hgXH5oPfdpKMLvk8xiMU/fWp6U7uwH22poQFJmmNw57OBNp9//mtdMIFrON6m4 j73Xh+CKb2cFZSKWlqvrWsreSZIlkOSKVNfH3u0HCkRJXB19p8qV84OflPeTnM08TaId5N +kR7TS8S0W0kw4mp3ydxmRHeUTv+uKg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700413139; a=rsa-sha256; cv=none; b=YTjMtjmErnmrfRkTu4l5g2cQ85JYcLw8K32GrsnTAl53y9TYvc6a0xiWX42G2KO84Laam3 zsGufpmq+/aHCQGwzkcelETm9sgafZEZrdprlWUFuivfReCrH7LTyJ0+YBRZYBNjhPxh4d TcHdT4mTxrpLTe1avIOR+Rc9dv2l3Dg= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; spf=pass (imf30.hostedemail.com: domain of alexandru.elisei@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=alexandru.elisei@arm.com; dmarc=pass (policy=none) header.from=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D2E19FEC; Sun, 19 Nov 2023 08:59:44 -0800 (PST) Received: from e121798.cable.virginm.net (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9966B3F6C4; Sun, 19 Nov 2023 08:58:53 -0800 (PST) From: Alexandru Elisei To: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com Cc: pcc@google.com, steven.price@arm.com, anshuman.khandual@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org Subject: [PATCH RFC v2 15/27] arm64: mte: Check that tag storage blocks are in the same zone Date: Sun, 19 Nov 2023 16:57:09 +0000 Message-Id: <20231119165721.9849-16-alexandru.elisei@arm.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231119165721.9849-1-alexandru.elisei@arm.com> References: <20231119165721.9849-1-alexandru.elisei@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 50F8B80009 X-Rspam-User: X-Stat-Signature: dfr9ct4yt5ednpkk7eqcjd78gx316noq X-Rspamd-Server: rspam03 X-HE-Tag: 1700413139-558787 X-HE-Meta: U2FsdGVkX19JyN0TQRvfcyxm/yij39teUZe3QsaWzT/2jeFSIMVfw2qa5/5ndiz0Ddsi+B69ydJ/CeTIIwkhY84YfdoYbMwVCCa6yKQQv4Ori3vjS28feiGJfeQYf5za/3pXIPnw+s1LeGQszH2Av6+VamYXgaN8LWASaWTyyswwbqB8dspXSxXuImyqRrJPINM9AG1bTytR7zMKX6A7YdaUs1sxUtlkMgLBrFPbs33vwTfT3HSmcAlWpogM6CEev60bdcMiJFRAaj2k7dW/M6GNZtQiqwMJw46T+LiOHxxPi8J7+ZCLNqM0TpUpeq4jN9KHu9yq5kN/zK/+2OprMATrfYxZGmeEAmLcpY/o1AJoiUgTjMHWTDDvLcgD1QyvAJPVVvRS/BmC6K4lpJwIAwT4OcEhsFFDvZIDJozyQ3vy9oLikbfVg/a99v8LQf5RIf3nVaa++NRJNTZ+mkRBNpzZs2wkm7oSEaF9KpvEeakyJQTISA+Ya7msSU7LuyiPplLkFB81zz58kEBpKzG++6RxjnouhKnIgaOa3FMABzL9fG9AqmRGUF9OcCjfJN/wXd6kea4FjG0UQrWoiVLIYV224n8d3m5mWcygJZ9UWYw4CuhGRl8hzezw/YCdviFBRHL7Rxw+Nq5o6gE/CTcusXSFSNq0ZNLTtYt5ozOgo0v8AiyVKE7DunLEenyhYS98GAJpkjHXa1Lv3/L5xnE9Gm0HQr7IrkRCKRR6nKWjqvQeu5J9MZbx2gaEs2Mr8kwjqwffgVPL+woL4d6TlT+VGEpaa4QatDs/c3r9kGgEbTqhFGSShFwVLFdjNQUT+JtpaSJzePPrzYBKQ4PYgzntq3Zo7ziX7gcGk3lvNqKl85fpXpCJx0YNiyHudjzMB4tG/j/CPDwyOHPIhdFmU6iVorL8bwK8U/CGeJUWzFlde5AOGgWdRp/scPSfTS//xXV4tiJ1TJJeyhjI37OyEBw noZO79wF 8ubOEO1OG8hHrPIlq7IVIVctuUr4OkaHQ8OMWhPIbVQIAsKJAKy6bOq9+OIXmeMWWAmEdoV1B4Iax0eAAhzr4LH9I2gVVKwKqZG5Vo+/s8eads0vz4x/3ENapci1FyaEsyzQcuTeQRZJQdqqFp6FVJVLm13WjmDy96Qd+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: alloc_contig_range() requires that the requested pages are in the same zone. Check that this is indeed the case before initializing the tag storage blocks. Signed-off-by: Alexandru Elisei --- arch/arm64/kernel/mte_tag_storage.c | 33 +++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/arch/arm64/kernel/mte_tag_storage.c b/arch/arm64/kernel/mte_tag_storage.c index 8b9bedf7575d..fd63430d4dc0 100644 --- a/arch/arm64/kernel/mte_tag_storage.c +++ b/arch/arm64/kernel/mte_tag_storage.c @@ -265,6 +265,35 @@ void __init mte_tag_storage_init(void) } } +/* alloc_contig_range() requires all pages to be in the same zone. */ +static int __init mte_tag_storage_check_zone(void) +{ + struct range *tag_range; + struct zone *zone; + unsigned long pfn; + u32 block_size; + int i, j; + + for (i = 0; i < num_tag_regions; i++) { + block_size = tag_regions[i].block_size; + if (block_size == 1) + continue; + + tag_range = &tag_regions[i].tag_range; + for (pfn = tag_range->start; pfn <= tag_range->end; pfn += block_size) { + zone = page_zone(pfn_to_page(pfn)); + for (j = 1; j < block_size; j++) { + if (page_zone(pfn_to_page(pfn + j)) != zone) { + pr_err("Tag storage block pages in different zones"); + return -EINVAL; + } + } + } + } + + return 0; +} + static int __init mte_tag_storage_activate_regions(void) { phys_addr_t dram_start, dram_end; @@ -321,6 +350,10 @@ static int __init mte_tag_storage_activate_regions(void) goto out_disabled; } + ret = mte_tag_storage_check_zone(); + if (ret) + goto out_disabled; + for (i = 0; i < num_tag_regions; i++) { tag_range = &tag_regions[i].tag_range; for (pfn = tag_range->start; pfn <= tag_range->end; pfn += pageblock_nr_pages) -- 2.42.1