From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 058A3C54E76 for ; Sat, 18 Nov 2023 23:36:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 19A356B03F2; Sat, 18 Nov 2023 18:36:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 123566B03F6; Sat, 18 Nov 2023 18:36:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F06F46B03F7; Sat, 18 Nov 2023 18:36:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DACA16B03F2 for ; Sat, 18 Nov 2023 18:36:46 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A5E241207D6 for ; Sat, 18 Nov 2023 23:36:46 +0000 (UTC) X-FDA: 81472687212.27.73BABE9 Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf01.hostedemail.com (Postfix) with ESMTP id BAD594000E for ; Sat, 18 Nov 2023 23:36:44 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=VNNzvhC7; spf=none (imf01.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700350605; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p03pvU/XpM4YJ6OSu7IAy6nmhcSG/+SnmKCVHjdFI+8=; b=0D2I7h6DHby0vqxCIeDEWzuZ604WeE9zbi+eS8VdtvEnTCf/apm9gfECNDryJgNFL89oyx zANKhIvjYoFgvThf54heqwLF2vYtIZ/85S/HbE/zTdbOfwrXrvGc+6JIr6wPT3YiH59z4C A3CiMZOwAG86c7we4sRZaLMeY9LzQqc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700350605; a=rsa-sha256; cv=none; b=zsaJT93gSk7rgzc9MoI+pGeKstuB1CVkw43kJGRZizNPaXsmQvcu+ivG7m/n9KrHViBRPa 8pvYd9TR28FjTVEN6RMITiHlljLftKkW8nl4CM9BcW/WkE3ASpPV+ru98ZrSahZeBnqBNM bLldrxfEiwe+mDrNP02yOwWS00oVgKk= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=VNNzvhC7; spf=none (imf01.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=p03pvU/XpM4YJ6OSu7IAy6nmhcSG/+SnmKCVHjdFI+8=; b=VNNzvhC78vvZzWVt1m2sxCtwo5 2mOZp7gjwY13FZYYAtFXUDOLk9NBER/BDK+LLztvkrsdPKHzzQZ357L6kUMXRfjDSxZCVs98FkhRl MGt0QAkO5koP4Zp5VzePhHDNaEi88HXEtEzPCMSmR0AQExxSF6VWlqe/vsiuT5itWpYgGydjtna1v RfEOLZFiBC/eXDKET/ujkPnryKLAD2Mi1O2DDGodSawMNWZdh2Ew5QJRmdxMsUQq5aAO+1qM5lLAx zvBY/WYt3gpAEgwnlhPrph3x64GeDScwWU0FRdjXVs0upuE4OdIyzJzaI6/WISsyDQmmN8nzM/iTS 4aRNaI7w==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.96 #2 (Red Hat Linux)) id 1r4UrS-0002Ba-2q; Sat, 18 Nov 2023 23:36:26 +0000 Date: Sat, 18 Nov 2023 23:36:26 +0000 From: Al Viro To: Chuck Lever Cc: Chuck Lever , akpm@linux-foundation.org, brauner@kernel.org, hughd@google.com, jlayton@redhat.com, Tavian Barnes , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v3] libfs: getdents() should return 0 after reaching EOD Message-ID: <20231118233626.GH1957730@ZenIV> References: <170033563101.235981.14540963282243913866.stgit@bazille.1015granger.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: BAD594000E X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: iqerxj8s9xjaifw36gm3qjdz388shhkc X-HE-Tag: 1700350604-880128 X-HE-Meta: U2FsdGVkX1+BgRnf75KMEYHwHJ2bNQYDeJvjt8S79BB+unf29eRaxVOG5CYWqpM54IZ30Zp2iL4DT6777bIXE+Lb9A99EliAN2UeOo3Rkm+mYK7G5eWOqhw5izcRXpzyYq6QBlu5g88KkMtgPchryYYvhWx5OjJycrrHmtVpRMGhxNDsXCieaap1u1NvNJpROAMBixNuT0RmZeqc3hLoNH7TTVIUqOqPQps0yQSixVc24mCbePI5yeVCRci3IB351fgwLHyGBrILUaYQoNN8WN0CkMK4ffLGH7L/q7UZzh1DXMp5EpwbFJVVYllct4514AtzSrQSOloKfLX2515ek6lIA8gf+BElcMz34TKjdzjAYCSumGr1yxEnb8+Kz0wP6fjHJpUaRgZRhIJ6WDQD0IkgsooFpANwMU4TTHtgs9FxX5edXXZEpq6RWOsip7TXU7YQmZ9jJfXyMsq/GV3Xdt9tpMHIurNCODG9TCyh6w+kJOJ7Zpf/W+TqT6ScVscx/mqcrAB8mpnwWZ+N47V+OBKZMp+JupTnZ0d37EvkyukhEsjc8kPqOEQAWq4B7NMaoiy/JtMpluI2qsQUUe/kn9LnP9bvBw5U43xQ/FR2BcaQNgQNOblEp9f/MSwsO5/NyBAZViLvQtmYCzPO91yex6Lu4L+B4Svs5sZ0hW07T3fwJoqvQ3Yn0IUf5Ef1SqkhLhZskkhW4khI9dIr90yVvmh6xxIfs+QV82pB7coWU4NUtDDnES1W4e9t7qp5QCBAfoBl4lgLei9XLcUli0P9NcZ3nVSpa95vL85hODaMKafU2dFYF3NsBuMOWwI6eVKeYPepWfWDe7XnkaUW6IzoxiXDAjuGoknT6yZId6TZLM5gf5WDIctfhl7V0B2vg2lCrO1SiVi+662SV+fSwU+1T1GqBKeiPECMuRfOoXbDpUfkqeGoUbZ0ZuYxpXxCsCP2alWUFx+XRyRW+nUvFUb LiPRuw1I yPebDgpUMPW9z+F+NYlu/7CxiDYNDtF1ZQYR+8w9SI8NYg4XLl4fFqyEIzaDg+ibq2UcfSg76r7WLRfX9ru8JuI9KQkIoNTY+zaa5zl7v3dJiqLOaQEvsRpeCI2/TvrPk359lNAbEaznJsWLKTo/uvUaddzA86Oj7Oot7QM8NvcaYqw+kExXIE3X9TO/wrYkKNDD9Y2AnU7QaL8/Ep//vdMj3AZPBkzB4CkTzbzMrRqEWm1AEiq6CRMVceCDbIoiZzaJOnSwxpYpBxnw5MK3dTYdCAnwA4P2BZH1L0QbRfPoS2iJ+s5M86WV93W/bGIatKDZhtlesUPIRvK1c8Gnay6WB1S61GfLw7ClW910851iX/0OseJROQE6XCA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.219114, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 18, 2023 at 05:11:39PM -0500, Chuck Lever wrote: > We don't hold f_pos_lock in offset_dir_llseek(), though. We'd better... Which call chain leads to it without ->f_pos_lock?