From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC4ADC54FB9 for ; Sat, 18 Nov 2023 21:10:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 22EFD28001A; Sat, 18 Nov 2023 16:10:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1DE79280008; Sat, 18 Nov 2023 16:10:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CE1D28001A; Sat, 18 Nov 2023 16:10:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EAA22280008 for ; Sat, 18 Nov 2023 16:10:46 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id B2D65A03AB for ; Sat, 18 Nov 2023 21:10:46 +0000 (UTC) X-FDA: 81472319292.25.049708C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 095A520014 for ; Sat, 18 Nov 2023 21:10:42 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Uwn5OHpD; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700341843; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=489vpV9RXrH+d/ozgU5XQmzLO4og5+iBfMzW6UTmXSY=; b=N1SyOy8lXbqCZlEaV4mXPH8nDCZSNhBQd8SoG+jbn8bhOkNLGQBc2pX4hN9vg4ITN2lBgw Gm6D8t7+LQVRayuOYVFwIemcHcnjkkPW17uklbCpn7Cz47TiGZfIicOEn0ySz+MCuqX8at Pe99YQd/ULnoYcZXTxZQtwojmOsTSk4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Uwn5OHpD; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf03.hostedemail.com: domain of brauner@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700341843; a=rsa-sha256; cv=none; b=59AGY17yHsTPhTIXhDlSIiTou2YRWVmqZz78N92h0fbIjkRxX1PFdR7XFBNbXROONsC+xQ GJeNt0uVPQx4wvj1ST7Sp5gjeG05kt4tG6wlSh7mnZSRL7CT9RLlnmmRvS/nDLvlUCBoBz QB4FKUOWfWV8N7ggZpvL+byck5HbU3E= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BEA4560276; Sat, 18 Nov 2023 21:10:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2EA1DC433C7; Sat, 18 Nov 2023 21:10:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700341840; bh=mXAbW6p9WqoD0u0t8uFy7V+znPdvoqa3NFm/kKJO2J0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Uwn5OHpDParhx2ekA8eLj8MCWKu+rNvgejNeHSyFkWC2QGhz8TyWVmREkKZvsgMRv coVLbHiCpZGNpT3jcvxZH8rbXB0jOT2/VovZdXfRzfqDa0W/JuS6X9JZ8qAtfsEOzi G54Nl2/nZfCAydTFMmbK3oTLRtzXl5NfpJxiFvTIj2UuiLWJGjtQGl+up3qCjRaz7E /tip+pcC0Hf8aQ8YT06jf9XS6C34sDE8ilE7FM07nQubbWvKvY22qzoA0zHPhSIZEp N7VqCOim5yX8duIL3bCpldAgpQ7G/yKg46JEMaqqzXM/3wCXRSJt2P+CPOUzwu6j/T 25vgwXGkwudUw== From: Christian Brauner To: Omar Sandoval Cc: Christian Brauner , kernel-team@fb.com, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Al Viro , David Howells Subject: Re: [PATCH] iov_iter: fix copy_page_to_iter_nofault() Date: Sat, 18 Nov 2023 21:25:16 +0100 Message-ID: <20231118-fachtagung-althergebrachten-0b15069e4778@brauner> X-Mailer: git-send-email 2.42.0 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" X-Developer-Signature: v=1; a=openpgp-sha256; l=1180; i=brauner@kernel.org; h=from:subject:message-id; bh=mXAbW6p9WqoD0u0t8uFy7V+znPdvoqa3NFm/kKJO2J0=; b=owGbwMvMwCU28Zj0gdSKO4sYT6slMaRGyq6K6Ky7mbnay+5OnMI1jf2nLZ6GXec91CSxXD4mR MIy5k9BRykLgxgXg6yYIotDu0m43HKeis1GmRowc1iZQIYwcHEKwEQs9jL8D1lmnCb2IT9m+9+S E4wzr2mIsuV5XVzw/73le8Z1zM29AQz/lN9t0T5/6WTDZ+t5towuGQrWoUHZ3w9G7WdLijR4v8K KHQA= X-Developer-Key: i=brauner@kernel.org; a=openpgp; fpr=4880B8C9BD0E5106FC070F4F7B3C391EFEA93624 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 095A520014 X-Stat-Signature: tykk9zsm1m5akyennotixx6ffa87dgyx X-HE-Tag: 1700341842-485090 X-HE-Meta: U2FsdGVkX1/7LWW3XQYNTow8Mk+6lwKp80ikGmEd/rQxCR2hVHj5MY79zuybyedpM10+YNerddOqJyZ6vmDkx9QwIPqAoJcKPOn9oUtq5a8wfcNii4ekfDHHQ/jpTap0G3QOvAYqIybMAyCdWdPFYIfdtQc2Ow4fwJbY6LqSUnTokLM8WR1fv0scnYBQymE4StLIjxBdorCP4tWX2FweESd4cS3PNaKvC1qV9P2G59AlTQhMNUEGZhr69rkiqSnjXd5QMkz9S2dTKPT5QN7XgjReoHijN6GNi8JKBTPFSNjMz0T7L4jVsxACLhpP0cRjO3Gcb7j1Fppr5ZcU4xPNfP5R6cbsLXOAUMa+X3kZHRLn4+imHgnT0NQgLDy1meT+ZnbMCZEfWLSls6LfpLHe4zC71x4Y8lRjZMUpmA0UhjFvvoRVMyYod0zfR1eAtDHuSYWAzbIuW7bk+QfSTKEHDuCwQhLyzszZsW4cGBFMUw/Ja5SW+UFnz1mcelkOHQ+4wFHIUxtS8W26Cw/4OtjIaLRiAHr91iHMZ8ZyUICgoFBAvQVPAFycyCkPYRtFlS3oiIuKa8h4g/4yBwr3hqUDs3AxjMgy/iZx3/nOQFOk3zr+YZ1Cmzt3mx3mYO0AudRuYySq8rT4KtuXBi5a0EOraE/dIfnd/eKwEU0NGuR4NyOmiRrvhGTDqsi2wP4ivWIM3kUDSBGwcnD6gm8T929oDAAnN7OY/uCnpAgOFLYhuLmhC30CiZ4yhe97zkG7PUyR7Y/rtKoMXO/oRtxnkOWbZCqJtBYUd8J6eRpIJMeVuuf4lDfrveBX6kNeQc4YRnBW61X7FFZIE3YnYcfonK28FtMRU1Yu4Wc/8zoRm1SFVoU4j7EPEQqmzuM2RU+gfxQ3gF9tlX7OwaFpermKO3ZRLcAxPSjr1FjqB8FTwKdNggmt81X+53Nl97GF3EMDoUuzMD94lbjDnD80VwkHix7 EMz3odd1 XkezDxYatDEF8ucZ2hOi7qLtjb0HlNS+ZiaIHy8S/qzilj5zv7GmTttXxSlYAw+JVxIPPylyBDd5BaVf5zLytsATCRAYysMk3nX4rHiqQ6BIKEikl3OATz48u+8QKDb26iVzO5/heBcb9HQSHnuKzg+8M4opMh8ts5Iu6nuXzjap3oazCWxxE+cJJQgPUss3BGbinkZ/8aeP5fUs7zJwmNWDivdBB+SjZGPCTKAwcCma6+Pb01y8DNw6DOfEitjYQwbWS3+dNVsM0ejBFdfd2nScHb6+WK5Vj+YlM X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 17 Nov 2023 13:38:46 -0800, Omar Sandoval wrote: > The recent conversion to inline functions made two mistakes: > > 1. It tries to copy the full amount requested (bytes), not just what's > available in the kmap'd page (n). > 2. It's not applying the offset in the first page. > > Note that copy_page_to_iter_nofault() is only used by /proc/kcore. This > was detected by drgn's test suite. > > [...] Applied to the vfs.fixes branch of the vfs/vfs.git tree. Patches in the vfs.fixes branch should appear in linux-next soon. Please report any outstanding bugs that were missed during review in a new review to the original patch series allowing us to drop it. It's encouraged to provide Acked-bys and Reviewed-bys even though the patch has now been applied. If possible patch trailers will be updated. Note that commit hashes shown below are subject to change due to rebase, trailer updates or similar. If in doubt, please check the listed branch. tree: https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git branch: vfs.fixes [1/1] iov_iter: fix copy_page_to_iter_nofault() https://git.kernel.org/vfs/vfs/c/e15912e71ae0