linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Christian Brauner <brauner@kernel.org>
To: Omar Sandoval <osandov@osandov.com>
Cc: Christian Brauner <brauner@kernel.org>,
	kernel-team@fb.com, linux-mm@kvack.org,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@zeniv.linux.org.uk>,
	David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] iov_iter: fix copy_page_to_iter_nofault()
Date: Sat, 18 Nov 2023 21:25:16 +0100	[thread overview]
Message-ID: <20231118-fachtagung-althergebrachten-0b15069e4778@brauner> (raw)
In-Reply-To: <c1616e06b5248013cbbb1881bb4fef85a7a69ccb.1700257019.git.osandov@fb.com>

On Fri, 17 Nov 2023 13:38:46 -0800, Omar Sandoval wrote:
> The recent conversion to inline functions made two mistakes:
> 
> 1. It tries to copy the full amount requested (bytes), not just what's
>    available in the kmap'd page (n).
> 2. It's not applying the offset in the first page.
> 
> Note that copy_page_to_iter_nofault() is only used by /proc/kcore. This
> was detected by drgn's test suite.
> 
> [...]

Applied to the vfs.fixes branch of the vfs/vfs.git tree.
Patches in the vfs.fixes branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs.fixes

[1/1] iov_iter: fix copy_page_to_iter_nofault()
      https://git.kernel.org/vfs/vfs/c/e15912e71ae0


  reply	other threads:[~2023-11-18 21:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-17 21:38 Omar Sandoval
2023-11-18 20:25 ` Christian Brauner [this message]
2023-11-20 14:04 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231118-fachtagung-althergebrachten-0b15069e4778@brauner \
    --to=brauner@kernel.org \
    --cc=dhowells@redhat.com \
    --cc=kernel-team@fb.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=osandov@osandov.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox