From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9625C072A2 for ; Fri, 17 Nov 2023 18:22:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 180586B0506; Fri, 17 Nov 2023 13:22:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 130CB6B0508; Fri, 17 Nov 2023 13:22:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 01E166B0509; Fri, 17 Nov 2023 13:22:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E34216B0506 for ; Fri, 17 Nov 2023 13:22:22 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B36A780BE6 for ; Fri, 17 Nov 2023 18:22:22 +0000 (UTC) X-FDA: 81468266124.04.43C6ACB Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) by imf19.hostedemail.com (Postfix) with ESMTP id D39EE1A0024 for ; Fri, 17 Nov 2023 18:22:20 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PTwvdrJW; spf=pass (imf19.hostedemail.com: domain of 3W69XZQgKCEo4tmwqqxns00sxq.o0yxuz69-yyw7mow.03s@flex--shakeelb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3W69XZQgKCEo4tmwqqxns00sxq.o0yxuz69-yyw7mow.03s@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700245340; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=67j9+17m/+Ov80pCnuJ4gd7d1de7FvoHgKDEaTGjv7Q=; b=7yWNGKXZViMG5okvftFaVumVz6MjjX+vODAxRHJej3cZN1aJwzkHWBNkQWRrsxcHQ4vts2 +NRqkpluybRqjD3cQD3Y2lWoRzJmHx9NgVMiKVeZYzPyOUW0axf37MBZysWqPeBXfeXrd2 2GYx6uZ6A1yJgNVzmw7AeP55X0PEEp4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700245340; a=rsa-sha256; cv=none; b=vzX4wlOxYud3NKbGE0djDYoyRws7YsAUmBkYFZoFNH+WK1cXeUKjMyu51QLq/6iR0xDHSX nHlRshvVKTA5pUb0PtEJb4ksOz8G2oYaCMUTzMZP1fIJ1GUrLEmAEuSIxaHpeeuX2/T94q dso1QmYunwWlnrVwmxbFSH6nzCReNR8= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=PTwvdrJW; spf=pass (imf19.hostedemail.com: domain of 3W69XZQgKCEo4tmwqqxns00sxq.o0yxuz69-yyw7mow.03s@flex--shakeelb.bounces.google.com designates 209.85.219.202 as permitted sender) smtp.mailfrom=3W69XZQgKCEo4tmwqqxns00sxq.o0yxuz69-yyw7mow.03s@flex--shakeelb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-daee86e2d70so2768793276.0 for ; Fri, 17 Nov 2023 10:22:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1700245340; x=1700850140; darn=kvack.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=67j9+17m/+Ov80pCnuJ4gd7d1de7FvoHgKDEaTGjv7Q=; b=PTwvdrJWzSDOr1n0OTnGL6XwcYcelEbNfSFNPICaBvZ1AbKYOOl56CvOzRTo/KeSlb yck6fXr0ziuRUSlYo3d2c0835d1ibD7SxTqGp2jIagU6T6lAsXBJypZMc/LBR3ujMpqY CI8ISWCgZtkbcyQVMOwqzcJoWilEZL01lXZ3YiPwMWFpDkRIh+V/3qdF9S/DtCpt/kad nw/x31tDakCXJ6PwkPVxZM7dEL0LG0QWDrH2UgkCFbfSIUiUELUwElLynBuuDbtM1mIj NKVBW8uUnjQi8ZCj1/Ns/PHNCdCzEV9tlhs8vADwXRh+rBQkRlBsoyYnlSMjOBEiZmCJ l1ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700245340; x=1700850140; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=67j9+17m/+Ov80pCnuJ4gd7d1de7FvoHgKDEaTGjv7Q=; b=dabgPrsW1AT4jELC2VnG825er0WtHQCey5PCaGMswQH5cY8/CCvIl/SCySBj3fs5Re guoPM/2zU68Dk0WcpYqWUGZ9sOTgszNIn34ZQkX3d86/3jucK2D06kIGxCPbUmAO6tHb BIBLA4GC2YXurr66ALrKvOXRy0FEv2j5979bWnL0fFoyPEIkrUJa9Q2sAZ+wKPtT+sfk EVdan87/g7cRStDZ1K8CirekqN08J/Jm02h1HySwhPVLoPqOFucYqdXpNQEPo78IXavY tlApL4gWKL2/5Rf2sfV8VepmJ7mfhMj6m0UV9wdr6MofvaamRUfCZ0CfTjNF1Ul7Qmdt copA== X-Gm-Message-State: AOJu0Yyb5+4eZX+MDTcn59gDPkjVxc/7OBwvIBIvYCop9pY8bc8xHFyD sTR4xXnm14q2XjJfTuM8b4YE6zlH3Zd4Dg== X-Google-Smtp-Source: AGHT+IH7L/taQjdqofqQV9IwVstSBvW9UJq8dFBgbmoT3PvQXn1ozGa9Qj0rost66bwraph/3YhtM1xyxg+Ykw== X-Received: from shakeelb.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:262e]) (user=shakeelb job=sendgmr) by 2002:a25:abe3:0:b0:d9c:c9a8:8c27 with SMTP id v90-20020a25abe3000000b00d9cc9a88c27mr2829ybi.13.1700245339605; Fri, 17 Nov 2023 10:22:19 -0800 (PST) Date: Fri, 17 Nov 2023 18:22:17 +0000 In-Reply-To: <20231116022411.2250072-2-yosryahmed@google.com> Mime-Version: 1.0 References: <20231116022411.2250072-1-yosryahmed@google.com> <20231116022411.2250072-2-yosryahmed@google.com> Message-ID: <20231117182217.q6nkynbh24wyti33@google.com> Subject: Re: [PATCH v3 1/5] mm: memcg: change flush_next_time to flush_last_time From: Shakeel Butt To: Yosry Ahmed Cc: Andrew Morton , Johannes Weiner , Michal Hocko , Roman Gushchin , Muchun Song , Ivan Babrou , Tejun Heo , "Michal =?utf-8?Q?Koutn=C3=BD?=" , Waiman Long , kernel-team@cloudflare.com, Wei Xu , Greg Thelen , Domenico Cerasuolo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="us-ascii" X-Rspamd-Queue-Id: D39EE1A0024 X-Rspam-User: X-Stat-Signature: m71y1jacd3gi5uqikte9gnzkd81ai65j X-Rspamd-Server: rspam03 X-HE-Tag: 1700245340-919816 X-HE-Meta: U2FsdGVkX1+Ckl25mD732o32KpZcfQtR7l8FVEJi+at0UIe484eRLSO2wqOFgkc73FAlynduJ6aZ0tF3+oZw4Ng8xA1VjW73X8FlOn34SL3H0CIzbyiCHqNX71ifcb6CTkhVBtnAli72QJ2OBHIPCbYbEbvnfqbalBy9gIR6mvaRB7Xjtr6EqS3pb236JZ5dQJhqyN1HspxupnE47VyyGfBkkDNsrNu9RLOesOOpyr5dPlZWLbwbJfkqcgGjAaAgguOHzmwLDvbrYD9qyHCkKvZMd9OiybwvCW7dalz9kJoLwq9wzcrNJ2DhXSvHVsID+Nao5m3Bq1mMtQ9es5fFrfPsPHAAfHp52c+MYHR/tPRT3iO5EkfWYwtVa1lKqUVDJUtmziNcuvGZnnm1EpHD2nP1MrrVrxmfi1Ur49z/cwarCN9wTPfS2HGz+x2okjt0X4nKxfiJtLtWR2pH4g17wrEAbTIs51JQgg+tp4DAIi38PmHvv9ZgdcOTUbm9uOZTMWjKAW09ln83nQo8Lx31ePwS+I5d3w5ZFpiIVuhVzskrtHDuWAjhJACZKSvEo42OlY54vEH7cOLG/BP3KRncAGR8upU+30y07p8ppnLArlIwYIdRrcQO2SbYgrQ6s56AJ+g+HAneSMFseIbEjqc6d7SYqNHmLx1rt1Uu4S6smTyO1b5HslQQ4lGqwsV6QG0tPI38UA9Me5ckR4PlGfgNgqgwYh/N18Ud1kBB2nhWcsPGDsdb9+HYRBHG7wm93f4WIUHGr6A9bOGR1EHPwa5i7+ThiilUWt0WNRg7nwbzJtV6ITv/lbwqjJFVIGho7YhJ2KZk9+iFGOrzU13/Hl9ocptMQRWzyu12MuLco0PiyXYC0XAqzAGZzAIADtA2UXWw05izydiUSlhn/EfW66mAVR/6gOxNoKYHVjJ+PpeqF64FRZBtD2pGxFHTkCaK/D8ITSa5w4M6EFyppEwuOCJ YIRVeSpl w1cT0X/iUgmNP2eg7uF4J73RRVXsEXjs6RR8H9hIpaxq+UL8iBQw3KPd+33qFicwm0pacEA97czbCkVe/tw6BPRLHN6JHdcpOUASCSrH/UYZS/G4p9vp5Kakl1cnRpN1WNBQFrhGzj8V8HjvVmLdgsC46JZBer9RYhP2MNeVL963cn5E8+ig5ESfH/qROW1xE9ri5Zd3TzSKN9+3GM2M0TJZb8bTcgv7azP/xiPUiktdao5v0n2mUmS8skMZcyS190W9o71gvNmtGf3/o6kIVrvIEe/OVyD49aAdXlZdF3xnJYzh8/++ot+U62ClXbAueNV4+Li0ZAbWuFUSl6aj51+r4N5tv9vj5T8ufSYO8lB/DLH3Tc/lfsKCrbOBeJ9wtO9stLMyBu+w+DCCJho2oWfG/udpXKlGh3wLgUu5+M0lsG0yvOr67Gwg5UKQu1VNlLm9lV7kdjgYuuBhWkKU0YbG6ORkONTKkYfv4TxoyUhmT4eZ0cdRkmlYEH1joubPMmp0bp2KGe29PcfeqJIpGM+FW7y+GLuFjaWmc7d7NxvwG4U/20rqbbkaAUvz67U5CfFK2dhc97H0NCx9XFi9TCFw4AyVlSPOikrMKbU+WdNkgmncXX3s2s16BCWZDxyF1/tF/jAf86SR6bHE4rWbBSPGmbFNFAfR4wkhKytf437QSCQ2yKeJNKCFDrw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.002353, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 16, 2023 at 02:24:06AM +0000, Yosry Ahmed wrote: > flush_next_time is an inaccurate name. It's not the next time that > periodic flushing will happen, it's rather the next time that > ratelimited flushing can happen if the periodic flusher is late. > > Simplify its semantics by just storing the timestamp of the last flush > instead, flush_last_time. Move the 2*FLUSH_TIME addition to > mem_cgroup_flush_stats_ratelimited(), and add a comment explaining it. > This way, all the ratelimiting semantics live in one place. > > No functional change intended. > > Signed-off-by: Yosry Ahmed > Tested-by: Domenico Cerasuolo Acked-by: Shakeel Butt