From: Shakeel Butt <shakeelb@google.com>
To: Yosry Ahmed <yosryahmed@google.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Johannes Weiner" <hannes@cmpxchg.org>,
"Michal Hocko" <mhocko@kernel.org>,
"Roman Gushchin" <roman.gushchin@linux.dev>,
"Muchun Song" <muchun.song@linux.dev>,
"Ivan Babrou" <ivan@cloudflare.com>, "Tejun Heo" <tj@kernel.org>,
"Michal Koutný" <mkoutny@suse.com>,
"Waiman Long" <longman@redhat.com>,
kernel-team@cloudflare.com, "Wei Xu" <weixugc@google.com>,
"Greg Thelen" <gthelen@google.com>,
"Domenico Cerasuolo" <cerasuolodomenico@gmail.com>,
linux-mm@kvack.org, cgroups@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] mm: memcg: change flush_next_time to flush_last_time
Date: Fri, 17 Nov 2023 18:22:17 +0000 [thread overview]
Message-ID: <20231117182217.q6nkynbh24wyti33@google.com> (raw)
In-Reply-To: <20231116022411.2250072-2-yosryahmed@google.com>
On Thu, Nov 16, 2023 at 02:24:06AM +0000, Yosry Ahmed wrote:
> flush_next_time is an inaccurate name. It's not the next time that
> periodic flushing will happen, it's rather the next time that
> ratelimited flushing can happen if the periodic flusher is late.
>
> Simplify its semantics by just storing the timestamp of the last flush
> instead, flush_last_time. Move the 2*FLUSH_TIME addition to
> mem_cgroup_flush_stats_ratelimited(), and add a comment explaining it.
> This way, all the ratelimiting semantics live in one place.
>
> No functional change intended.
>
> Signed-off-by: Yosry Ahmed <yosryahmed@google.com>
> Tested-by: Domenico Cerasuolo <cerasuolodomenico@gmail.com>
Acked-by: Shakeel Butt <shakeelb@google.com>
next prev parent reply other threads:[~2023-11-17 18:22 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 2:24 [PATCH v3 0/5] mm: memcg: subtree stats flushing and thresholds Yosry Ahmed
2023-11-16 2:24 ` [PATCH v3 1/5] mm: memcg: change flush_next_time to flush_last_time Yosry Ahmed
2023-11-17 18:22 ` Shakeel Butt [this message]
2023-11-17 18:27 ` Chris Li
2023-11-16 2:24 ` [PATCH v3 2/5] mm: memcg: move vmstats structs definition above flushing code Yosry Ahmed
2023-11-17 18:47 ` Shakeel Butt
2023-11-16 2:24 ` [PATCH v3 3/5] mm: memcg: make stats flushing threshold per-memcg Yosry Ahmed
2023-11-22 13:54 ` kernel test robot
2023-11-27 21:13 ` Yosry Ahmed
2023-11-28 1:45 ` Oliver Sang
2023-11-28 1:58 ` Yosry Ahmed
2023-11-16 2:24 ` [PATCH v3 4/5] mm: workingset: move the stats flush into workingset_test_recent() Yosry Ahmed
2023-11-16 2:24 ` [PATCH v3 5/5] mm: memcg: restore subtree stats flushing Yosry Ahmed
2023-11-22 13:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231117182217.q6nkynbh24wyti33@google.com \
--to=shakeelb@google.com \
--cc=akpm@linux-foundation.org \
--cc=cerasuolodomenico@gmail.com \
--cc=cgroups@vger.kernel.org \
--cc=gthelen@google.com \
--cc=hannes@cmpxchg.org \
--cc=ivan@cloudflare.com \
--cc=kernel-team@cloudflare.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=mhocko@kernel.org \
--cc=mkoutny@suse.com \
--cc=muchun.song@linux.dev \
--cc=roman.gushchin@linux.dev \
--cc=tj@kernel.org \
--cc=weixugc@google.com \
--cc=yosryahmed@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox