From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B4CAC072A2 for ; Fri, 17 Nov 2023 16:20:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AC4196B04F9; Fri, 17 Nov 2023 11:20:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A4CC06B04FB; Fri, 17 Nov 2023 11:20:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EDC26B04FC; Fri, 17 Nov 2023 11:20:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 7B23A6B04F9 for ; Fri, 17 Nov 2023 11:20:07 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 538E6A01BA for ; Fri, 17 Nov 2023 16:20:07 +0000 (UTC) X-FDA: 81467958054.30.EFBA323 Received: from outbound-smtp63.blacknight.com (outbound-smtp63.blacknight.com [46.22.136.252]) by imf19.hostedemail.com (Postfix) with ESMTP id 5017B1A001D for ; Fri, 17 Nov 2023 16:20:04 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.252 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700238005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Q/aBej1Ta5D1763OVChtyLphOvRQgrKIHsPKOlwrkO4=; b=IF6bngL4OKzYB+gtMIjvUUsjIT+aVdP3lSLj8osB921nW8zDPjSVfV60VAAgGuIYuc2s2g 8wVfLywki2BdRNfWfVvsY0Lc+kmJGlaB3ohr01IrdzFgp47LCPx7YM21DmkkzRQ7xLwkKU QbHr8/j25YRHQk7qtLbp2/qpwiAZ12s= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.252 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700238005; a=rsa-sha256; cv=none; b=ap7B229BTtO/0Ps5/jlpy0nnbLVURRPpNgT3eoSaypvYecpJSlCzWnvbkeHPeIKXiTvcKB WnNsIhh6PzcPSlcx6jU/cDH1nXYU7h1XfFoGD2B1Zz7ksvhOspN1xaGBt7VS8izJ8DPbjf /n3sdNAqgW7tyHzTi5LWqQ2zPdM44qM= Received: from mail.blacknight.com (pemlinmail05.blacknight.ie [81.17.254.26]) by outbound-smtp63.blacknight.com (Postfix) with ESMTPS id 987F3FBB12 for ; Fri, 17 Nov 2023 16:19:58 +0000 (GMT) Received: (qmail 21917 invoked from network); 17 Nov 2023 16:19:58 -0000 Received: from unknown (HELO mail.blacknight.com) (mgorman@techsingularity.net@[81.17.254.19]) by 81.17.254.26 with ESMTPA; 17 Nov 2023 16:19:58 -0000 Date: Fri, 17 Nov 2023 16:19:56 +0000 From: Mel Gorman To: Michal Hocko Cc: Charan Teja Kalla , akpm@linux-foundation.org, david@redhat.com, vbabka@suse.cz, hannes@cmpxchg.org, quic_pkondeti@quicinc.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 2/3] mm: page_alloc: correct high atomic reserve calculations Message-ID: <20231117161956.d3yjdxhhm4rhl7h2@techsingularity.net> References: <905d99651423ee85aeb7a71982b95ee9bb05ee99.1699104759.git.quic_charante@quicinc.com> <20231116095901.72oqtjoiqzt3tfhj@techsingularity.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 5017B1A001D X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: g79ddyu34xeehgp7yiqaidnyp3jyp9u8 X-HE-Tag: 1700238004-641130 X-HE-Meta: U2FsdGVkX1+gSz2yKknvTLVV8DnJGx4UKZmQHqulSal9h+dqKg0tN89IXkrA/jcDpaMDCZali46PKSoXRI9Z78RXLSprO1c80RmkIXNwgUmj2yGSvbnmcWOfKNKoo0+krytNT/j9QV2xyjaY79OaWC0mYAzxz7Gj8D4VMXU9qUECweSrzqPpdG1Rdk9Sv6ZbDLkHRE07dP5e3/UsGByYHrxfvH0fqLkfpqxXLoND8T0Bt2JLF1hU/+yKShoS5NMacbQuRMfaQzuRDNf9NK3FF7FUHuj/z62757kl4mL+RMvdkahysAWE/L0+FHBm3qdbDivnwOHvStZyP9fCMeNsdeCAeCJ4uWTUfkJ7AB71YS2IEsBRBhDgs62zblxwe8KcugepvoimfctlNa9Eo4NbZLgggpAQNVrXfaVzismGMnjrEH9r046ZZQ6RYwCkurkOT0ErMI04tLn8eFc6NFDkLCVBMDGOtXZ2CiA13KyrYYWp/a8PA6N/CcRH/gjjWtAYw0/tI35G/EJgJnHlKp1E1bwwrjgFdWi8/TI1jnHS76uDudSzaw638FSAfnpN+QnqymRjkNkt9PcPbUeIBTytvUafh/j8po8VSum5J9nxnH4KEJ2zqA4nHTWS+CkVSFjf6BWcIrxay40otKi3V3U4hbEmjhWNNgLAhICnr7GsJiprVM7E2UkiaK9HfXrjpu75x1ZFI7zHs7IvTbIV7EW8YPKehysy3i6R8VYc8TXBceeZEvJ3lxyet82DDfyZs14sluIjevTkKa8f1nP/jGMh24NMiHJABwKUCd0pgbk1P8MTilHMJavESoHJ0WCe+5DrwmY8noa1GLotzpJqP0MCVrqbE5e3e9f906B4OAr0aHAr+42U3DQm3EMpIxDH6bDevhpMwCXRqgoimYDdxsfu+S0616JjR1rg4z8GPA6AK05yXLpGtVqTDKdArq89O6p3pOdED4RnX016UAMiJ/b 8+CdRr8g sMhXuF6ZKP29ScseTvx0L6Bg+C7fWdbBs5b0C+8AYmjf3fWxpgKXrSwYuDAKzkpFoPmR3y7E2HoOI5L5O4ByngwbiNQPZsbgzAamKGzvmnnOsMqJwh7sMxN4phUDmjtazuEdDZF3YDN+FwXX0oYNLg/S54DT+QL8fgOe2QDxDaoviygTIedSR2gM+e92pJSpz00ldLdDFEh7SfM+q7jPprQCx/w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 16, 2023 at 01:52:26PM +0100, Michal Hocko wrote: > On Thu 16-11-23 09:59:01, Mel Gorman wrote: > [...] > > This patch in isolation seems fine with the caveat that such a small > > system may find the atomic reserves to be borderline useless. > > Yes, exactly what I had in mind. Would it make sense to reserve the the > pageblock only if it really is less than 1% of available memory? I'd have no objection with the caveat that we need to watch out for new bugs related to high-order atomic failures. If ths risk is noted in the changelog and that it's a revert candidate then any bisection should trivially find it. -- Mel Gorman SUSE Labs