From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCD63C54E76 for ; Fri, 17 Nov 2023 03:02:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 205A56B03F8; Thu, 16 Nov 2023 22:02:29 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1B5E56B03F9; Thu, 16 Nov 2023 22:02:29 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 07E9C6B0413; Thu, 16 Nov 2023 22:02:29 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EA65A6B03F8 for ; Thu, 16 Nov 2023 22:02:28 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id BCC9FC0130 for ; Fri, 17 Nov 2023 03:02:28 +0000 (UTC) X-FDA: 81465947976.01.EC0D56E Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.65]) by imf10.hostedemail.com (Postfix) with ESMTP id EC007C0006 for ; Fri, 17 Nov 2023 03:02:25 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ECYGtJXO; spf=pass (imf10.hostedemail.com: domain of lkp@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700190146; a=rsa-sha256; cv=none; b=gkhQcTJYYQepHjZb5zGng6KZ0i+aAsOMMArz7TbXQGjLszC73G1WQ6VdqaQhOlYu7KHV9F jYUoJK6tTdUCC3f498PdG+6oPdAR7qM1XZSqAt+gBrOpvf8pAEUjWqYG5uDUkZSWRgd/7B 4bBrb8cLlIkJiQY6UX52xkxYapG8Hjk= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ECYGtJXO; spf=pass (imf10.hostedemail.com: domain of lkp@intel.com designates 134.134.136.65 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700190146; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=aq7NCleBWvwvdGAv8wrNx7oU8kPo+uXHSK6qK3oVojQ=; b=kXnK7okkRwfMAFPeZmGlh4L5CyuXtIuub5kXyiRmWj5L1KeOZPWPSnpP1ZJJy9exSmDME6 QXVK/K2P6Z8/+B6zOBjRhQS92P/tUT4BEJuKGR9DNsBvtxCN0D7tE/PtnYSmBntgJE1vG9 dN44vI2T6fbsdMHvQbsgl1m4ws6ezcI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1700190146; x=1731726146; h=date:from:to:cc:subject:message-id:mime-version; bh=dTIvbztNE02xURyGCuAlcnK0wiR6wDPs1JX/xf5VRDU=; b=ECYGtJXOUJrQ2p9htya/PnLTn47/r0ty2iJcAqAdEFjxsOGspzxj1jni o2gWUCv8Qs0faibbvyULcD5l34RMt2tMR1cb6VKspBRZAvVTGIPxFSAQm CkvtoYhWyPQ3gBG9rFkmBp87eoOth9tiy7dPAtJ7J3AyHqigeqxB3SIEF xHx8MHtYnvNqc9V7hPLAdMER7W7xBaX/EULkx2zCwq9oUF5NlgENqHCQ0 0fgJc+eijyf21whRIMqDdhr5X1ZAOofw4In82TAv+cdSOS56X7DNON8Q/ WBvB7ij5312e/DSmVBM9EVGngjttzrS88wsanoTGqkVvgffxqrYdOeU4x w==; X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="395151818" X-IronPort-AV: E=Sophos;i="6.04,205,1695711600"; d="scan'208";a="395151818" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 16 Nov 2023 19:02:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10896"; a="1096978503" X-IronPort-AV: E=Sophos;i="6.04,205,1695711600"; d="scan'208";a="1096978503" Received: from lkp-server02.sh.intel.com (HELO b8de5498638e) ([10.239.97.151]) by fmsmga005.fm.intel.com with ESMTP; 16 Nov 2023 19:02:21 -0800 Received: from kbuild by b8de5498638e with local (Exim 4.96) (envelope-from ) id 1r3p7b-0002JH-1Z; Fri, 17 Nov 2023 03:02:19 +0000 Date: Fri, 17 Nov 2023 11:02:09 +0800 From: kernel test robot To: Drew Fustini Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Ulf Hansson Subject: [linux-next:master 1554/1745] drivers/mmc/host/sdhci-of-dwcmshc.c:873:7: warning: use of bitwise '|' with boolean operands Message-ID: <202311171015.WiPtQrdU-lkp@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: EC007C0006 X-Stat-Signature: 879purdi4tob681keprrgbu1naotoca6 X-Rspam-User: X-HE-Tag: 1700190145-533725 X-HE-Meta: U2FsdGVkX19uL2ZzseE2Rq9zy6nHfDmwsA/QCOfZyBwGGv4cTeEvbRhHB0HRIHo2C6IJet7i+zNuAn1R9qbuLHBhWPwUHiCOgBeFf4z8PO38RCTyaNvKijTUbcvp6PfCRL/9F89zTWnN9zCbaBQlLNM2KnuVlkmBLaKPr1MXxNBDTGpvOWeveGx5tTmqKXiznTWAo3Bfx6zg5oRKdZQHoDQjSTGCca+69Jrgd5kF0F9QGI485N7ONdHfkwqJ9crqRg2nFnjFXguQOcA+7+Sb4SN4qRQacP08PTbAkgyqervDicgjpQGWSCxNvvCE+CGVmTBBD9jmuw7AumGBjuU0gegAltuDC5MpUbQW2C6ymevEpHH5tzGxyS//1m0U3e/ygKtAHRaT214KE5K4s4UhpHSzgxShtXmRCK7p+FR740LdkqwLRaMW7yqz+aGlOIJXrYOdA+Jz6fahrK0SHbf2svIjy5OZ2FoJ6tVQ37a2et9tiOD1xn5RE/KhlToZe0GydineHJOxqPBQF59xvERKyRiP1Ndm56NUUce4PBhdlAeNF3k+Wsu9UCTWdZkDPcf8NePzCXheqWg7bLVVudoHKlp4Gk1kz9hPuX4eJmlktuAAepq7td26bmlWINqrYD7THFk3YQZjOCpGcV1UPIsjGQAQcq+OcvYzIxFsosMK4l74mJLv8U6sd4szYyJ7LNWYLWonSY2rd3bgJpKorTrhyTd50Yj9bGMCJEebfpRMuakoRU7s5CuGyx2c57hJjnvZ2W4uOk/qw4GPJqEEZSc5921saPHkIL2Gm3kO6lBiv9Ix/O6Ian8gkR5GNcTffoB6rrca1MjP2tHHnIZ3JGTKA8oKYTdtiJrckBbGQClQLYMvyKXaxyxtsl6pDmrBI0muccFWDCVyoSfBTQSE4kbqn5gp+ErwHaGH+VVdtoRxN281lUcFku3ff7xsANqoc88slJrEKn+ussKdT2eziHL YCjARYLh Pkj32uv+upgO6aWWA9/e1853bQCLrLzsx3DS/qWMJtXWLOXCu4oh2vFV3nCopa0dxiHYYi/S+6slixw5+B9s648JXoDZ0nk89mKJu6ICuDrzYdIhzljrJCzILt0g7bLWeZn88ZQmhmOFNCmpQ8RtxnfkxObptAiaRy8rUMDWtFxabWw9ykIqpq47zvK6yGYcrQhQnjqkmN+WAgkKC0x4W7uFZYFU71NDOst1Zho1ymelq8wirusQKdbcVGt3b0ozLkpS5BcbyKTO+X47GyReDVVjMIPjc8z+6PNlxKJnecq2XN3XiG0qVsMHh2Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: tree: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master head: f31817cbcf48d191faee7cebfb59197d2048cd64 commit: aff35fbc7830510ef7cbcf8e32a041a55de3dc51 [1554/1745] mmc: sdhci-of-dwcmshc: Add support for T-Head TH1520 config: x86_64-allmodconfig (https://download.01.org/0day-ci/archive/20231117/202311171015.WiPtQrdU-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231117/202311171015.WiPtQrdU-lkp@intel.com/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Closes: https://lore.kernel.org/oe-kbuild-all/202311171015.WiPtQrdU-lkp@intel.com/ All warnings (new ones prefixed by >>): >> drivers/mmc/host/sdhci-of-dwcmshc.c:873:7: warning: use of bitwise '|' with boolean operands [-Wbitwise-instead-of-logical] if ((device_property_read_bool(dev, "mmc-ddr-1_8v")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/mmc/host/sdhci-of-dwcmshc.c:873:7: note: cast one or both operands to int to silence this warning >> drivers/mmc/host/sdhci-of-dwcmshc.c:873:7: warning: use of bitwise '|' with boolean operands [-Wbitwise-instead-of-logical] if ((device_property_read_bool(dev, "mmc-ddr-1_8v")) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ || drivers/mmc/host/sdhci-of-dwcmshc.c:873:7: note: cast one or both operands to int to silence this warning 2 warnings generated. vim +873 drivers/mmc/host/sdhci-of-dwcmshc.c 789 790 static int dwcmshc_probe(struct platform_device *pdev) 791 { 792 struct device *dev = &pdev->dev; 793 struct sdhci_pltfm_host *pltfm_host; 794 struct sdhci_host *host; 795 struct dwcmshc_priv *priv; 796 struct rk35xx_priv *rk_priv = NULL; 797 const struct sdhci_pltfm_data *pltfm_data; 798 int err; 799 u32 extra; 800 801 pltfm_data = device_get_match_data(&pdev->dev); 802 if (!pltfm_data) { 803 dev_err(&pdev->dev, "Error: No device match data found\n"); 804 return -ENODEV; 805 } 806 807 host = sdhci_pltfm_init(pdev, pltfm_data, 808 sizeof(struct dwcmshc_priv)); 809 if (IS_ERR(host)) 810 return PTR_ERR(host); 811 812 /* 813 * extra adma table cnt for cross 128M boundary handling. 814 */ 815 extra = DIV_ROUND_UP_ULL(dma_get_required_mask(dev), SZ_128M); 816 if (extra > SDHCI_MAX_SEGS) 817 extra = SDHCI_MAX_SEGS; 818 host->adma_table_cnt += extra; 819 820 pltfm_host = sdhci_priv(host); 821 priv = sdhci_pltfm_priv(pltfm_host); 822 823 if (dev->of_node) { 824 pltfm_host->clk = devm_clk_get(dev, "core"); 825 if (IS_ERR(pltfm_host->clk)) { 826 err = PTR_ERR(pltfm_host->clk); 827 dev_err(dev, "failed to get core clk: %d\n", err); 828 goto free_pltfm; 829 } 830 err = clk_prepare_enable(pltfm_host->clk); 831 if (err) 832 goto free_pltfm; 833 834 priv->bus_clk = devm_clk_get(dev, "bus"); 835 if (!IS_ERR(priv->bus_clk)) 836 clk_prepare_enable(priv->bus_clk); 837 } 838 839 err = mmc_of_parse(host->mmc); 840 if (err) 841 goto err_clk; 842 843 sdhci_get_of_property(pdev); 844 845 priv->vendor_specific_area1 = 846 sdhci_readl(host, DWCMSHC_P_VENDOR_AREA1) & DWCMSHC_AREA1_MASK; 847 848 host->mmc_host_ops.request = dwcmshc_request; 849 host->mmc_host_ops.hs400_enhanced_strobe = dwcmshc_hs400_enhanced_strobe; 850 851 if (pltfm_data == &sdhci_dwcmshc_rk35xx_pdata) { 852 rk_priv = devm_kzalloc(&pdev->dev, sizeof(struct rk35xx_priv), GFP_KERNEL); 853 if (!rk_priv) { 854 err = -ENOMEM; 855 goto err_clk; 856 } 857 858 if (of_device_is_compatible(pdev->dev.of_node, "rockchip,rk3588-dwcmshc")) 859 rk_priv->devtype = DWCMSHC_RK3588; 860 else 861 rk_priv->devtype = DWCMSHC_RK3568; 862 863 priv->priv = rk_priv; 864 865 err = dwcmshc_rk35xx_init(host, priv); 866 if (err) 867 goto err_clk; 868 } 869 870 if (pltfm_data == &sdhci_dwcmshc_th1520_pdata) { 871 priv->delay_line = PHY_SDCLKDL_DC_DEFAULT; 872 > 873 if ((device_property_read_bool(dev, "mmc-ddr-1_8v")) | 874 (device_property_read_bool(dev, "mmc-hs200-1_8v")) | 875 (device_property_read_bool(dev, "mmc-hs400-1_8v"))) 876 priv->flags |= FLAG_IO_FIXED_1V8; 877 else 878 priv->flags &= ~FLAG_IO_FIXED_1V8; 879 880 /* 881 * start_signal_voltage_switch() will try 3.3V first 882 * then 1.8V. Use SDHCI_SIGNALING_180 rather than 883 * SDHCI_SIGNALING_330 to avoid setting voltage to 3.3V 884 * in sdhci_start_signal_voltage_switch(). 885 */ 886 if (priv->flags & FLAG_IO_FIXED_1V8) { 887 host->flags &= ~SDHCI_SIGNALING_330; 888 host->flags |= SDHCI_SIGNALING_180; 889 } 890 891 sdhci_enable_v4_mode(host); 892 } 893 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki