From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2875C197A0 for ; Thu, 16 Nov 2023 10:58:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 31B3D440156; Thu, 16 Nov 2023 05:58:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2CA7A440009; Thu, 16 Nov 2023 05:58:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1B9FD440156; Thu, 16 Nov 2023 05:58:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 0B5D1440009 for ; Thu, 16 Nov 2023 05:58:27 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CDF3D1606C1 for ; Thu, 16 Nov 2023 10:58:26 +0000 (UTC) X-FDA: 81463518612.20.3C61137 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf10.hostedemail.com (Postfix) with ESMTP id 507A7C000D for ; Thu, 16 Nov 2023 10:58:22 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mB07d3Q7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700132303; a=rsa-sha256; cv=none; b=JevBGr5sZuBoUwrBrm/JUCKbPPYF2P7jJ6s60pS1fgMe+f46gh8ilMi9Yd10GsN6zkYlKC o0AWBoguntZsO0zsUBovB2rWOiWOJ23kf+QCB6cI8WmhlpYYIygA6Vjzws9XuYlKWtzlUE yedtz5mIk+EYaDCvzZSbPCIbkVeCnWA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=mB07d3Q7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf10.hostedemail.com: domain of sj@kernel.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700132303; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gQkXl7rSMIGriE3WoQVUpNiOo8++tLYBifbdvtVVhBo=; b=JzPQgCoutVGpRBTLdf9j91FgtCj5Jisy3un+umsu0m+uxf1wH1qSw7+APC8faJUlLU/C0/ r/BV1oVY6c3s7GmfqPxQyji3aNdPfkILYY7QU9pw/bzTPHC9Kb6Td+7B9jdHHi68goFW/H Ap5V2ftVWDvM/Pco2Pkdul0re8S2yJQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 0DA24CE2036; Thu, 16 Nov 2023 10:58:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF16AC433C7; Thu, 16 Nov 2023 10:58:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1700132299; bh=M+8iKSmznVXEZTfGoN0FrGmEHGx1v9DKi1Ga7R7HHOg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mB07d3Q7ViI4kjC0hpgE+fXB4OTqUzVdXsyIGTCCGOegiB21GcqULmwnQJ1EeDIBC Mws+buiwIwtecIwYobCeUxKnssn6vQ5jJFacZIp1SVpRNfjzqGSu56oolFFAymOxd7 6k968IkW5nsJSH6lOdfjDPxhRJWlz3P4MipPYJcE0iZF8Gsc20G6DVyEi5VqvyjBT9 n2YHEvJrEgTG1+SBeoKqlZzOp5tA6hca84d8wpMUjP+a2jAXZdtpXeALDYH+rPKhtf QLbNWffvtXyAaQNjl2UeRg9pBIFsPHhoOtKRDMiobAYX2it/qfuly2r8IQe9v+s6Eb oAMaUKeWCv70w== From: SeongJae Park To: FANG2508 <1031576200@qq.com> Cc: linux-mm@kvack.org, sj@kernel.org, linux-kernel@vger.kernel.org, damon@lists.linux.dev Subject: Re: [PATCH] mm/damon/ops-common.c: Fixup missing parentheses Date: Thu, 16 Nov 2023 10:58:17 +0000 Message-Id: <20231116105817.51824-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 507A7C000D X-Stat-Signature: pdm68psg8yij6339xyzb617cot1witrd X-HE-Tag: 1700132302-7772 X-HE-Meta: U2FsdGVkX18LpxRNuIuVLkjWo7H/8entCHkCZev0i/zDAvAMsLnGOl4cIKMRzeCYVSGgdrse7HeWaRbHF1XwT+TEynrPewPcu1J3M5iqrXHYxI2k0DyXqh+mgCKAiu0d6+1/tWVxf5NVkrgp8e+dkaYcch21oS0uwXfPfC9bYxZ7+hAkS+o0uN1OLqqHJyeVSOiBPV/nn/xoobs6sSzDsylGP8t4gkM6wAGuhrP3mqmPeh7tE1G9SKpGwlcYZVx/0bdNeeUNKhAIgjSQvSm4kxn3z8Lt2mPvxyIiwycR1PQEhq+yRrKqIe/MPePPMkKS5sjSzr42tKortGZO8umVcMazaJje4gyJZvwmUgezATlVWJyQCi4qXXkQxO61j8pI3piAf/UCxRysZVSTwdkjGL/U3T6wza85DKdzW634U2RRfunNdTlQ5Vz0ku0pikMuev9o9HIJNW4iMmmDSB2ZpRde3/CHVmFXaEYbFDrGwvBkOIc3iXnXIpshTtPO7AMFqk5AoaZhQk9+Qu/6/tj+HA/7KkZCs52pDuxgGXEd0oDCgGGK1mGrqzqOTBz6wN0/DSNkKUrYXEvWiv2SivaaNC6CIajEdYeIHlZXTOav8v5rjeATCMxLjxpnWwQwni/T7aoSwjHHkW2R+iNPeDpMLdosTAD5/aDaQkmHnTrrVK1FxKdb18DG6ACIi12gGscsTpUh4kpye0hE9s5nCcESXRgxWv6wbOSNUtuJ9/whX7J5g9s1RICO0mOOAbOztrbpVK7kqB23trjKkZXRCk/qGT1QXIn4xJ0QIzERauSbLJE3BXdbUTjC8HTQ8NCS5D5Kq6SikQrIdd2GuAdwSDJTNY9gfp4m90+CZj6uExiwSYa4j8ykWsCMkcKcn4+RUP1pCZ5jbzpHFCV+jTlLSsho2lF0F3BeQMhxMvSuhq2WYYR9+qwU7U/GXZalZcdgb9ISPZZoBPBvv0P3RKpIfK4 7ww+tg0I IKZRdDaj16loFQK/9T3AGZNILb7BYk7JBwCWdB563KivtXnFprbiCC1oM0uqILOmm3tVk3suut+Gbs5GNpp2RDnbbz15wFB0/QQUCId5FB38fPMmEAheZOrZWPeaoWGidRvY6EfH07PgslW2ND4nbk/7R1H4m6gPOIEfsEiv9mD24NcJYMLXPsrLK4+KLtvydVC+sz+54TdkO4Ot9sdtdYJLsZmmOBQsb1dCdrjSW14u9iHhhcQifD0g4NefaeJkDaiOm X-Bogosity: Ham, tests=bogofilter, spamicity=0.009432, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello FANG2508, On Thu, 16 Nov 2023 18:21:47 +0800 FANG2508 <1031576200@qq.com> wrote: > In function 'damon_hot_score', the variable 'hotness' should be divided by the sum of 'freq_weight' and 'age_weight' instead of /'freq_weight'+'age_weight'. > > Signed-off-by: FANG2508 <1031576200@qq.com> > --- > mm/damon/ops-common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/ops-common.c b/mm/damon/ops-common.c > index d25d99cb5f2b..fc7886c63bf1 100644 > --- a/mm/damon/ops-common.c > +++ b/mm/damon/ops-common.c > @@ -102,7 +102,7 @@ int damon_hot_score(struct damon_ctx *c, struct damon_region *r, > > hotness = (freq_weight * freq_subscore + age_weight * age_subscore); > if (freq_weight + age_weight) > - hotness /= freq_weight + age_weight; > + hotness /= (freq_weight + age_weight); Thank you for this patch. However, I think the old code is ok, since the precedence of the /= operation is right to left[1]? I also checked that's true by confirming below simple kunit passes. int abc = 3; abc /= 1 + 2; KUNIT_EXPECT_EQ(test, abc, 1); Please let me know if I'm missing something. [1] https://en.cppreference.com/w/c/language/operator_precedence Thanks, SJ > /* > * Transform it to fit in [0, DAMOS_MAX_SCORE] > */ > -- > 2.39.2