From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34ECFC2BB3F for ; Thu, 16 Nov 2023 01:29:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D6C3A6B03E7; Wed, 15 Nov 2023 20:29:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CF33D6B03E9; Wed, 15 Nov 2023 20:29:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B43356B03EA; Wed, 15 Nov 2023 20:29:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 9F5366B03E7 for ; Wed, 15 Nov 2023 20:29:25 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 78AC01CAD62 for ; Thu, 16 Nov 2023 01:29:25 +0000 (UTC) X-FDA: 81462084690.14.41A20ED Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf05.hostedemail.com (Postfix) with ESMTP id 6810610000F for ; Thu, 16 Nov 2023 01:29:23 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ISpriMu8; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700098163; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bUKDadnp+1aD4MuuhezpyppaSOr8lCSuMGXbTAXddpQ=; b=gi+c4EXzHvIzMbw8p9PCuP+rh4KEqlg3iA5tHBP8H8o99GNIRIGvcV5FfdL1TSIr4VZ80R 06LLDzeuCQGqr7km/nihMN6TaMRG8aBKbmr2quu2zy47EQ+y9mvU2OXXPQzJZdkb/Tv6MS qv3FpoiY+/SKAf2hWByQvtc+igbebtQ= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ISpriMu8; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf05.hostedemail.com: domain of peterx@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=peterx@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700098163; a=rsa-sha256; cv=none; b=0H8KpnN0Oqcllc2IF5TtRSd1koxoBjN5L84Ll+Uagd276v5JzvqNtZLhquybzHqwdev4fl rOfW5PB0WnB2tlknKD3bkdGo/2zCqRddOPY3yvSf6vmnJQC+16ylt6m6ce3442KXVQZUwW 1Dg3OEg2T4QwwP7wneJVzMunV7syv7c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1700098162; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=bUKDadnp+1aD4MuuhezpyppaSOr8lCSuMGXbTAXddpQ=; b=ISpriMu8yGjWIlMf/FTN2qDnDbzOacO8LwZIbhWXXo58Hnn9Nc6gSZMcWhOBS1wIao8ku0 bnVByu6CqmwzDz+epiELqETzjevXFEhH82E9kupK1KMpBGzkQ1nKxo39GZC+s1Z7F8zxXD kTjF8XI+hdybutIHwveXzVtK8Kpm0Hg= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-182-5m6WC-yBNEiffqFXqkbbPA-1; Wed, 15 Nov 2023 20:29:21 -0500 X-MC-Unique: 5m6WC-yBNEiffqFXqkbbPA-1 Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-41eb42115e9so899461cf.1 for ; Wed, 15 Nov 2023 17:29:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700098161; x=1700702961; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bUKDadnp+1aD4MuuhezpyppaSOr8lCSuMGXbTAXddpQ=; b=Zun1N2iSTRyQMMtvFOJtMWvVITYwhGAZ1069npVDthJeSHhxkNV/+KYYe+OyeWpl+4 mwqZrwTpHWTgEud8AW2yKzlm8XMnkLEzezIvKxZwdphkgkajX2cib2OqhEeD8XjxqqHW JyXmymC2/JWX376rST4SS2XsQ9ZF7YAAPdE84cCTO4jKrmNaAApR/w9VUS7JG0dN/arO 9tS9ZDmIxIU7pmSVCHFaT/2EjZCfIqraW95v8P8Y6jK2gQOR+xVn6wrfff1hoOEUsD1q ElRMIpFG686pUBbtwyljf0Yl6fD7rXC7Rb5W2VEoJIl1dNdKHfEh5XujclDWExBdzytL onIg== X-Gm-Message-State: AOJu0Yxvaa8mNVzyskyh8kWW2ZBif+GbOUBl0TP464HUgGfFLe+PJso8 9xaaZTynMkxYRLFv5tr+S03Q6o+vh7zoI9RQ3eolV6ACBdtG8JEVQ4QDlCpTW9qeU1Yb+O5LXUa Iej0Zyo5b72w= X-Received: by 2002:a05:622a:810e:b0:41c:d433:6c86 with SMTP id jx14-20020a05622a810e00b0041cd4336c86mr6482552qtb.4.1700098160985; Wed, 15 Nov 2023 17:29:20 -0800 (PST) X-Google-Smtp-Source: AGHT+IEBd1/VL7OzaVonjYuLiYORLZv0OSCh6ZT9Z6PevvXUdWDeqJg/IL5dpgLaUCzFthgUgScdWA== X-Received: by 2002:a05:622a:810e:b0:41c:d433:6c86 with SMTP id jx14-20020a05622a810e00b0041cd4336c86mr6482544qtb.4.1700098160768; Wed, 15 Nov 2023 17:29:20 -0800 (PST) Received: from x1n.redhat.com (cpe5c7695f3aee0-cm5c7695f3aede.cpe.net.cable.rogers.com. [99.254.144.39]) by smtp.gmail.com with ESMTPSA id c24-20020ac85198000000b0041e383d527esm3922598qtn.66.2023.11.15.17.29.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Nov 2023 17:29:20 -0800 (PST) From: Peter Xu To: linux-kernel@vger.kernel.org, linux-mm@kvack.org Cc: Mike Kravetz , "Kirill A . Shutemov" , Lorenzo Stoakes , Axel Rasmussen , Matthew Wilcox , John Hubbard , Mike Rapoport , peterx@redhat.com, Hugh Dickins , David Hildenbrand , Andrea Arcangeli , Rik van Riel , James Houghton , Yang Shi , Jason Gunthorpe , Vlastimil Babka , Andrew Morton , Michael Ellerman , linuxppc-dev@lists.ozlabs.org Subject: [PATCH RFC 06/12] mm/gup: Drop folio_fast_pin_allowed() in hugepd processing Date: Wed, 15 Nov 2023 20:29:02 -0500 Message-ID: <20231116012908.392077-7-peterx@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231116012908.392077-1-peterx@redhat.com> References: <20231116012908.392077-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII"; x-default=true X-Rspamd-Queue-Id: 6810610000F X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: 6e6jgwjhkbqc4ty8m7a65373uccwjuxq X-HE-Tag: 1700098163-887940 X-HE-Meta: U2FsdGVkX1/I9zIdcLxtq92ShYpu65BckFivakyW9XuZiZ2ZhbwGXQ5OgnuP7I85EKawxVybpNf7WOXE21FweHfbfbSw2bN7vNCbb/oH93WvkfyGthrI72lpx7vm1uzFGFPKiGQnwrSglXvljkrkEYxIhUReDiUf1LNK+IM7MwkJSitEvSQTrjq78pcekb3Z+nunkGvNR6HLgzo+gl2tV9FkF9UiGECFEo5t+ublLIKz0bT6tefb/LnpOAljg1w6iKEMeeShod6rbZ+F8QFog9qJFhZUPa1/t9QDAMr1whXiWPcv1bMgN3tSmWIn02/bUvT0qlLb5cjQ9hQBz3ia8br85hnC+Vnb4Kkir2HcZPO/YhoOBdKqx0tuWjo2nz84X3VRjnERgsyLg6jpwK5EY7WDK+RfmvRgBxQzN4w/b5oCAq+yer0IJuPzc06H8vXOjbWCIhJr1mekb2HX5lkAa8eECwM80NNGGlLgDFmAXO+ewpCyu53VFkLSJtz7oUvTxgBfwXYVEBtyj8r4ngYMPTOKgl4Bxe/hfngKZdwX6rTlRtHYubRW7McJDxDRpdw0HthzdGNomI5n/wZlS46W+WFOeag8WOH9ypRWJOAhiXPcuPnenxnI8NDX9C2rr84DTawDzQP54Wqcd8/kh2rpA8ob1pMfjSzAhn/hOuUx4BaMPruIjraWvAe067OMY50VApdWDpAaTFHBkeAR66GPhjzifdKEHNUbX25JCtQ//MTQBsqZxnzVIKBLTcyiVEuYUJgDDSH05KpE1yXojRfXgE5XP3Z3ZQa+niIjv+/0zdEHABwRePKZUJyhbAAr3AmzYs84awg10vDRc3OUnvWxOshoL5VMtWYpyoHZeOEbr57gSTtC545I1weT7X/OVEnrt3oYsxWylvcwT/VA3Z9j/+uLL9gSn8mQepxZuAg+PPw1Q6Qeu4ISJ1Ms8M2FPFnJ07uHrDbBVwwq01GzgFO dp+jtn2c N4m7L2C73KjPTlcmPHaNN/XN3nZwZwTzGBVFy+Q2PAM+n8u+nVUWmgOvu8kpiXsEJjwxtNlzHwpzzDaRLFowd+NDEhYxtP+qIIJxXorNZnofscrsUDKpVA+4Id6WMS9LwKO1ePZeJKBO9I9bOEPtMbRW38F+cgoeVD6EgiGwbryGldkcMJPPFmg6a9u34b6VVm24ck1c+pCjLQXzbJTe1q4swW38q8vWvoIsyGuaX1dmNkiSVJhLxhnf/KEAzMAhOGF/qea7BaeuD7sodwDGjY9gKI+indY4/YGM0i1rSsjR5IdLkoDVRyYkfQMlN2kH1Tf2RK9Wr2LZMq6mCedxBjvVIDxVOhss1x+3G/44lQlaZaTN1gegiQuy0um4ArBQi0gAF6jXaSkQlZLMM2er4Qw3xxQQudX3vu/LXSXKHfbq6BxSIRobV/dwl/2ldAvWSvpWKAERuuNSzf17A2LRih4uWWx11NAmmzGIRFMRMbHNTJX5ejbpMFnWJ++2uFoFyrOnd5uM3IRYgCOA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hugepd format is only used in PowerPC with hugetlbfs. In commit a6e79df92e4a ("mm/gup: disallow FOLL_LONGTERM GUP-fast writing to file-backed mappings"), we added a check to fail gup-fast if there's potential risk of violating GUP over writeback file systems. That should never apply to hugepd. Drop that check, not only because it'll never be true for hugepd, but also it paves way for reusing the function outside fast-gup. Cc: Lorenzo Stoakes Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Peter Xu --- mm/gup.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 0e00204761d2..424d45e1afb3 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -2816,11 +2816,6 @@ static int gup_hugepte(pte_t *ptep, unsigned long sz, unsigned long addr, return 0; } - if (!folio_fast_pin_allowed(folio, flags)) { - gup_put_folio(folio, refs, flags); - return 0; - } - if (!pte_write(pte) && gup_must_unshare(NULL, flags, &folio->page)) { gup_put_folio(folio, refs, flags); return 0; -- 2.41.0