From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5D00CC2BB3F for ; Wed, 15 Nov 2023 20:34:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 983828002F; Wed, 15 Nov 2023 15:34:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BDFF80022; Wed, 15 Nov 2023 15:34:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C4A08002F; Wed, 15 Nov 2023 15:34:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 551C380022 for ; Wed, 15 Nov 2023 15:34:33 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 120BA1A0AB9 for ; Wed, 15 Nov 2023 20:34:33 +0000 (UTC) X-FDA: 81461341626.03.BD74A3D Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf25.hostedemail.com (Postfix) with ESMTP id A6F6EA0019 for ; Wed, 15 Nov 2023 20:34:30 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=EmWgrT7y; spf=pass (imf25.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700080470; a=rsa-sha256; cv=none; b=3xDzto7RVTXGvkVU6/uon5Y83WZj/seFlSW+D608aKaeEOmh5dq9NRtsa4jcOOuYF132C1 D7EhWvkewGiT1k70V0OMGuX/L/nS5SfQK6rOlns/9QdjQsNrSjfC7LBlOZwBcFn0RicQi4 234Ln888Cfe8j4kHR4rE1E69QuXUewQ= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=EmWgrT7y; spf=pass (imf25.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700080470; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Px0rK9+UdAvKZPZ7DYl+Y7dmIAhcf5TJsq/L/AiJTMo=; b=4rSbmp52s8oQDCUXTNRlipGeB+U/IZ8M6xRB7HQNyzIrwRDxdlc91P2nQah1jzqiE1TKd9 h33HGFDy9gAu20p57LWAE3jG9tsJeWOsMR5vc+ZQJMyhn69cD+E/e50Ko8ZeVWMcHESnKh A1Ae5A7rM9KzxiYUEJu49Ie0AdEe/R8= Received: from pps.filterd (m0353728.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AFKWs2S030886; Wed, 15 Nov 2023 20:34:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=Px0rK9+UdAvKZPZ7DYl+Y7dmIAhcf5TJsq/L/AiJTMo=; b=EmWgrT7y4bMRo/sPUnhX4XtYy0HE7VGWic6ewv8F+nIInGCMDVODOsHwEs/4+jYERfGD mNMCvEtmuY/wkeulBcAGRaqup6FdOY8nwc2So/fn74OFnsiFoipXKm4aWXlrxoIDCQGY OLBnfX9wES6plwqEbQpW5e29MhqzRxlpEQWUOfVFOR+LcxJZ9HoVggn4UlN7YnQicuik pDmQonoxFSuhsKEtKKrYDq7PHjX7L98Yyo9B74OzpMrmcyjkfOR2W8T6QeVxzbDytpXC lNHu7/OZESxHt7BIJokFXszmH3l36HO/HwADXxyRsg6wgRhwyRWt1/wfbxMBla7ckFMj VQ== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ud543g162-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 20:34:24 +0000 Received: from m0353728.ppops.net (m0353728.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AFKWsDX030885; Wed, 15 Nov 2023 20:34:23 GMT Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ud543g156-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 20:34:23 +0000 Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AFKIxCd017495; Wed, 15 Nov 2023 20:34:22 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uamayj78r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 20:34:21 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AFKYIKS22938342 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Nov 2023 20:34:18 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C150F20043; Wed, 15 Nov 2023 20:34:18 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 76AD320040; Wed, 15 Nov 2023 20:34:17 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.179.9.51]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 15 Nov 2023 20:34:17 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH 06/32] kmsan: Fix kmsan_copy_to_user() on arches with overlapping address spaces Date: Wed, 15 Nov 2023 21:30:38 +0100 Message-ID: <20231115203401.2495875-7-iii@linux.ibm.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231115203401.2495875-1-iii@linux.ibm.com> References: <20231115203401.2495875-1-iii@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: HD7io_J1O9IEJux-CMEYdG8MJqs-tACj X-Proofpoint-GUID: zQLNbotbJOONuucBdc1_g_GKmcQkwnzj X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-15_20,2023-11-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 adultscore=0 priorityscore=1501 suspectscore=0 clxscore=1015 mlxlogscore=761 bulkscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311150163 X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A6F6EA0019 X-Stat-Signature: aoapjbyrgshxygp1k1imy7c9tqhwa7zt X-Rspam-User: X-HE-Tag: 1700080470-547429 X-HE-Meta: U2FsdGVkX18uFH28/yMzRklroCr88IqxHotSRdxxgKSDXQHP+D7bGvIPoTBYbJqh0lz0NpILEfZsWw2AthldxdyILlHjDrcgXr4Gb4o9sKaE4H369ushEj1tJ/q8zF3RglrUC3KGfvaChIXMkSLPLJHYKVv3C1Tx8xxX29r+EGVXbCoQQOUs9I6ZjWifEfzV0f8ZKdFZ0Z8P0m8OjJ3Q1/irpU4q5RTUeGPYx03F2R4uC0RpTKheEBLbxkeeqWXQhAmOSdO0WKVQ6RN/+4BMOMKJ9RSoIpcDAaBhw3yqgfzqeHYMsUVSd+EwA1yCTyF5DukZoD/3gQMbSQmekpuH8w6PgnT9G/iVtS/L2RTAI0p6FsjEYiVSl5IB18n3EDnw8jdgBPdbxC9gnwe6ZKdeBMS5ONBBwNnpjDXXij3S8yE0gY2tPQ14MarNhj5lWqy7zxr5jiZ1igi8sMmrFb9zv3Xo34ysE5M1INwA3NgsI4/bPC2saKk0zArh2o4j2PbpHKX8GCi2Afhc5aiwdiHZ9oJ8shpB/rKBTfSP0zHBvgqOJztr7eGbkqWRgHQSQIkFcQRuSt1Ail1Kmrin3AzfmhkPmHo+5bbLzdyeENQJpcs1PYrWByZOutFLzSdjzpJfOOxfRS/uFm4ZozeAO2jS5IlEI6mK4scgn4u2LWPqOLCUSygHhRwzqjAu2vnOOZRJP82yBmi0GERIPhg75Mq1MB0oaIY0dKUBxF09LQoacK8q1uEQm/teiGKLfk0ifMElKepHKmVggLyqWBZVsIGi92ub06BynSvXw0bF/oQ+29kDpY3hiuX8bDP90jX48gonPGQkawphUUDI2UciENOvzuJLXfT4++VxRYABs1KzfujkIyqoLS0gBYMShgCO5WzdthoyDNsDl7llRqK8M4lMzR3VxmXpafiEeMuV0CySLW5LCAX2lWhSbH7jb+dtjJ5D3IbrVoXxNsWeTMPvoE7 uRRu/gDS 9wH++IngO95nOH5i2nyJEX2Fut9FhO3tUVlhU+WlRQXOI5mDd9cstdU3OaxnZ3moBBy61bwm0LkmqycjClVj4ssnQaxq/6XO3HiSYTNxesJcRjMpT0nxebqe8InZLHcP1CdiCuvYQszit0fjNiJ6fw1vauvFclz5HWssUY35n6FcRIdJhmBOmhOtCVz0UBZ5e1UEmqy+eJFdb3bB42vGAMf8Wd64KlxezRJ+SLSYJA7ObkmyFFq97VNiYa/X/VCYU2W8r X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Comparing pointers with TASK_SIZE does not make sense when kernel and userspace overlap. Assume that we are handling user memory access in this case. Reported-by: Alexander Gordeev Signed-off-by: Ilya Leoshkevich --- mm/kmsan/hooks.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/kmsan/hooks.c b/mm/kmsan/hooks.c index 5d6e2dee5692..eafc45f937eb 100644 --- a/mm/kmsan/hooks.c +++ b/mm/kmsan/hooks.c @@ -267,7 +267,8 @@ void kmsan_copy_to_user(void __user *to, const void *from, size_t to_copy, return; ua_flags = user_access_save(); - if ((u64)to < TASK_SIZE) { + if (!IS_ENABLED(CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE) || + (u64)to < TASK_SIZE) { /* This is a user memory access, check it. */ kmsan_internal_check_memory((void *)from, to_copy - left, to, REASON_COPY_TO_USER); -- 2.41.0