From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0CF81C54FB9 for ; Wed, 15 Nov 2023 20:34:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20A418002E; Wed, 15 Nov 2023 15:34:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 170DF80022; Wed, 15 Nov 2023 15:34:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F02D68002E; Wed, 15 Nov 2023 15:34:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id D369A80022 for ; Wed, 15 Nov 2023 15:34:31 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A4468C06FD for ; Wed, 15 Nov 2023 20:34:31 +0000 (UTC) X-FDA: 81461341542.18.B531BF6 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf11.hostedemail.com (Postfix) with ESMTP id 5240140004 for ; Wed, 15 Nov 2023 20:34:29 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=dg4iR7AS; spf=pass (imf11.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1700080469; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VZEQ7DLTQn6OqQgSLo67A6SEZnv9L1qroObhIZ1xXOM=; b=vad/xIgbFkq3dpUDO7j0bP2CxBXriD15C8/5yoWYdzR4yuIx4t9SvI2IBHLspAYkPJiwIl Y3XXBIA5qR/zBzhF1iLG8HxB/hAEIr5wdG5MyMViI31TeSaEH2L3Yjt2/6VPgEVPLSgw7g vx4cXLeq/VnFgGdAjNpTVJ6JSxcC2tQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1700080469; a=rsa-sha256; cv=none; b=G1Ly2YzfaqA77RtcMvQuaibbFKjJ3Gv21KxUuCNHIwYTje9q2Bu/li1NvpkrTDu5+gh98v EzAQZpiYVWBbQQY5pkOqkTBhvKk1TBE4X74Oe2WQIPP9uVSPgd6q5gJImZiAiwaUay49zy hX+KsK62CsJ9K11fTNzC71lBXdeogLI= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=dg4iR7AS; spf=pass (imf11.hostedemail.com: domain of iii@linux.ibm.com designates 148.163.156.1 as permitted sender) smtp.mailfrom=iii@linux.ibm.com; dmarc=pass (policy=none) header.from=ibm.com Received: from pps.filterd (m0353729.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 3AFKRRsu004222; Wed, 15 Nov 2023 20:34:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=pp1; bh=VZEQ7DLTQn6OqQgSLo67A6SEZnv9L1qroObhIZ1xXOM=; b=dg4iR7ASsjMcFxTDwjvCYLnHoVuy1Qfbro7WxLkmXAFPDzrHl4ABKsqJoFUHCQN13fNa 4crhrvYNsY5a5gNUgvU3Q80SlojQtneGOttjR9TnyVOn3GW0/RjYP4rSANttgOSDhJN5 zPM9wHYUrV9roCYmfAa2gHVV+qtuC/UpngdSdmvvL7tYZ42/WH605LRUeEWyTewBxdUh 5OZtujcbrRbCp1vp0JJKB86UoMmJPdc03HVO3vQOoIHf+HULGzOSuv7XlykNVMSmEltT 4hlHpsaQAbXZOA0NP+ZGG6Aajc4AetjSLwVSxETpQUHNtWWMOaPbQQf0yozllcU4mkys rw== Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ud51q05rc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 20:34:22 +0000 Received: from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 3AFKTACg008842; Wed, 15 Nov 2023 20:34:21 GMT Received: from ppma23.wdc07v.mail.ibm.com (5d.69.3da9.ip4.static.sl-reverse.com [169.61.105.93]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3ud51q05r1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 20:34:21 +0000 Received: from pps.filterd (ppma23.wdc07v.mail.ibm.com [127.0.0.1]) by ppma23.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id 3AFKIuv7014594; Wed, 15 Nov 2023 20:34:20 GMT Received: from smtprelay04.fra02v.mail.ibm.com ([9.218.2.228]) by ppma23.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3uaneksvrn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 15 Nov 2023 20:34:20 +0000 Received: from smtpav01.fra02v.mail.ibm.com (smtpav01.fra02v.mail.ibm.com [10.20.54.100]) by smtprelay04.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 3AFKYHqG45417192 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 15 Nov 2023 20:34:17 GMT Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 09B5420043; Wed, 15 Nov 2023 20:34:17 +0000 (GMT) Received: from smtpav01.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id B202D20040; Wed, 15 Nov 2023 20:34:15 +0000 (GMT) Received: from heavy.boeblingen.de.ibm.com (unknown [9.179.9.51]) by smtpav01.fra02v.mail.ibm.com (Postfix) with ESMTP; Wed, 15 Nov 2023 20:34:15 +0000 (GMT) From: Ilya Leoshkevich To: Alexander Gordeev , Alexander Potapenko , Andrew Morton , Christoph Lameter , David Rientjes , Joonsoo Kim , Marco Elver , Masami Hiramatsu , Pekka Enberg , Steven Rostedt , Vasily Gorbik , Vlastimil Babka Cc: Christian Borntraeger , Dmitry Vyukov , Hyeonggon Yoo <42.hyeyoo@gmail.com>, kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Mark Rutland , Roman Gushchin , Sven Schnelle , Ilya Leoshkevich Subject: [PATCH 05/32] kmsan: Fix is_bad_asm_addr() on arches with overlapping address spaces Date: Wed, 15 Nov 2023 21:30:37 +0100 Message-ID: <20231115203401.2495875-6-iii@linux.ibm.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20231115203401.2495875-1-iii@linux.ibm.com> References: <20231115203401.2495875-1-iii@linux.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: NSV7ecFnmhdnhXadJujf6HXFiI7hMP7v X-Proofpoint-GUID: A_uHNzfE3lkD9p6tFW_ky0Alz8aTnTpa X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.987,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-11-15_20,2023-11-15_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 impostorscore=0 phishscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 mlxlogscore=922 mlxscore=0 adultscore=0 malwarescore=0 lowpriorityscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311060000 definitions=main-2311150163 X-Rspamd-Queue-Id: 5240140004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: sck1tu6i78q75j8gojwbmotn7jkdqs3b X-HE-Tag: 1700080469-784483 X-HE-Meta: U2FsdGVkX18IpQ/RlLnEHYMlCXtjLAjtszx/zTzwLw2CsKacrx4cJnw0fO/NpsDTpVRFXoKaqP2Czg2O+aFfTnNzCC8qL48CHwE79USyLZT7w/VTVtfSvqHv6MBC2tKt2Lkyz8HMmZeZRUxu74cUGVZQgoAoGDMV+o9fTB9KHu70W6szDZdatxR92szHdnBguVTHsERLu3B5QKCOKa8shIR4d+eq419g0d5OE5hmJOqJOcoKpP1MZzotE7kpnhmcUlI/Jb4Ps9ZHO2VA6PKV3dCIyrS3jPmEY9JcK5P5n70V6JR2fTX+UV2dQrfXa9IV+8hb6iMdM6QCAsx22iosN/8eKDFl14ceDZzJSfCQBQhpAs7Nlo23MY8pBu4iZ9Bt8DyCbIr+R36jA8f5KD1mYsppdj0rs7o+/9OPSPzFqkcq6vSlRrIHyBnTMdygxZ+OojmijaDHRtO0NLQmib05Z1365DCAHsjZX7dt8vy12Ljl1TNwmCW0tKTytww5RjIvxw76p2WPQaTSYY99fatmMj+qmfRb76Smu3SvgInuTz6M1jmNAOIjbg9cgtyBnQgjh7eTaylltBvPJi6xYqjTtxQkctmenScFgdDL8uR73CSchRnWOeXS9bxo6ydM+G7GyW9+pTA/Sgnwok4veBkZPriFl4IyS45TQDM8x4JwvC7/FjoHZsvUa+MceASq4OqXmnpXpRGH7PFGHJAG9K99y4nG/FKj0QwcRiITS4jarwsbd3A1dd86BBdtxfZyQzftg20Cx7L0Tua2iZRIjbMBiC4NxcDLTx5dWC6zPyBJwcLa/GPD2LUxg8tW49ir2arKqNW+WvfmZy4Ouixuv6Yw8cGTZyhOQKtf6qxhbLijsanUOl4jd0dYD2yJFWFPJFhRMUyv0LuILr5uHzF1sc0LBKiC/atMuW3f3RxVVPTeaYTzL8dCBqbjcuaQNnERr/nz23rK/nRuSpfZD4b+YJA faVzCReU 4+xUUGQZl/u+6spf1qdC7qXufi84s1I4nG2m0qelp1VMtTMFvvK6u577CRFgZV4P7ncz8d6VGYZDVpXODViKoPWGgTMcYBEsLPIQXgwA9MykjOj1eueEpPi8RvU6sxck6zo5RUySxJUR2IMmP0X+m1p0HzSeL0txv68vf6p78bYRod/cirf8xGGlLO5nF1otdn/R+43Q4ic4M5VKzEV/uN1r7mThJ9d4aPETauOKimmijMFW2oN+KQfanekDGwTAd+q/D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Comparing pointers with TASK_SIZE does not make sense when kernel and userspace overlap. Skip the comparison when this is the case. Signed-off-by: Ilya Leoshkevich --- mm/kmsan/instrumentation.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mm/kmsan/instrumentation.c b/mm/kmsan/instrumentation.c index 470b0b4afcc4..8a1bbbc723ab 100644 --- a/mm/kmsan/instrumentation.c +++ b/mm/kmsan/instrumentation.c @@ -20,7 +20,8 @@ static inline bool is_bad_asm_addr(void *addr, uintptr_t size, bool is_store) { - if ((u64)addr < TASK_SIZE) + if (IS_ENABLED(CONFIG_ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE) && + (u64)addr < TASK_SIZE) return true; if (!kmsan_get_metadata(addr, KMSAN_META_SHADOW)) return true; -- 2.41.0