From: Christian Brauner <brauner@kernel.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: Chuck Lever <cel@kernel.org>,
akpm@linux-foundation.org, hughd@google.com, jlayton@redhat.com,
Tavian Barnes <tavianator@tavianator.com>,
Chuck Lever <chuck.lever@oracle.com>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH RFC] libfs: getdents() should return 0 after reaching EOD
Date: Wed, 15 Nov 2023 21:25:51 +0100 [thread overview]
Message-ID: <20231115-formt-siedeln-45b635164d38@brauner> (raw)
In-Reply-To: <20231114175714.GT1957730@ZenIV>
On Tue, Nov 14, 2023 at 05:57:14PM +0000, Al Viro wrote:
> On Tue, Nov 14, 2023 at 06:29:15PM +0100, Christian Brauner wrote:
>
> > I think it's usually best practice to only modify the file->private_data
> > pointer during f_op->open and f_op->close but not override
> > file->private_data once the file is visible to other threads. I think
> > here it might not matter because access to file->private_data is
> > serialized on f_pos_lock and it's not used by anything else.
>
> That is entirely up to filesystem. Warning that use of that library
> helper means that you can't use your ->d_fsdata for anything else - sure,
> but that's it.
Yes, but it's usually easier to reason about if the pointer just changes
during open/close. Nothing I wrote said that it's mandated just so I'm
clear.
next prev parent reply other threads:[~2023-11-15 20:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 15:49 Chuck Lever
2023-11-14 15:56 ` Matthew Wilcox
2023-11-14 16:00 ` Chuck Lever
2023-11-14 17:29 ` Christian Brauner
2023-11-14 17:57 ` Al Viro
2023-11-15 20:25 ` Christian Brauner [this message]
2023-11-14 18:13 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231115-formt-siedeln-45b635164d38@brauner \
--to=brauner@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=hughd@google.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=tavianator@tavianator.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox