From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3712AC4332F for ; Tue, 14 Nov 2023 04:50:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C0FCD6B02AD; Mon, 13 Nov 2023 23:50:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BC0306B02B0; Mon, 13 Nov 2023 23:50:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A88B06B02B1; Mon, 13 Nov 2023 23:50:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 972D26B02AD for ; Mon, 13 Nov 2023 23:50:50 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 6CEDF140966 for ; Tue, 14 Nov 2023 04:50:50 +0000 (UTC) X-FDA: 81455334660.24.D915432 Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf28.hostedemail.com (Postfix) with ESMTP id A2E64C0006 for ; Tue, 14 Nov 2023 04:50:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=n4vR0c22; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf28.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699937448; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gSHaE/1GVg9mC1SVDtWharYt7nYPJBYXesltql5ggN0=; b=qp8ez/uNKGM26Rs15XIkn7poXsVLk8K6E50ITclysG6Vj5+aRIDumYJ9lapCUGAUhqivlS 18GQccD47Ggl9lBESTQCfUEFlz+0L6FQVJPnrl9gJOaIsWlmq6x4QWtVCAsGQOGaZdmycd /Js4u2GyFzA/wwtiO+xeOgFDuWepHuY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=n4vR0c22; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf28.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.174 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699937448; a=rsa-sha256; cv=none; b=1ey5x3qqgoRAlru09X3kXxkA00L7NXLAixfcw+lGm/q1uuuX10Ih/A/RE2yyLW/OzbGF+5 r90b86Fj8FQ7t5mDpbo5N7xUIhkJeGVE8NrDtFGCra8K68lyrEL9FgQ4jIK76nQMTmn0wh bDDwFSvFvi60ooWWHGqwiAvwsmPnGkM= Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1cc0e78ec92so32765965ad.3 for ; Mon, 13 Nov 2023 20:50:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699937447; x=1700542247; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gSHaE/1GVg9mC1SVDtWharYt7nYPJBYXesltql5ggN0=; b=n4vR0c22OQDn6R/RQH5kr/JSUVzHudpdV5HDPT68Qcq8KnkdSF/0wd2LJMpeuIG3Q+ DFOlepZlnmPQ2NaDjWle1c8IcF/PWehtS73OtcnTbDRvi+yLUcTs/OxBVfPm6//k4wY6 mNwmTWsbHi+e96TX5z3DPDQ/YvvMIk75HIYCw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699937447; x=1700542247; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gSHaE/1GVg9mC1SVDtWharYt7nYPJBYXesltql5ggN0=; b=Q7nOTcixTDwkR35YpVSAX0ffNtnGyrk9w0IxF03exsL5a1F/oMEH+vza+Jqd+T8Jcx 86ugzF6EbyJFOo+rpY/zBu/OeaN7q969s+PWP+Qb1CPU5kJReY25nCTvYoccOBl5FDQT 1778C8HMnrWXWYONnVg4D1cz/TOAlTbxpZSOhB2RN1WGDEnW/f1jBboNNmjAg22mP7kZ Acl/o/eji0WB6rLfJLEI2TWHjDlOfdaofmrtTDT1TY1wQEV6J/haSgZef2PxDAOYvmEK 11rO0KzLbD4Ud3mhRqg6SKVN7/joy46R78hqvTV0nRil3QKS4vEYMxRd4U9iqPPctrWP X9AA== X-Gm-Message-State: AOJu0Yye/hpFmPT2iNguz3MD6dfbHbe3Prf5yCIwjhXkqDeaOYfhZj4x IzxjqU3p+oVLIf0w38/yGDR5yA== X-Google-Smtp-Source: AGHT+IF7Byd1ljDiTcsJ0NghEeEEgnKHX0+3r+3s8w6VMPI04pb7VCutEUrPIzMWjcVxqsPNaM8wIg== X-Received: by 2002:a17:902:8b85:b0:1cc:474d:bdf9 with SMTP id ay5-20020a1709028b8500b001cc474dbdf9mr1243778plb.36.1699937447538; Mon, 13 Nov 2023 20:50:47 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id a13-20020a170902b58d00b001c9db5e2929sm4875757pls.93.2023.11.13.20.50.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 20:50:47 -0800 (PST) Date: Mon, 13 Nov 2023 20:50:46 -0800 From: Kees Cook To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH 18/20] mm/slub: remove slab_alloc() and __kmem_cache_alloc_lru() wrappers Message-ID: <202311132048.B3AADC400@keescook> References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-40-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113191340.17482-40-vbabka@suse.cz> X-Rspamd-Queue-Id: A2E64C0006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: mq9p8bptf6933xfpqumwbegoiezh13zx X-HE-Tag: 1699937448-799717 X-HE-Meta: U2FsdGVkX1/rpnsFFpM7DIyOYlZ+3yx9ph+OIgVL9+xh8aenHT/un9/NLNwAF0lKYn5RTLN/am6sCpISEfZG2z4liwz3xHqLgpBNDBvVZ3Y/sVQP8gpwtKGp1cih+cG0rDVcaVyIgO5o6GyLjwOBZK3VxMHRsXEqRHb85K47MUTq7MF+rSN2RiAxp7DIHxkcrcPDK7gDPv819UQfvs0r7GO4nPn6vLS1036GhWV9YhZxDYVKFPiD45LApYiCT86kToKR963LJyAMojemzYN+s3XygVyOxaKOQUmzTzgUWFDlBr0ewj/Kr8ht4y4nI10Sg6oP/OUY+R/FM8jY5TO3gy6B7rwBTZqrz5J3dbVmJyWa33x9yupMeJICewTam9OkutL1ejb5jEMBtse/X5pCmZYcqhBhZVPxSjve3PFiKVW6+qCbzNKp6PRQymrCQIxUF6fSLuTAuvUVcJ/9bXKukfWjtPI21H+wj/ud0pA7qspa+ppUyBTfu0/E/mUis1GE3RlGaCq3kjfRDpNIYaSJq4o9Fw3xd6uaoiyX+LuTQKJ5wIxQaWuTq67t+zOeXzJQEF5Y/pcUAKh5ZBrC8DnisqV4xvEb5knvyYLPPcAvlGp+KfN0Zn7aHl9D4HSlARmpYzQGL0YmIaujfIJNs3AJ+FEDbEjYHIvDDqeU2fEWwgMITlZbsJW1xUmX2BmvQSHLL/XYHCkqs9MdBz4JblHVy9x909X70S79fupMcAlS9oB7BJKYjtUSnKU0heMyy0/2yWJDrU4WAWVKD7bwgYAdV6ddERYkz+WJXxbbihpv8ClyFvzM0T5U9jVvqojDWdgIF0qD9yaIYlaHPrUPZjcFCnYParujR6l5tlvhtIytmYZbnf+jZBRB9Ndrf7WAQpK8D2sDMu8HQKBnS8g+PZ2fW2uAgWtTFAWEefKt9wsB6N5dPvXzkF9Db95F9eTO2cvjjrapONutJUZIgok6MeQ kkT1PlCy Yh46Wt7roF9bqwU7a2yCO0ySMzf0OoS4vKJAgdFnHZhmyOD40GQY62/uACd3sgWnpK2CTKCtfbTqGZ2aaQEqNz7y+p5Iz6t3vkWKEG+tOhagg1WqeXLwg4dLWltb/P/tfshIflm5Hzm5SywLFRbn6PMUaFW8NX//oNk8KSp62fgsZrdA5ODR8j3agz+gAedPiyQf7gu0J0Qgdx7Jl5C3C0Fze9mWACx0wOB7KxxDyNkCUWUzZ2ccgytnEo6t13k1ALLsqHoi9J0TyewVKbnJdKwHMKZeIICzE3MqI57UhFMyWltDsiINM51fy9JFpjhQHII55Lx+RdmhzIVPCcZzYb/2lnvJVLCLG2Dq657N3Q0KmWrct3W3RvUPAE/4DiOoRi3VNA/sIqdc6Euu8QNbacz6VkcIT3s3S14IDdw4EMlcdWkB0YgGwgGaHA+PVh2u1VimC646oSkJxDaI3zi/iOuuO+zSpSs195sUb9UMLtcpNM/n6lFp5u76ZC0B9x87Afrn1PlArh2L4dbqTu/GhmUdQ+g== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 08:13:59PM +0100, Vlastimil Babka wrote: > slab_alloc() is a thin wrapper around slab_alloc_node() with only one > caller. Replace with direct call of slab_alloc_node(). > __kmem_cache_alloc_lru() itself is a thin wrapper with two callers, > so replace it with direct calls of slab_alloc_node() and > trace_kmem_cache_alloc(). I'd have a sense that with 2 callers a wrapper is still useful? > > This also makes sure _RET_IP_ has always the expected value and not > depending on inlining decisions. > > Signed-off-by: Vlastimil Babka > [...] > void *kmem_cache_alloc_node(struct kmem_cache *s, gfp_t gfpflags, int node) > { > - void *ret = slab_alloc_node(s, NULL, gfpflags, node, _RET_IP_, s->object_size); > + void *ret = slab_alloc_node(s, NULL, gfpflags, node, _RET_IP_, > + s->object_size); > Whitespace change here isn't mentioned in the commit log. Regardless: Reviewed-by: Kees Cook -- Kees Cook