From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9247FC4167B for ; Tue, 14 Nov 2023 04:45:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 30B4D6B02A6; Mon, 13 Nov 2023 23:45:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 295E66B02AD; Mon, 13 Nov 2023 23:45:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 10F586B02AE; Mon, 13 Nov 2023 23:45:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 0025C6B02A6 for ; Mon, 13 Nov 2023 23:45:51 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id CB30A809F8 for ; Tue, 14 Nov 2023 04:45:51 +0000 (UTC) X-FDA: 81455322102.19.F765DCF Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by imf23.hostedemail.com (Postfix) with ESMTP id ECBA6140007 for ; Tue, 14 Nov 2023 04:45:49 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=J5lN4O6I; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.176 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699937150; a=rsa-sha256; cv=none; b=kxFtSHL3f4ZAuPMRSJAM38aMRLirVeseAp2zZYKob2gAv8pyXyYtyCDA5ELcXvmtlQBU+K cOO6RqX4SlEA8A0nFKlTxp123V5qne1OEA1UR522opgAAkmEKWG+ft6vmLCteMgzQXe96x fMAIhQmWUcfYOU3BSdvQMvZfoWbwJK4= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=J5lN4O6I; spf=pass (imf23.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.176 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699937150; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZBMZCd1RTYcku4fr+eS/5T5vGEq4PYQLNXmfcgCc7wA=; b=UqPEEm5ZmDBeeyWWsbpX24FtDUg4lYXFvVUaUKp4jHySLAGbwKxytnRxPatHr2+pkixSVp VMskC2lVkc70in+7HhJ2eLMR8bwCs2XUsB4/7fQAFFpeTgWuwOsm6DY0hG94R/aiPDin5T rKeh62b89I7TFNt6KNC/2P4G7FUxSjI= Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-1cc3bb4c307so39933355ad.0 for ; Mon, 13 Nov 2023 20:45:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699937149; x=1700541949; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=ZBMZCd1RTYcku4fr+eS/5T5vGEq4PYQLNXmfcgCc7wA=; b=J5lN4O6IpyKkTIF7gkke19OgUZ+uxj2JIFWv9v96mUqe3uCtX6R+d3jpdVJt5LyAzk bFxpebopqTTv9pIBIO3MQHG2vPdDxURibdTMvbZesGMNtkWgFGCFpRrEJVHR4KWlVIxi NsYshM0ziyEy5Q3NbHMq7j8q+2M9UAK0+DXmI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699937149; x=1700541949; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZBMZCd1RTYcku4fr+eS/5T5vGEq4PYQLNXmfcgCc7wA=; b=FU9j3Eo6f9SYykdrHJcxfcMcDBFE3OCIiZcT1AGi2YH6eN11NRWMNaF1+OYq58YAxh B5S+5bJTp9wWNGtdMDviPsBWE9dTCrNTBNIq9rdK2yPCtBd5H2w97BD6+4kQpcXPfKi0 SNn4YlhcI/0LWLt7Soy//vNatpuLkTUHtCDN77dHGMIr8XK2dQVao/ddzHqMF6z9Sk2K ojFKat3G6x/1rIDOC52DmWXGquLIdU9EKj6kH+LnPnyms2rd4feYc+Nk+lHaUXcM7tdM mQ4r5v6zITsBGpu2GTvUD3oJI8uk0AuJSw/1cu0P9vnuYGpNtdJK4lRCBB/tOzcYpJkC 8AmQ== X-Gm-Message-State: AOJu0YwC2Szkf+VXv7fP2xsA3jbKk4n3hUMFoyqSS5MD/z8uRj+Du1NY hbc+WNXNmWp5QW0kNBXumuE5aw== X-Google-Smtp-Source: AGHT+IEsjAp3cBiJSP3PyvVvmPuSm+aeTJB4FD5LC9ruHOoqYzxrBqIrhGMYXmyQPi4w72yy/WPkjg== X-Received: by 2002:a17:902:8542:b0:1c3:1f0c:fb82 with SMTP id d2-20020a170902854200b001c31f0cfb82mr968412plo.41.1699937148885; Mon, 13 Nov 2023 20:45:48 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id u12-20020a170902b28c00b001c55e13bf2asm4804097plr.283.2023.11.13.20.45.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 20:45:48 -0800 (PST) Date: Mon, 13 Nov 2023 20:45:48 -0800 From: Kees Cook To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH 15/20] mm/slab: move kfree() from slab_common.c to slub.c Message-ID: <202311132045.D84400ED@keescook> References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-37-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113191340.17482-37-vbabka@suse.cz> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: ECBA6140007 X-Stat-Signature: uwhmq1ajzfexi7q3sb4e8sgub4jybmbn X-Rspam-User: X-HE-Tag: 1699937149-469219 X-HE-Meta: U2FsdGVkX19dWRbFhtI6CuLCihWYIvQMbgccvnjxVpakmuWSxVag9fOnjBC6e5lZSTRfofxlAM3z6L0shisI4wlk3RE28Vuad27BfH8VVNNkAHcVdluKWEFzAw6ucrQqQzqE9pR/6IgqslliMhapmlOd0rJD5b2+YQtma6iL8aTlZV+1YCH1J4U46eDMiPYr8O1Aa4SMvvjh02nxawYK3wOv8ApVKLOEiBkd/+GP5eBInEM33c79h5c6fu3xq+hMJp4a+/V69wNAJTF/Y/Xyz8/daokXio+vH+bMUGlGcxLmfBhXy8r0L4RwS06t64cR9HT5/NkD2BgAGITBhS1jNDcYdHiFRWzLBnfveWzMKchMq1ppQowpVimTDg0TaOOmdQlTkl2lOXXhi62GDaT514iYmJSmP2q3vyHEIka7enfTmM5YEuaCMzO5728c9UvfvVCbr393WOXlFOA1qIynEEE2XGVi6cL3cX63h2h8t18YhLxVUAREsVl7rIyzN8x/hFT3o+K/hm2fOsdpjvlXMtbf+l0G+rMmhskkdKaeNFh+BfLR+C29nmQ73MIzPPbF2nov3KcUmDEfbNBTheOrsI7IF3KcO7xs4y8p9hmwkMNujX9tFy/32l5SeBbM9WMP5+0HYIrsVLQr0ru9nB8sqGVUbXUQrNKKupGFzwv7SvwfP4L9epHe2MWvhZTGFhtQe3exG4oHt49DsHQq4q8HQ1QCscJ9OxFg+VHWeMmGQj2mSlc2v9tMMGaamxVYzde0IjYGowN0svfvGc5LsMgTqrovhWKlsk4uyJNKd+bX4wqtNCKae7YaF05Ze23f2buzkWK3xphk8pEsiPu4TjN6jtHZdJJP3jtRNEeRQj4UhXW7KjnoKyMIGw5R1xBlkLbsAe6qmHJ50h3/QCkSrGERtiw4Uh2eccqRWKt8V3g/JiRMpVD+yweZCWDTO5875Kceye5/o8YHZvKlm/ZQOx3 yi9iNHOI tmMMC1tj98VZauM5tkXVzVY1Mjw1GzxGioAg/Nt23Q1tnf5FIFadijQ+6qqBVFMXd7ShP3qMv3pKbDvXTV3vYuJAt2eY9/0yQUvviTjzUajx8n49wVvrCNGrsU86yGzy1HZbpcSLMf/KOgIfoziqdYVbElmzUfbYUpgUt4XNj53MYU+Of31GFShOZvWiUbhZM7I2tSCwTPGI5d88MgZutvIEqpFmc9wD0VvR+cNKUuX4kyu7KsI4aSoB3CF0Iy1Pcw7ybrHaVwraNQVoslKFhNZLKl0pmMrDbOP+a0fcmcjsXA2foIjbLl3HIOnatRnrl17xZDfLDA1j6u4bO/Ck+2T2uBk1aEf+xDNPpVTbbVWYWzI/IeYTv17YOfS0y/0qsq280dzn9RLBL2iIXJb2K7Ul4vMToQ4Zc9g3Z6+ocYgW0CbAL5jOMiR4NTCn4hpsl7dbd2Hrv2/dhyGn+XT8gAJFp3CziNErlpWZM5zqauLEZRdsKEpKqws066h1UFVwoTUpO6bXmDGpPWlrs+/jFyq1lSQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 08:13:56PM +0100, Vlastimil Babka wrote: > This should result in better code. Currently kfree() makes a function > call between compilation units to __kmem_cache_free() which does its own > virt_to_slab(), throwing away the struct slab pointer we already had in > kfree(). Now it can be reused. Additionally kfree() can now inline the > whole SLUB freeing fastpath. > > Also move over free_large_kmalloc() as the only callsites are now in > slub.c, and make it static. > > Signed-off-by: Vlastimil Babka Reviewed-by: Kees Cook -- Kees Cook