From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B88C4332F for ; Tue, 14 Nov 2023 04:42:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CCD0F6B02A2; Mon, 13 Nov 2023 23:42:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C7DDC6B02A4; Mon, 13 Nov 2023 23:42:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B45D96B02A5; Mon, 13 Nov 2023 23:42:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A82016B02A2 for ; Mon, 13 Nov 2023 23:42:54 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 76069120A6B for ; Tue, 14 Nov 2023 04:42:54 +0000 (UTC) X-FDA: 81455314668.11.F229704 Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by imf03.hostedemail.com (Postfix) with ESMTP id 965BE20005 for ; Tue, 14 Nov 2023 04:42:52 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=b4buFKwF; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.175 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699936972; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=sCrSsxjAq1jCq+B2JpsAc9Scn9B6dHAemDj3eFlW1CE=; b=sC5D47YPJDCLlJVjsqiq7aU3hbfLmItUWoAa0+/GijDCCBijhuFMA+LQ8POkXkjvmB2oLr /YXeWoLFKl/XcIdFgykW4A9HqX3Ksjcm58bUNmmmunUy7IFl/Ddmy37h34JK6L58ijOmI+ zRUWbwMBTAkzYbkLNHp3GOTK35uADeQ= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699936972; a=rsa-sha256; cv=none; b=CfzFtK1BchsjPUqFzYZCfCCqNZBFwqKdNLEPAgDE0OO26vanXLlEv9/D1SUkoI+GN4WEZs 1xm+P3JefAdb9OVSAQg5Z2p8vs14V7gIpwf1s5q9zOR18ICvrkNjjyB6VWI2v2a/FmzVX+ NXmW+YzGqv/5BcbyqzrLyohVcszKl4s= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=b4buFKwF; spf=pass (imf03.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.175 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-1cc3bb32b5dso46531735ad.3 for ; Mon, 13 Nov 2023 20:42:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699936971; x=1700541771; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=sCrSsxjAq1jCq+B2JpsAc9Scn9B6dHAemDj3eFlW1CE=; b=b4buFKwFHuuXLgM6hJFR/lAAojlqhqW9y83VcSBOD5nnTBGKc6YTezb2I4NMzAf5pk 8TND/zaO1y3jIPFu1xRPJj0c7smOXXeOQVuRKGL/nYE8X5EoMb9phIWogXusWPzNYivD rgR+EAN5tw/3fHtkWxVLM3+YPxJZj8u9AlJww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699936971; x=1700541771; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sCrSsxjAq1jCq+B2JpsAc9Scn9B6dHAemDj3eFlW1CE=; b=pu7ZMUGUuFNGp6GIzc0UUmn/CESeJJD3z/uSU0Htui4hZ9m24vQZCSdPhkfzAYx/1G /hkyeW0eIzaKGQd9j5XNILzhD1fSM76+GPTKP9Nxg0IMZ/yhintsS2wVcUwPKWfR5u5+ r4jA8CnCeEQ3mdnHpqmv3yza7dSFzwWXET5j5K1MaOrmUnHQzQt7JN1OB6bim50QtnJT JRYKOuYh9oezTgIsoQrQ+sEMUWRcWtqmcuMP+n94FR9ta+2ZrHR/+K8gyCguMieVGGVX Q3EORK4DC7zhGWYuAdNoly4kFSse3cPJWk1j/DtNa17eRsT/ChkIBTiIBvYWNXtNop86 SGdQ== X-Gm-Message-State: AOJu0Yxa4qh5KjkVyVEpE7n2ix6D0JMHQ/5jMo6wFgq3BSsuPm2HtnzQ BpEue0AmVy2kCfErYn5A1ztMCQ== X-Google-Smtp-Source: AGHT+IGdwyQZzmA4/9nwfKzzB4u85s8j9BkjlV/hZKmIfu7UdDuaDJSnLL1zsdTxEYzRzIo24svtGQ== X-Received: by 2002:a17:902:db0d:b0:1cc:4467:a563 with SMTP id m13-20020a170902db0d00b001cc4467a563mr1181743plx.3.1699936971495; Mon, 13 Nov 2023 20:42:51 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id z5-20020a1709027e8500b001b8622c1ad2sm4947830pla.130.2023.11.13.20.42.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 20:42:51 -0800 (PST) Date: Mon, 13 Nov 2023 20:42:50 -0800 From: Kees Cook To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH 12/20] mm/slab: move pre/post-alloc hooks from slab.h to slub.c Message-ID: <202311132042.CA0081D@keescook> References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-34-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113191340.17482-34-vbabka@suse.cz> X-Rspamd-Queue-Id: 965BE20005 X-Rspam-User: X-Stat-Signature: ogi7gueawe9uizrox4ppjb7urcegn99n X-Rspamd-Server: rspam03 X-HE-Tag: 1699936972-386825 X-HE-Meta: U2FsdGVkX19YGlwGkGrQ48i9axBck8Qlkfp6bPY20yjX4NKPK9TKvz8BmrDXCcm3y42h+3Eg1K32URyzrGqOZGKnSPJqzhjUfB6v1AHLY2tImUd6vw7aLWrnNIRIWr95tyYVPbirQMuSs24kpA7fWPzriChctY6XX+6Ooew/fUGD9/c5k1UB7w0jAFbRh2ZRqX3sXBY4VhzDOogq3Z/rG4KQbUS+tjb6H/2VZ/LnmseygQv8l/YimxpqUOEnNw0kazFc567nRixJ/3WdczUDAziPoz4POfiA60fCf6VCnFIY7VT97GMngbZ1pwpefyv5eDFqy8pTcl7MwnWSzJXf17iGyThH7lyMUGBWfdqzJGo1wVyX3Kv6aw2tttZeTg5YwzMk4DKJnUOw142JxqaHuU2kR8iKy/09FBcnKa4SAN4RmMK41G8tiq4VKvu7zoS3LSHIrYyRVkSAGFycMel9LygyKu7MqCCGwCnKZ9A7bjaQ1qXm6li7og5WGqk4oLpxpRIyW8neKUly3OW6VfIt9r2HEU2ck1LUNAGn7c513UYrOI/2d6wlKYUDrhpVXxrl/yE1CJDn/egeu9hw/ILo4XF2bDJZuLLHW9nJ2a/pjTqJbLESOkiLYXgNlp3j6XB8aGCAQVeAiDMXMgxvsdHyrNmvkfyhidKUknKCv7GHxPSj5hQDpfuRaYJLe1rh/nwwH5D3mE4DwlYLxFoRB80pABwoKczl6+HxPf8SWjpT1T7dyx9dpbFVPMM1BtudcxTDcg6Vz3QedK1Ijqg9vI7rjAyp9BfXUJgIoJ67kgNErNd5rfew8g/UHjAGRIkLID6kGK35hEYybzejsX8cuHch11E3wV93ewkksnVVF8MunCaI6Fb0geyt0kUpYEUhn4yrFLL0PniC1R2KGtqwo9XJd1I7TPOBImTJR8oXIdPGkH78sAIxUxt2B1Fg8mLuGlKtWlUm5m/2l3ofdv8a6Xw 3HYYfsBt JLXcsQoUDifJo8CM8hfNKHipso0F64izHLeVrIoM3SPN+xt58LGbJLNiZvLXAzaNVpYuubcqiq74OE77kz11MGIXK9sfplwsYHsCPJOVyUEhSerSHgWvICI49iDTNHorodZiyFEJXYUiIseds9e1UPfNN/9De8olv4b2DWTO9f59h5QboD7VxddZXawyytulGymsb0XtR/xsVwVGrZsCpqouPC9cofZb+u1c8NS3/pALGVTkdtrNpcGjLaBddwjJ4sIkbudeV+i9BF/8rLRFN3GSIg4s2aK+ABayRV/FVTu7LFy/UEe0LRqrO6m1G3+bKu20sraIhgmlFH6HFE4eD+IIniKTLRGGtKODLiwOdXi0B/JczAvTn6J/z3VXVJZbPzL2U80JI2jLSwA+hBqEkql1z/7GaVcf1KH66X01HWrOTqULmDK6UZhrP9Ac6rO7BDfVhq/ZzTr12XYKkxwMUsaM/FbHhiXo7G9Rc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000064, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 08:13:53PM +0100, Vlastimil Babka wrote: > We don't share the hooks between two slab implementations anymore so > they can be moved away from the header. As part of the move, also move > should_failslab() from slab_common.c as the pre_alloc hook uses it. > This means slab.h can stop including fault-inject.h and kmemleak.h. > Fix up some files that were depending on the includes transitively. > > Signed-off-by: Vlastimil Babka Reviewed-by: Kees Cook -- Kees Cook