From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94D6FC4332F for ; Tue, 14 Nov 2023 04:41:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 26C3C6B0274; Mon, 13 Nov 2023 23:41:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 21D556B02A2; Mon, 13 Nov 2023 23:41:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0BE0A6B02A3; Mon, 13 Nov 2023 23:41:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EFE886B0274 for ; Mon, 13 Nov 2023 23:41:36 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C400AC0A33 for ; Tue, 14 Nov 2023 04:41:36 +0000 (UTC) X-FDA: 81455311392.22.73C0D22 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) by imf26.hostedemail.com (Postfix) with ESMTP id E2EA5140005 for ; Tue, 14 Nov 2023 04:41:34 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=QSR9LSlB; spf=pass (imf26.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699936895; a=rsa-sha256; cv=none; b=WJE4PPNIy7jhR6Rc5oyjXLBr79JQNkpiRYK2em+nXvOI82FBjFLY98dK85t0MHUTUYEePs Mtd0tXL/UFqWVcYaleBu4mQz7nV8TJ2U8HS7XAZXKvJSxAo4BBOIeM9LdcDXnTlZXjUvNM xApiSZJwA8YlTyG4VPnwML5pdwN48zs= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=QSR9LSlB; spf=pass (imf26.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.174 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699936895; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=eA82Hdspg/bY+CR7CFpsTdFZp4h7gtZ2SoVDA2UEAEM=; b=pWfhY2d2LHfnM7X/YJGO21MdMN6RNcpgrPUDnflpAxUgdZLK2Nd8ACB/zxJymN2kBDenqn vgv3xmV9xVVBlUHnzOTff4O/IHPazY1pvxYMvkhsA/mwsTBJtVqhvW/lJDXEi+5eLTO6J8 Iqc5lQxx+iRIyFV9USV+0cVmdZucHOI= Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-6b1d1099a84so5232506b3a.1 for ; Mon, 13 Nov 2023 20:41:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699936894; x=1700541694; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=eA82Hdspg/bY+CR7CFpsTdFZp4h7gtZ2SoVDA2UEAEM=; b=QSR9LSlB0Wk8A8pEdY2EBsjJZV3HrMFsHQtsmDiQ+Z7DHr+TRgvYAJTs0t+m4WUTol pu1qtKAVhCXMzmP9xDz3n4W7aJ1aAfr7s0c+WbAurnQa5xK8GBhqjXTVeIwMY33wOq71 A5qsa6fv0eTVzqkwnN0P/Dqb19IaUS4ZRKKUM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699936894; x=1700541694; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=eA82Hdspg/bY+CR7CFpsTdFZp4h7gtZ2SoVDA2UEAEM=; b=J3Tts5pc1U0h+sETLjR40pfaeF3T4dUYcyKC3YCBBa0AVoH7loZ4xBd4oCDpnO/YAm hcnJeorJoUKeZ00wS3Uc3/YuCy3Ta3WgkaFa3t4iyBlDYyqhnRh4jqlTM3yzS+3oplM1 EF69MnOi1oL4cVy+kpszi84jYSpwPhDA3h+W1S/g/VwdSTO1XkUHyx62RJs7PPsFdrFz Y/sgTlU2j/95mPTr2JbhrECpj+gE7ytVNTDEDheauygjPNH5mcETB+aQYe8aH4MWz0U7 RWataI3KdcxcZ43qrGqjU+4Bt+GNPXHDEZamvqnGShhfjP+vbpiGocNDtz8QWxLoQsLr hJZA== X-Gm-Message-State: AOJu0YxZk5GQc3jQgc/3xwFw8Wek9uueqzgZ2O5lhIumlf7uJT7CiKk6 ARexFbmEmysvKc3qiE/Lg4z8Ag== X-Google-Smtp-Source: AGHT+IFUbqnfiVhlSCwWCV5DGdqS5OAFW8uF1N6KtxMGpaKCHywxvsAYJi+LSQYhPHziOoJn8xTdZQ== X-Received: by 2002:a05:6a00:10c8:b0:6b8:a6d6:f51a with SMTP id d8-20020a056a0010c800b006b8a6d6f51amr9811289pfu.31.1699936893812; Mon, 13 Nov 2023 20:41:33 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id b13-20020a056a00114d00b006baa1cf561dsm395221pfm.0.2023.11.13.20.41.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 20:41:33 -0800 (PST) Date: Mon, 13 Nov 2023 20:41:32 -0800 From: Kees Cook To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH 11/20] mm/slab: consolidate includes in the internal mm/slab.h Message-ID: <202311132039.7CC758A@keescook> References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-33-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113191340.17482-33-vbabka@suse.cz> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: E2EA5140005 X-Stat-Signature: pqaen7huqt1jj9gchyaaz7aist1tnnut X-Rspam-User: X-HE-Tag: 1699936894-852002 X-HE-Meta: U2FsdGVkX19OdFDuxko7tcOUodgRTHLOwhYHh6+zeP1tHZ42cI91MoRwyrltLYPz0Dp/hW1c7apEfH47qr08kcYQTQxaTfCsJ95AqAhKGDEVqO31WqYIbQGmlQw9k5h3+h/lDPKqF5phDE/tmCbffCWZtRqfK3x9bK1ocnX3KsyDbeuzm7dlPtnzvwIK7f4+xt7c623E7qYwv1r5UR1Eni1uLM1pA9I9dXBR6GTCsKi+xuzSIah7e8/PY2HlCL98b7Wf1hnrW1U4CkQI5HnYT03UehoOGANmSNGt5k/baCRMqX1v951fmYGPh9scQd9LPt0gRDetUNhMQimVzFbN3V5uwgzI07VxR3Ca2M6BQ9mdRaEVcg2YeW+oAxXm5Stb0c5tI/pjbiJ5i5yTMjK72e3g5mWhXH7dnvlLt6vOUDOcFbLJReoGCVSGo+0Y+D6+WTeriCnPOmZnFg+g39Ji9oCPEPA+sX8dk0Ouq+3WJ27xdlBMBAWibz+D1IOGuZEZDwSl7x6oltEcdufe2EHfWo2iJHwAaau5DVNXLx2VMBwXVsYB1GxmEGWp51PkQOSLuC5MfW83jrgY4rFkgib7aaIyj39AYJqIHqC2Ia4F/zpOIpLVDzQWlxvwWOHreQH0VMKHCsfeOJzlQ7VRXFEaRRLKxNkZorU6oEg/AFOvKfoOKQGzbd+1AD77Yr/9Z0gspmZfkNpPMgt0ejr2jgJzU5EpULOWtM4BqmEzAMB/JaKjR5M2BoCFzzvRA8PQYWQVUJ7idMfFM+72AmT0om8zwvq98A8Uej/6FX9P3GmuwJzpor3JUDb0TggOtpHjtWhUo6NvOM1J0vbSa0YAdDJIeJvoSOIWJZzrJgFd+5a9NcPxsYHqFePaogeP1wzAVh9afpId+EFXwwE/wPVWNZmPFw7URCROOWnfNQleMVMxxqNRncjzvHIJ+RKJF9UrJx300I/FxF4Rn7W1b4tu2MV wEBOrDUl R5E2SGtr7l5TIRMlva1dvM9UB8SCdtI+yTmO9uMDgk9A4ZxSyMu38+/tVgD9g2Jrq/syqXPlck3SfPGoAB1Yn1EiU7rXl+VLTM6rNuoA5eZ68Qo+XWrtco5J2NyNCngKaWcRUIw8c44s0ANdFe51bwb8qq1Du9uNv6LleP2IDI5VPbNtxfuztvEaiVfrlGzIKc5mPR6DXAnIfvehCEUSLmSRjch6vJi2eFS0iDm7METh3WVr6cMaUulTvb5FvbV84UqxDy1iDXjnuwU9TlKj39TX1h+9OCYFA68AnRe7QUBJliY1+tgaXexRmjY2P3mTWRmyLX/rA13bKXcJ1xepwJazpLpaxDCO0uxT6JvCe6+dZCC5LGowW3wTJYxiD9ETjm77EgmYRXy/aEjJ1YdehZOvMBOflyP/qMOgtQBkkL8X24MM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000004, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 08:13:52PM +0100, Vlastimil Babka wrote: > The #include's are scattered at several places of the file, but it does > not seem this is needed to prevent any include loops (anymore?) so > consolidate them at the top. Also move the misplaced kmem_cache_init() > declaration away from the top. > > Signed-off-by: Vlastimil Babka > --- > mm/slab.h | 28 ++++++++++++++-------------- > 1 file changed, 14 insertions(+), 14 deletions(-) > > diff --git a/mm/slab.h b/mm/slab.h > index 6e76216ac74e..c278f8b15251 100644 > --- a/mm/slab.h > +++ b/mm/slab.h > @@ -1,10 +1,22 @@ > /* SPDX-License-Identifier: GPL-2.0 */ > #ifndef MM_SLAB_H > #define MM_SLAB_H > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include I've seen kernel code style in other places ask that includes be organized alphabetically. Is the order here in this order for some particular reason? -- Kees Cook