From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46D2AC4332F for ; Tue, 14 Nov 2023 04:35:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC7E26B029E; Mon, 13 Nov 2023 23:35:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C517C6B029F; Mon, 13 Nov 2023 23:35:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ACB186B02A0; Mon, 13 Nov 2023 23:35:23 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 990F86B029E for ; Mon, 13 Nov 2023 23:35:23 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5B77614068F for ; Tue, 14 Nov 2023 04:35:23 +0000 (UTC) X-FDA: 81455295726.14.5120D18 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf21.hostedemail.com (Postfix) with ESMTP id 98B701C0007 for ; Tue, 14 Nov 2023 04:35:21 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dPRVMa3u; spf=pass (imf21.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699936521; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2qJn7DbKeJdLYDJu5dncSAZYv48TYbHL51nKAxUFFOc=; b=jeDlBlnBFOco/7T3IRUxSYBUEuilVV2VqlQMki+UOUeL1lmtRD7SlJxZqQCVgC7TUVAsyH tB7RPTulFIfduKlLwyXM+Qryy0lBJ8IwT9AEsLCEciczRn7kykdKCC0Rc4Nf1XQo4EZzxO iSQup/rVPmH07vmgxKWgqtoCzANaHqE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699936521; a=rsa-sha256; cv=none; b=1m7RUE2T8c7Gwz3ZNijoZ6hxWaW4hbp11dSWs6FOHaFNFCA98dsrHUKCHgpf0RJ5e+cwJV p2JX0pkB6XjmOe3LxWpwXS+GrRpEeEgcivq8Mlu68+6GXvn2hjHpSmBZLrAenDZhByXdpu bV53ernFfw2oOecfL2mkNZT6hsCS1wc= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=dPRVMa3u; spf=pass (imf21.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1cc2fc281cdso39221855ad.0 for ; Mon, 13 Nov 2023 20:35:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699936520; x=1700541320; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=2qJn7DbKeJdLYDJu5dncSAZYv48TYbHL51nKAxUFFOc=; b=dPRVMa3uxUKwybvOV+c/2IJW8sKrhrB31Y15uTzb0ZaMoOjDXVEQTxAK3b+9z7FqJ3 sl8gLZXbWTZp8x6Kbel35PCSxvH5T7NfAPwlIDDTYtQH3ognUZDIS6f340PWwWiCc+3m qD0qPxhdQgc6uY0yvgrax2gmPxfknELDk8q80= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699936520; x=1700541320; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=2qJn7DbKeJdLYDJu5dncSAZYv48TYbHL51nKAxUFFOc=; b=ht5U/UwoWbL45J6/W4krmzw/GNViZ5jCfPmdWj7R80+4+BccMSf8zFwbluvnqPUCdb oyMp0Sh1qme+zqIAFVpr5OXJASMAbq5QCf7yYJi1+D/sNIvR1SjfGUFkc7bg+Tdnrj0D aUjvGEOWZrMDe1zERXkMb1inJEYTibjCOs6WEI+WHX2nflTwo7fjl8uOLGNB7HNUqvRY JuHWWpmwD6J6HO0rnHAG0ZcW9SI1ZYVxfjycQ/BXEOi0/E6opNMIp+V5RVJB8aNYa9cp FhfVW3ML7L+iYy2x/7BIXO+5GFNJ3y2kc8Apksgr+X3WIhGU7gJv07mYO466OpyNYE+G QZ0g== X-Gm-Message-State: AOJu0YxWh+v3s4SXPm9+mV77tXgdEBu0cCBzS2SmUxvOBt/hu+hSbAG8 +OR1baGw4SeV9koBfXoHllBdiA== X-Google-Smtp-Source: AGHT+IE2Kxwisuvac82p84jaALXF4xxfKmYC9mDZ5biXrUMK+/x45Z1bswMrDeJnNGtZLpoEhO/6PA== X-Received: by 2002:a17:903:11d1:b0:1cc:6cc7:e29f with SMTP id q17-20020a17090311d100b001cc6cc7e29fmr1410299plh.43.1699936520572; Mon, 13 Nov 2023 20:35:20 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id l18-20020a170903121200b001bf52834696sm4762331plh.207.2023.11.13.20.35.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 20:35:20 -0800 (PST) Date: Mon, 13 Nov 2023 20:35:19 -0800 From: Kees Cook To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH 09/20] mm/slab: move struct kmem_cache_cpu declaration to slub.c Message-ID: <202311132035.A0F72C0F5@keescook> References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-31-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113191340.17482-31-vbabka@suse.cz> X-Rspamd-Queue-Id: 98B701C0007 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: bgopjoiq9w39aapy3snt7j79p4sque7o X-HE-Tag: 1699936521-500681 X-HE-Meta: U2FsdGVkX19wvEksr72IkX4/GY4C15jlNa02V/yDXDSxbkDsjiF1o92KMtiEZnA05dPDW0UapTnUo+HnuH61y0MhDAWB9wK4TkRU0hhsQmfKQ2Q9DNzOJfIy+ROnLY7o9TDXwZut7eQrwQjk0EUcf1RzDoNTQnH2fWsSZEnIsOk9w/PnlaW4NA29tpBtjcVTMpN7sAG6j4rR62/SAfGq6CZWkB3DlBHYXqoL9cj0Sn+UlUC47R45Nc1CwxQ+spcwHmnWrBLOqza7iElCYs5IOy/tY4cjOeOegvW8ttY9QrHJha6KFbjb9MMDizydAkRHSLIrHiqiPIuhLsYBYlUGbfaImBCaOPLRAN3zH6VcZ6ymS7XQ8rPDJC06HOyzJMkEPV0bsR8G1DsQbu2BDS17p2QmjyOMspgajKF+jzDEuBLv48iUUcJSjXlbNqpU9EJpG8FS+axQZkJvtWiqrVbAolBiP+Mc+101zKa7k1HnJK/1GXplWGACATa//4IaTrYo/pcOlIA2ndYdffGtNbNfH9qn856sL2yXQ0lrKD42DAwu2IkJvXk+QEziKSyF1apjXY2mCrKUPBA3S4kjzrs1FsujrKRtq3/T+LAlFxhagV49ZyglOQ+U9hA6FBLrtePUvRWG4UZdIuKmonCMnvCI9eeOWZ7RxPnsfjWCVQ84N6RsF5j5S34rrK3gNOQqmXaKg2yEY3KkrJIBIeT61JrRM951yjKCYsgC4z2eLfV2hOTrzHIyhvthje2+w2FJLahaXny9sG8CwX2IYxW0Q5AEGnLDY+JUVyxHal9muMjsOuWxv+DBUQFJGf/fvjgij6TS7/+HNeb2NVnJjpc072z1FUUpyC4yaHUhPsce8BC2fk1dhdLenKl5IQWGuiJVrsw9BvOj0C+zN2fh+25cImChCyVPD5oQvnskHkfq/fVI8+lR0ImeP6rhSkrKrgLXgq3I2u3nA4Ck6dxinva/e1O 4rrby7SV KXM46Oh7iiDv3+i/eBch7fl1NwvD1765Lz8Ex881uJNDUxW3a/maTQae7PJnXq9f2QrIXmxGhNFJhmr3QB49RjIPKvmnv2cKnBnt6S5CoA0dvBmQWSTPcuZp9aL8fyaahKNiti27ZlyvSD5wDSmOq11dRQbi2TtgBBoYDC0RVg8P0yC7ACGeMvZ9tU8QP+R5duXUtx9Pj6SWX1nUV/p2CFnWsQny6OShsRAxQMbe9HHXBHDZjUnZPd1Fm9oASQM30Z49W9UrsksvaLQbnPkwZ4igdGn4HGT5huWOGN1W0NGlF8NI9cw+KXtd9bj16G1soe1P5o38M+Tt9F2PW8TbZ1ZXAlrcxLYpMCf2VIsP1k2K3NXfTIb2TMhHm8bVGp6Dor/3Fv6gQdmoNR9ewUBfzV1SpZC17s6X5TgtIxb3ID9V5d7K9BQXT5Xb73prOfB9Kc5c2YefudRxx4253Mvb6lUAbYM/wK/8DMXUi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 08:13:50PM +0100, Vlastimil Babka wrote: > Nothing outside SLUB itself accesses the struct kmem_cache_cpu fields so > it does not need to be declared in slub_def.h. This allows also to move > enum stat_item. > > Signed-off-by: Vlastimil Babka Reviewed-by: Kees Cook -- Kees Cook