From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45A0FC4332F for ; Tue, 14 Nov 2023 04:30:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B3EA66B0290; Mon, 13 Nov 2023 23:30:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AEDBE6B0296; Mon, 13 Nov 2023 23:30:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B57C6B0297; Mon, 13 Nov 2023 23:30:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8CF456B0290 for ; Mon, 13 Nov 2023 23:30:17 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 57B66809EC for ; Tue, 14 Nov 2023 04:30:17 +0000 (UTC) X-FDA: 81455282874.26.D5CC01C Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by imf08.hostedemail.com (Postfix) with ESMTP id 78F31160003 for ; Tue, 14 Nov 2023 04:30:15 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=by6EQTMA; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf08.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.52 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699936215; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BVR/Ivq5aw+9huCWfoclhyK6Cz1m1uGsfFPrSjVP+os=; b=oNOmMufLv+d8vfrLzNr35i8FFEMZ88PbrrHRn5TZdlDHUAWFukPfWzILUu48LUSvj1r6sI lEmDQ0gyoB6K/wkolu7q8Mg5rDY86leCVDWzr5t+CQ0U9l/endTRPeueDBDW+tPwX+bspb pJrSdUFUwV7R9HxH85fez89XQrIagac= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=by6EQTMA; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf08.hostedemail.com: domain of keescook@chromium.org designates 209.85.216.52 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699936215; a=rsa-sha256; cv=none; b=tFDcz5/HsETvgvtt2BFP/tb64QGOttx4giKcDL7OLjQ0ZUs4Ft75MFv8ofytfjD0noi1ee lRHbSfF5qnJgph5gl0i0n8mC250o5PzfENMWSzagz3Cr1ULKN4frGe+uAJ9gOOvVYlvD2w rhv+KwZhLo4+O5Om3HznzoXdDBH1GYM= Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-28003daaaa6so4713900a91.0 for ; Mon, 13 Nov 2023 20:30:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699936214; x=1700541014; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=BVR/Ivq5aw+9huCWfoclhyK6Cz1m1uGsfFPrSjVP+os=; b=by6EQTMAY33tc0a6dcpPJCUUNMzigVlL3PtY9zvY+NG5tvtrgvkEhsd8/WTUNa/02n IKtVm7MvBMNhHYpAt1yZZT55wWo9yTOiPN+GEgpV+0+DYXOZ6PVs6t513FKrIAAzB7S6 LCjCQH53dfIVW3U/SXUVEuUtb8w1DhIyX/clE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699936214; x=1700541014; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=BVR/Ivq5aw+9huCWfoclhyK6Cz1m1uGsfFPrSjVP+os=; b=B8whuAo+ilFXTvFj4HpJD5zgV/4AYCc17SJjzMEMU6CTfEt3L3BTbY5FY073H2KXVs 96isJdLBaWgFOmCD2FJnNHGCNw5OhgdhrIydPe6UvNbiluw1IcJWBEMwY+JOSHZEwapq 7x26vJSy0f9ZL/Lg+AyZCluV4atfqGnpKOuXZWFhtMn67Lju8BlFglrFHWol9k/1ZoFj wWGpFuQZVrIF7jDEzxvmxmWQ404Ey3zu758rs9YZt9b+3HPKPI5ASO1VAAF8mdn3ogSr NRz7iaPbbkC1IdVMlRhMBEmzrgv2uEbBGaNJckiZq8kZakDeEsH9Bvl3xjaUmQzxzdc8 2UJQ== X-Gm-Message-State: AOJu0Yyd2w+2GlBB3+ysyIkQdkixCRfHo47mbc9Im0xlb9hTBjEjx0Vc rIC0D8A7BbWNKV931f2Gl7Q2yg== X-Google-Smtp-Source: AGHT+IGHpiRYqf1wnawSvDbbqcUpNVvAlWIHQjTAdYW+tyahOMwSwXjVkxNjFnslO/Q+Xg7jd3gPkg== X-Received: by 2002:a17:90b:1d06:b0:280:2823:6615 with SMTP id on6-20020a17090b1d0600b0028028236615mr8237152pjb.36.1699936214292; Mon, 13 Nov 2023 20:30:14 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id l24-20020a17090aec1800b00280fcbbe774sm4405770pjy.10.2023.11.13.20.30.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 20:30:13 -0800 (PST) Date: Mon, 13 Nov 2023 20:30:13 -0800 From: Kees Cook To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH 06/20] mm/slab: remove CONFIG_SLAB code from slab common code Message-ID: <202311132024.80A0D5D58@keescook> References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-28-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113191340.17482-28-vbabka@suse.cz> X-Rspamd-Queue-Id: 78F31160003 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 8nuo6b1w1cxgtssc1e8adcnym4376yoi X-HE-Tag: 1699936215-211719 X-HE-Meta: U2FsdGVkX1/OolbTT1OucndX/KGJ2M20hG7ZJvwJfoxhopIuROUIAiUgfo979rNL8cKwzIal30TyAuq3D7DcYK6+Fniakl62tnsYKMlwOJ1kalGn8jCAcLNyKsENa5vVP30IGbz4Ort2Qm/EEIuBOJfv8vJJG+b2bT1PEJJW2+Lqvp0VTxHsUsJDbTafEtCPPHqa5/Cp2aOBNN57SGTob26ADyjHt9e7MWd9U4PL8hGltUPXgtbhCczFAb54L2TJlXk2r8A/S1Spel0Kqoq9beyfC7kzobjZslujWdNLEISzllNYjygdTOVvCWOwj0zbiof612T0VHPSmH45Ef61S0Ki0CVqm1kTDMSZ9CQjIIfCNFM+ptmwNYB9b6WXueh+Lx2EHKBi9ZYXta7PSYBW1yWf2vW4Is+8d69NRftlSaGDqynF2NSa+ysnrpVeU4rRmi/cK3se2oRxSwOomtZw6V/VfKz/8rsfsBagX6awImeocJ/ENOywOSeUMq1PInCtRKv0PCX6cniEhQCSVqYMrhE53sqG5OBPTOeuicbz7yMbonn4aHaJ8p7NBDRGM6Z2hidIK7UJ5hUDq3Qobidpwji4WSxKpt4eUFWhnOdHW2xf8nAjrW0Q5ZyJfJPbFFWzPBMfXnWEptl05WEfX1MjpnlUZXDc3MOkZ6zvRKL28mqMN/V19H2I9814SuFpTNpes2YjBlN4qe36gGBQwFyGDwIj6VHIyn/VIry8UTDlQTsIW772o/nBC7x9vtrKVy+RaCUHk+WFJ3qFMahYUBhSnHgndo3UZUdB5ZVMiCzCb11lnQMMQq8EjZ8cTwkccSUMYM4lOIEzX1aRqLHiacxMMRe4InRW1YztVFsxgPVULUnHIdTr2e336sHhhCQt0NLLTCNJpIRRW3pglCKVlGMblUvgpfwYeATlgz6kXv03daIqg0DaH77Y+BVI+MUdfWz9+LuWqeFq5Bs9EYzFy6z Ii9XpdP9 2ltJ5Z29qaaKq/uBGrH1gKNC9kwr3JnG+s0jGWE4GtZe4HIt08mRDEaNV8THN0eOy5GXNKVsDSG20Uo8uWVNB/AaSd8NQ8nSzwsxNBnVyFrIYz5t1wJMvdFKJ29RE+0RPdqW2nOUUR8sAhPU/fIAFEbyl8oOgKW5qt8SlD1YYZciQ2Qc8kzpxH0CDn8RpHEJB58LlB0/l0FuV8PnblJvc8+l5MioRSLceuChRpmqO6b2QOzx0pILYeR8LUesKBqNveHQVm42Ea6w0tcOV3CgWw5FFKZGa6hKYyGQLwUl6Fy6HzJ9LbkEdOTGXCkvEEWFnA13N3+q2BJEPMCxrbkLdY0sZKiPCeSEg23MvH/jhkUWac3xJfT96trcmK9tfKMdLKHhRMNxjoQHNQwZbXItUw6e+o06fZBmzeecWe09yLV+bYq/QJD9qLkoWLioLVMLIRkRh14h3MU9dEnYn6pvP76l0ArttBps939vskXd3CfNOzAheGbvt/ZW4MkAib3nnHQGs1GBYsuWcbYzScHZ0XjB+QA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 08:13:47PM +0100, Vlastimil Babka wrote: > In slab_common.c and slab.h headers, we can now remove all code behind > CONFIG_SLAB and CONFIG_DEBUG_SLAB ifdefs, and remove all CONFIG_SLUB > ifdefs. > > Signed-off-by: Vlastimil Babka > --- > include/linux/slab.h | 13 +-------- > mm/slab.h | 69 ++++---------------------------------------- > mm/slab_common.c | 22 ++------------ > 3 files changed, 8 insertions(+), 96 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 34e43cddc520..90fb1f0d843a 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -24,7 +24,6 @@ > > /* > * Flags to pass to kmem_cache_create(). > - * The ones marked DEBUG are only valid if CONFIG_DEBUG_SLAB is set. I think this comment was wrong, yes? i.e. the "DEBUG" flags are also used in SLUB? Regardless: Reviewed-by: Kees Cook -- Kees Cook