From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84A21C4332F for ; Tue, 14 Nov 2023 04:11:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDA706B0281; Mon, 13 Nov 2023 23:11:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8BD36B0285; Mon, 13 Nov 2023 23:11:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D514E6B0286; Mon, 13 Nov 2023 23:11:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C3A486B0281 for ; Mon, 13 Nov 2023 23:11:45 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9061A80127 for ; Tue, 14 Nov 2023 04:11:45 +0000 (UTC) X-FDA: 81455236170.11.581AC44 Received: from mail-oi1-f169.google.com (mail-oi1-f169.google.com [209.85.167.169]) by imf04.hostedemail.com (Postfix) with ESMTP id C6BCD40017 for ; Tue, 14 Nov 2023 04:11:43 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ESs68DFA; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf04.hostedemail.com: domain of keescook@chromium.org designates 209.85.167.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699935103; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n+4yq4rGlFBGUUVelo6loa8LJ3whEhAhDSYlb9+Og4U=; b=2gLtqSmme85XYk63jRo1bb1cOS/vaFqXfgI47UXwjPlRlrIZyA3PFmm2kGODpnfuLSRdix xEZR4gjVTEkIdA0ZDZlZ2T25d1Q5UayG2k5y5dYw39Ws7qZV6zbgkrbNG+gf+Z6yM7B1su FCia/ou5oJ2x1IhvwAODfcZfbQyqq8I= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=ESs68DFA; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf04.hostedemail.com: domain of keescook@chromium.org designates 209.85.167.169 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699935103; a=rsa-sha256; cv=none; b=NoknAyZwMxjBsR5Vn4rsTUpBuF1Mk/1pxCciQHuIcckdJixlYg0WjPKmgMy1lfCB3ASFDK T5zNiT90dLCdSVqU5hDqCTbd8f5afmtDnX3BK329l+E8zXQHaI9EAFhGj+5ZX13Kp5tOBG +xv4JNOIhTNd4oknRuIU7rOEEBFAqcE= Received: by mail-oi1-f169.google.com with SMTP id 5614622812f47-3b2f28caab9so3220402b6e.1 for ; Mon, 13 Nov 2023 20:11:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699935103; x=1700539903; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=n+4yq4rGlFBGUUVelo6loa8LJ3whEhAhDSYlb9+Og4U=; b=ESs68DFATSzDEBkIA+6xZKeqR3sF/0pJrTLrbjnlAxaFAlHzA1Hwe/5K1r1Wb4A5cd OGu1zpIrEGF5afvlYvYswnyZsxxcjCOiDtgz1FoZSGzBlo6U26Q0/aWpoE6th35Mh8sT wXb0/NmqqyiOawg2MyeOfGIlNOw7Wns+PZ+Ps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699935103; x=1700539903; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=n+4yq4rGlFBGUUVelo6loa8LJ3whEhAhDSYlb9+Og4U=; b=wbzbRzq36iXBONTLjBxPx8lEztKp+Of8CmSrMDuktCo5om+ZFVDOap9amVN7pesv47 yIvPoo2OJtY8jt7+c8LcGDGoX5SnrqPf/BYVqS7awwsBX8jtuCHw7Agt5dNYWw+tUK+v kXXPphVzj3y7FGFFugYz/0jggDE5V6YgvjiH6bmjG5udd4eZuUwHhk7MvWpjANzmqusD 0P6pufKS46/C/I9i+8jEgF6WDA1YUefMPk8QZGwC4ROrmBKNG21q8bDFxDrT/Z9SRne6 u+QS+kp12uaEgOJ391SVHrPRieYdU+g4BJs4FmknYycncgaZrsiIaTclDdrnYvKpeG7R Z2yA== X-Gm-Message-State: AOJu0Yzi/UA3ZC/7gh+X9btEFXkb3XUTfrUJLCti/FvjzUGbRVyvSIlc fUdvoCtZ/AI2eSgrsrByMnYNFA== X-Google-Smtp-Source: AGHT+IEfNarlWdnfTnb+4lj9a61ndeE58KtCzt4cIWOf0C0hGaQoDCR9asaBxInqDvXXBZ8V8HT8ig== X-Received: by 2002:a05:6870:b155:b0:1ef:62fc:d51c with SMTP id a21-20020a056870b15500b001ef62fcd51cmr10394447oal.51.1699935102819; Mon, 13 Nov 2023 20:11:42 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id fz10-20020a17090b024a00b00268b439a0cbsm4292411pjb.23.2023.11.13.20.11.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 20:11:42 -0800 (PST) Date: Mon, 13 Nov 2023 20:11:41 -0800 From: Kees Cook To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH 01/20] mm/slab: remove CONFIG_SLAB from all Kconfig and Makefile Message-ID: <202311132009.8329C2F5D@keescook> References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-23-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113191340.17482-23-vbabka@suse.cz> X-Rspam-User: X-Stat-Signature: 4st38mqacdm9t4g1ristmtxcgwckd8c6 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: C6BCD40017 X-HE-Tag: 1699935103-699340 X-HE-Meta: U2FsdGVkX196rgJyHlkLo5FJtVCUipk0EO/0vHbskyPsN9iBc0xbdDT4smXASkftWMfAbLaCXYqdjvMYZXTh8TNLid2Z+NDs2BFkpV/+kTfq2cPdfWuztoILoNiDNoMYwW4NBq6v1u1UTRBtcVBcd0kkbcdGuARGP8ZmBVRwmYJj+e7cVDg1JCruMxJjCnSMoSSJBUZsPjXHWenPSQy3ROG9l0r7yUNHU8EshBZzYJlCK8S437RML5a36KzAjzn+YFNjwfB0GeFnNPSGm1kYarmZrr9NPghOOmmS7EJxOPrPp2LuNyiAFK8x6K9OEDig7AkSAuAccmfimW5skHuJsLE+Y8V3fsbMsybLQmFiaDVAlaR0yCcJODQicsI1/W9WsHmvb9kQVUhAztq39VIISHCPE7uqFCXh50tJTqLh57SvPHcrbVQkwoIRTScPXVKbpYFTGnZYILDJSOQL/jFOUNsx/iAe0auYK1grQXXNN6zwvAtsMEo+q9iIs3lqmLNxFW7IsWnxPlYA5ZzO57fhiMsKTC4mo9jvDvPl+/4YpjLsjttydhNXI+57/8cRnhhPiQE/xFuZLxnM/fsB2YH+Do4oQz2U68HEB2G3aXxFJznKkUIfGrYOx2xTuNDhqyJTDYuy2x7gM8gcqaNyCq2bgtvm0s8Sxb4giEaHmUpHu9FFSJQzNU4EYuylNU0pHBqs6adBSlaUzr2M0JxeJDCwXyEvo15sk4+gvEz6PZ06r1ZD7JdNiqAo84j/Ng7CsErVBAKyC8unZjvxVmh+xFRESZbM49rg0ECmzI9AaF4GuK8vnpNFhKa1ayP7Eqm8vNxwQKTirfvKsEqzXo5CUSOu/2BLB4YA5h8IcpAOoSQJVLVI4thEs7IQTD/edJORdZb8ko5ePlANrtgyJAP7UCDXtMcNFn6w1paB9CxmXpMCLgq3Gi3a0pveJU28WvX321sXvci8gaYHoiltn2oeRgU NgY6zCGq J+uHURYQjhyIU+xegqoMNmQu7Ut1yLlvAfekpXQz1X5ldsZMbJcP1lm92CnxmwGxW7eSkCzaMVFwplkKVEuXgxkam/R3ayZ77kwGPAQzxJToUbu0/fLBWgDZCSGLj5H+FQ7LT1xyd/OMCVx/mZO2wF9G0DxlXydXwvVFa6E7oJGVT9SObYA+53KPYIdLbVJHNEoPZ2w8Ju2sJ0yv3iZCZ2p/4A8jaSwOQsd3YCB5Il1G+QUTNoRnRmaGtoLufgmEGvVM3BhZTk6Y129oECTBjcq1kbIUoe/iNG/eos+hanAO0bgJDkTzUfQ8NpqfyFR7AR+oYBEbkQqjv8l+OreB2iMVZTZ9YoRU+PmdH7+xzqzlJbyZJLRixAI317PcIDGauOuSBB8lcuObQGgar3HxFky64Is9YUIIGV9Xfga/3nxTuVrA7FBfuVXn9W7N97nl0WicUTZ6H5hihfsGmU/dhRlgmGSkU4hGxINRBwafntkxXbpzi10Ch3l9+kpCau4t91YS4mPwIwl4wS7WBpzIjOyRQGg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 08:13:42PM +0100, Vlastimil Babka wrote: > Remove CONFIG_SLAB, CONFIG_DEBUG_SLAB, CONFIG_SLAB_DEPRECATED and > everything in Kconfig files and mm/Makefile that depends on those. Since > SLUB is the only remaining allocator, remove the allocator choice, make > CONFIG_SLUB a "def_bool y" for now and remove all explicit dependencies > on SLUB as it's now always enabled. > > Everything under #ifdef CONFIG_SLAB, and mm/slab.c is now dead code, all > code under #ifdef CONFIG_SLUB is now always compiled. > > Signed-off-by: Vlastimil Babka > [...] > diff --git a/mm/Kconfig b/mm/Kconfig > index 89971a894b60..766aa8f8e553 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -228,47 +228,12 @@ config ZSMALLOC_CHAIN_SIZE > > menu "SLAB allocator options" Should this be "Slab allocator options" ? (I've always understood "slab" to mean the general idea, and "SLAB" to mean the particular implementation. Regardless: Reviewed-by: Kees Cook -- Kees Cook