From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D015C4332F for ; Tue, 14 Nov 2023 04:07:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 895FB6B0280; Mon, 13 Nov 2023 23:07:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81E306B0281; Mon, 13 Nov 2023 23:07:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 670B76B0284; Mon, 13 Nov 2023 23:07:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5104C6B0280 for ; Mon, 13 Nov 2023 23:07:33 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 1E43F802AA for ; Tue, 14 Nov 2023 04:07:33 +0000 (UTC) X-FDA: 81455225586.19.4824B56 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) by imf01.hostedemail.com (Postfix) with ESMTP id 4FC6240004 for ; Tue, 14 Nov 2023 04:07:31 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GwChrd3b; spf=pass (imf01.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699934851; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=KGZDmoEeCuoU4ORpnmk9KfAQBb9nHs+S5VafgrXpLog=; b=RHWRo7iSeBU0j8vsbNeoxVQCYZ1mmHOl08hoJwIlf1TPrWBSZHnMyykhAGUsS6EGqR68+l 7KxuTq6K8gLsGGuqfe5iOQ0lq9jFkxXD8G0QnlHQzBs1t32I4HYKzrjgrbIkpelTYZXmYr ixnoXSgewpxJnmKR43TDEOX6BCSpwEY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699934851; a=rsa-sha256; cv=none; b=Sfmgehp2GeYPspHSCsjcBU7vTATgNUwdNo1YryZ6+A5iijVo0a1UnNR1iBTsExQta/+N9g DnlCjdyFaVvyIdr8GEHqcMV4fmtANqVwYO+mvp7ttSpFf+fX5z57JaWl3n1TPcPvkwGIK7 uxMgxalnJz1I1Dlwwvq1/MVXkVUsvj0= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=GwChrd3b; spf=pass (imf01.hostedemail.com: domain of keescook@chromium.org designates 209.85.210.178 as permitted sender) smtp.mailfrom=keescook@chromium.org; dmarc=pass (policy=none) header.from=chromium.org Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-6c39ad730aaso4049720b3a.0 for ; Mon, 13 Nov 2023 20:07:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699934850; x=1700539650; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=KGZDmoEeCuoU4ORpnmk9KfAQBb9nHs+S5VafgrXpLog=; b=GwChrd3bp5ucd8T7ewzaDU7e68wrERl33r+WMVuoPnnNMJrvjjfIvhkbfP8SSHjv6L MqAvOwo/5GxDVF+cykfKj+HKDf69awD/shljHUc98QVmXZ5WE3VQ/j5PyXPY3JeLoYPb 23qlnjWRIFo6bU6eK7ESY+Mb+Nug68giRQzCc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699934850; x=1700539650; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KGZDmoEeCuoU4ORpnmk9KfAQBb9nHs+S5VafgrXpLog=; b=LiUDrPNKqqCYSHCW0TRmrPxn26xNUpeyXwp82P/1HzbDErafC17zvnnUTsk75koSrB t5ATLkTyRepnPZl7iWIqBmaifOtfgIODNNn6SZdszRvu1jAOR8fhjsaYjxqum5RiLYhD yIBKpbnIZXgD5nJk7yvAv2EMctmS6XUCeico7ymfhBzYeopMx/TV/2HS02iNINQiJ7rf +wkC4/PN72m4STd9FMcKd090h/n+TRipFAXaO7uB2uCLAY+baWiaLnZHJ3CB+U+Q5Mox gKcshZjXDErI3RRW8ssIIe4fJBVRqtIa/xiW1REa5AMCHw/qgnIZd1/WUdzMYyRdRMr9 om8w== X-Gm-Message-State: AOJu0Yy2v8L2lVGDsnJ6kqTlwHGGtbAlulcymFIXTjt+AbsgAlgucolg IqZutLrIw4eMNcN1Tcypc8miLA== X-Google-Smtp-Source: AGHT+IFyU2MADg9EleoYCMTUi5z42Da4Qrzy3K4tyZn3glXnx25v+sXlqweMXpTqFAPp362Amxy4Qg== X-Received: by 2002:a05:6a20:6a04:b0:186:7988:c747 with SMTP id p4-20020a056a206a0400b001867988c747mr4329657pzk.19.1699934850013; Mon, 13 Nov 2023 20:07:30 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id j15-20020a170903024f00b001c62b9a51a4sm4782100plh.239.2023.11.13.20.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 20:07:29 -0800 (PST) Date: Mon, 13 Nov 2023 20:07:28 -0800 From: Kees Cook To: Vlastimil Babka Cc: David Rientjes , Christoph Lameter , Pekka Enberg , Joonsoo Kim , Andrew Morton , Hyeonggon Yoo <42.hyeyoo@gmail.com>, Roman Gushchin , linux-mm@kvack.org, linux-kernel@vger.kernel.org, patches@lists.linux.dev, Andrey Ryabinin , Alexander Potapenko , Andrey Konovalov , Dmitry Vyukov , Vincenzo Frascino , Marco Elver , Johannes Weiner , Michal Hocko , Shakeel Butt , Muchun Song , kasan-dev@googlegroups.com, cgroups@vger.kernel.org Subject: Re: [PATCH 16/20] mm/slab: move kmalloc_slab() to mm/slab.h Message-ID: <202311132006.51222C473@keescook> References: <20231113191340.17482-22-vbabka@suse.cz> <20231113191340.17482-38-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231113191340.17482-38-vbabka@suse.cz> X-Rspamd-Queue-Id: 4FC6240004 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: ccmddepwnumqhrgsmyuq87mcpejbze5n X-HE-Tag: 1699934851-666258 X-HE-Meta: U2FsdGVkX19fbPTBUtFvLqiJ7s1tHOHlG6DhdWIaT6mEvVjXhDwlUeE0rEZ20lQyekhWL14qL8IhyN6Ub/9ow2QUptOUWbHpwrTsjmS9J05vGlUaIoYVU2sQY/f148gqmWwmGIG4C31l5IIL9gPJ8E9Wm9VqetyTPwV1/786wTeZjmEVVDi9B5ey4MQsyFjQYKZg+wtG1uT4i0aoSmoojoj+f9Ng88tYSPlsEOCtCDjwqpxl1B6/n8fvrLC9plYhes5zC846C3oEgbFDqvOShPMy0/RB3/5yT0b+arJu/urvfbGfE33ndYcwCHMrqDw0TwtPb+zRitwP6Gy02ZCC1JH6S4lJhXCFdi/1iZUV2ZEpkSugry8Vjr0k9hAp7K/JCYghe4ESVRBKTJHjoZjrrPdHsalBD47U+8dBKXBslEh+XVMRYeEN2y/HBJ9dCFtgGc4rDr1kRRTCk9D4JYHhdPsEYMkhu/S+vBZPqBRBxiYAgVAhooBjo84agen+/siIpQ9BRk2u3gv9O8yYC5v7EYNZcswkgQwLJPVGAg1kuzyXRlJNsaBNgaAlWN8fuFgP9E4gkNlFbr54oxRfCTcmPnCsg/TKyFqVCgiyuQoXc0cu36Z8jw9tyoUL9z91yfTok+zBjAG5ZDZm0ARb9z4HsUUhZ83+1j+vEksgWAk4V9sb92J5nVcRTiuEaPl++nZKkZMtBrYQOxqs46Utvd+4L2cxy8MEOCFehd5JfT9k60MA8ru1NDHr0l0FoSqTdd0XD9JSDest/WMr1J8q6007Xl3c7ehtY0SsIFuWPAicXebKo80I1gp7CJWDBV/OlBPYceCOdGc0FkXSqxLBg5t92e+Xooy8r+ABr9j1n7kOAQswmZwl0fMOpB+wkHho9CfUgzgLePi4Wtd2RaJVFe0WUQ2zyBu0t8MhtAiq38SyoF6P0xUX2Ae//we7E72B+8GTffS+cJg5F+ZLh3TAN2q O/01Wc+p 5X8CIFQ3WfNmvSA5sfxUm0VC6n4soz5pV80X1ZJcNEOZ0ijIHQ300CcgRSAzKnFE2nLQPGeEigHc+h+Mrc+ZfsM+C/sZgE0aI1WU2iY17/21EXFM+hJSEpQmG5BzwG38pad3TEeKaSfqDUK/3MaCB3SykwGA8Tbt1zv719zXbOHMHZKLrK+4n94wBRiCg4dX7ANYVlPpZ1bANCa8x4FitVlyOsXCKlQllvX3bIuH6V/db1t3bjjX6I8in24oiloWC+R8lszq2f4ihyLLZ3Rrl0uc5gnKHX4gKiWfAlP/OrBzCl7U98qhaKiHzK/SZprhY0naNRtSjkGgYexS1GacZrCEaQUeV4Ikuq8/nvzjgyBbi57SIsQG8ThgV8eL2KZmCQHTiXyq/pto9OJWJYJxR8cJHKl6XBm4Vjdp5WIRJ0/gaEKEFjZEjiXnCTOZV0Sy2ifvAbuAChlxTP3mcrReStWhXJ26QOhNSknxuvXwyFY1gFU67f3tT8WOmRdRT7VYslHqWCQljrjWFRb5z6ZeGaBmiEg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 13, 2023 at 08:13:57PM +0100, Vlastimil Babka wrote: > In preparation for the next patch, move the kmalloc_slab() function to > the header, as it will have callers from two files, and make it inline. > To avoid unnecessary bloat, remove all size checks/warnings from > kmalloc_slab() as they just duplicate those in callers, especially after > recent changes to kmalloc_size_roundup(). We just need to adjust handling > of zero size in __do_kmalloc_node(). Also we can stop handling NULL > result from kmalloc_slab() there as that now cannot happen (unless > called too early during boot). > > The size_index array becomes visible so rename it to a more specific > kmalloc_size_index. > > Signed-off-by: Vlastimil Babka Yeah, removing the redundant size checks does make this nicer to look at. :) Reviewed-by: Kees Cook -- Kees Cook