linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	Matthew Wilcox <willy@infradead.org>,
	David Hildenbrand <david@redhat.com>,
	Sidhartha Kumar <sidhartha.kumar@oracle.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH v2 2/6] mm: memory: use a folio in validate_page_before_insert()
Date: Mon, 13 Nov 2023 23:22:18 +0800	[thread overview]
Message-ID: <20231113152222.3495908-3-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20231113152222.3495908-1-wangkefeng.wang@huawei.com>

Use a folio in validate_page_before_insert() to save two
compound_head() calls.

Reviewed-by: Sidhartha Kumar <sidhartha.kumar@oracle.com>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 mm/memory.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/mm/memory.c b/mm/memory.c
index c32954e16b28..379354b35891 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1841,9 +1841,12 @@ pte_t *__get_locked_pte(struct mm_struct *mm, unsigned long addr,
 
 static int validate_page_before_insert(struct page *page)
 {
-	if (PageAnon(page) || PageSlab(page) || page_has_type(page))
+	struct folio *folio = page_folio(page);
+
+	if (folio_test_anon(folio) || folio_test_slab(folio) ||
+	    page_has_type(page))
 		return -EINVAL;
-	flush_dcache_page(page);
+	flush_dcache_folio(folio);
 	return 0;
 }
 
-- 
2.27.0



  parent reply	other threads:[~2023-11-13 15:41 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-13 15:22 [PATCH v2 0/6] mm: cleanup and use more folio in page fault Kefeng Wang
2023-11-13 15:22 ` [PATCH v2 1/6] mm: ksm: use more folio api in ksm_might_need_to_copy() Kefeng Wang
2023-11-13 15:22 ` Kefeng Wang [this message]
2023-11-13 19:30   ` [PATCH v2 2/6] mm: memory: use a folio in validate_page_before_insert() Vishal Moola
2023-11-13 15:22 ` [PATCH v2 3/6] mm: memory: rename page_copy_prealloc() to folio_prealloc() Kefeng Wang
2023-11-13 19:31   ` Vishal Moola
2023-11-13 15:22 ` [PATCH v2 4/6] mm: memory: use a folio in do_cow_page() Kefeng Wang
2023-11-13 19:51   ` Vishal Moola
2023-11-13 15:22 ` [PATCH v2 5/6] mm: memory: use folio_prealloc() in wp_page_copy() Kefeng Wang
2023-11-13 20:07   ` Vishal Moola
2023-11-13 15:22 ` [PATCH v2 6/6] mm: memory: use folio_prealloc() in do_anonymous_page() Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231113152222.3495908-3-wangkefeng.wang@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=sidhartha.kumar@oracle.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox