From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 593ECC4332F for ; Mon, 13 Nov 2023 17:10:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DFE7A8D0033; Mon, 13 Nov 2023 12:10:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D87A88D002E; Mon, 13 Nov 2023 12:10:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C28628D0033; Mon, 13 Nov 2023 12:10:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id AD5E88D002E for ; Mon, 13 Nov 2023 12:10:13 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 86EAAB4FE3 for ; Mon, 13 Nov 2023 17:10:13 +0000 (UTC) X-FDA: 81453569106.01.4FBC4A8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id A9D351C0006 for ; Mon, 13 Nov 2023 17:10:10 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=c7Fr9WWm; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699895410; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XMY1xf6CHBEmQIcP3QiRSqgCUNBwG2gncMHercLJInc=; b=aDUAc5HoGwdCNGwUq662esvvaEVHv/pWC2FiFtTNgCal9UYvu//QTfLAhjuQgd/NOf801N BYmcBD/nlvxbbueOBA5SojbYlf+THv0HOyHBp+YE3sipddN3hhEX/DK5zjsqJ9hqkaVRaS mJJ+rJYXbG6YWzEvATuRRheDsonINLQ= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=c7Fr9WWm; dmarc=none; spf=pass (imf21.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699895410; a=rsa-sha256; cv=none; b=gYk3ZKtcO3E3LFuUCybt2TeTS1ALL6dr0bYkZgs8Gx0m14b+bG7qSRCRzygNXFbtuq8IvD fVyTEnRmOQz7xI700Q3k+EyDbJwz+QR0A1ZBmedDeqCsyzsC1A/m1bBOI4VyRbqc4aQn7R T1IRPPsFThIKubVYtfvj2mKklESSQX8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 2935760F7D; Mon, 13 Nov 2023 17:10:08 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 89FE5C433C7; Mon, 13 Nov 2023 17:10:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1699895407; bh=eqHMpQjhzX+WcTQDLIe2boEljF6lPYLs8dmLBLyT6Nw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c7Fr9WWmMXEb+kC9ynvrMqHKBPKopBNtpnYOmPPZ5MjYyWeULJS4vHzr0qHRBJ5/0 QpxhqwMOybrvefiip/Dh0TLxqKUi5k7pUnVA9jutrWauFwcuBTq+tagS4Z85101Q94 tCTd5AVEX0pgRybBLkpWx5YcAM+/vz16sAF2WdrE= Date: Mon, 13 Nov 2023 09:10:06 -0800 From: Andrew Morton To: kernel test robot Cc: "Matthew Wilcox (Oracle)" , llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Hannes Reinecke , Luis Chamberlain , Pankaj Raghav , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 3/7] buffer: Fix grow_buffers() for block size > PAGE_SIZE Message-Id: <20231113091006.f9d4de1aaf7ed2f8beef07fb@linux-foundation.org> In-Reply-To: <202311121240.AN8GbAbe-lkp@intel.com> References: <20231109210608.2252323-4-willy@infradead.org> <202311121240.AN8GbAbe-lkp@intel.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A9D351C0006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: rtx9imsesdrksqizc7f3ietiqbzkjscr X-HE-Tag: 1699895410-794887 X-HE-Meta: U2FsdGVkX19X1hpGfPMTGUGC0P72/b01BAApj1qVGh2LgdsDbZM64wGqZ2uVKMdmugU9Q/s73jcueItpW4wI3qINOJhJ5iSl5cMG4Kxylela3uTTEzTFEKXwMZx8aSw4Tz6gOnfaEw5QI8kblv3cWwYm/k6/SvZFISVfhpOnf4DIs2Z5Fc3EHnOi+nrI5mQL1N0W9xwmxe2dQIiBSZnXd8F/RDSFVxiWohsV9cvZ6abTDSF4Z/SDRFkYo4riDkDIUvTw93t+hmPfoqJLjhQLYIWSnmJeFcscK+yR38bfKtJAgMvFpmSp2Y7+kXIDq/tMWcr+smmAAmRqtEJOOTgH9hlXJchso3+aGplELvxdGbHNUpBndFVoqqrXQYGOnlLY4jLlZAntt7/0WCeQouaiKQxH9SMenlvDg3dxS08UJVP5EpyOWfp6PIEbEhZnGxfjG4CkqzflbWZseXhwvCN/CxRnIVi3nA0OuISN+4fNHHeMa8ytXx9TTXA0I2BuRFSPXUV98SSQO/3f3nXi69tmmNh3oGjDjah3KtxrxJ5wsJMfWNFgRIgfuAKT3CS1c2b3WLopjLWeHyoNEMNQil9vhndhZhAnOrzBftwMwi3dc2YlNhno3TRQLWtJWcF2lQqbIZtycc48cCYAM5gXJZ4oS+4LM9gE6ubbs3Y+TDzZRr2WXvOtRuWPc+i1JPrUKaH4jWaNT+4YxJsmYn0YzTuxwgA4VNC/Pek/7J96XfKiBli6HA0iFQjQWfheYmGKnLzLb1/ZDT9A51wbJ1OCt2ZG/OCD7NWsxwDlDu81o8EPmueqTNdmAE2yGhkLv4DHKBX96mIoDaa9U96oZVHV3Bg9SHaEdAzbROvGu10ED9igi53WFeinID3BzFHpQq1uUrpFQfOrKz5d655QyTJsQgTJG4aQjCf2SeTrYhlKMED0qvkO3oq2DvmN2FZGpWn5zXnkvI4ZQgE+MAMJs75YIE+ Z1VL9ZFZ kdcxOwReLFPvc+WXM0Cf+NWkcrvHZYssQ22cAAvQ1nkYJu9AR1UsR/wvSECXo8TSEHeDP9zUNAmVcUe+kyuHxFy4Sjl5UO8aht6W4H7YOrHbfkkAV0sdPwL3ET99gmCUkRoMkUzxJPuQutMuo+fL65FHV8ui4pphddVEqfeWvtj2+cJ9/ZDoRxqEdVSqwpqetbLFlyV/szuKSAf6mcXQlHFWg6rhT29Wvz+I2t6KlzVlbShiWb+iX1grWJmMjtVbUWBkLQcAVF3Z9k69ilH1RtZh8zTlNbAAWwWKIjVur25QVbWVMYfuESwtnIeKX05D7DImORhrw4nxzR+hK5nMarThIloro0Np9zcd7cdlSlHW/POXctmp8+EixfO4DJb6WI8/Ts62zaQBvCAza0G8FAbJQwX2tEkGwycS9up1RzJqcZxGBTvtOtBvGvxx3mRl3OoYRb3zneeYdAGhF+H2ab7WnO0ffp+RIcqAEJBc6QNhz3N46X0ic0tKd6SOCV00MUdsOb3ooaxb/hVojwA5YIUD0i9OMKAW/LIFp06n9u4mD9SfgYUgBHFlrvA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, 12 Nov 2023 12:52:00 +0800 kernel test robot wrote: > Hi Matthew, > > kernel test robot noticed the following build errors: > > [auto build test ERROR on akpm-mm/mm-everything] > [also build test ERROR on linus/master next-20231110] > [cannot apply to v6.6] > [If your patch is applied to the wrong git tree, kindly drop us a note. > And when submitting patch, we suggest to use '--base' as documented in > https://git-scm.com/docs/git-format-patch#_base_tree_information] > > url: https://github.com/intel-lab-lkp/linux/commits/Matthew-Wilcox-Oracle/buffer-Return-bool-from-grow_dev_folio/20231110-051651 > base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything > patch link: https://lore.kernel.org/r/20231109210608.2252323-4-willy%40infradead.org > patch subject: [PATCH v2 3/7] buffer: Fix grow_buffers() for block size > PAGE_SIZE > config: hexagon-comet_defconfig (https://download.01.org/0day-ci/archive/20231112/202311121240.AN8GbAbe-lkp@intel.com/config) > compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) > reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231112/202311121240.AN8GbAbe-lkp@intel.com/reproduce) > > If you fix the issue in a separate patch/commit (i.e. not just a new version of > the same patch/commit), kindly add following tags > | Reported-by: kernel test robot > | Closes: https://lore.kernel.org/oe-kbuild-all/202311121240.AN8GbAbe-lkp@intel.com/ > > All errors (new ones prefixed by >>): > > >> ld.lld: error: undefined symbol: __muloti4 > >>> referenced by buffer.c > >>> fs/buffer.o:(bdev_getblk) in archive vmlinux.a > >>> referenced by buffer.c > >>> fs/buffer.o:(bdev_getblk) in archive vmlinux.a > What a peculiar compiler. I assume this fixes? --- a/fs/buffer.c~buffer-fix-grow_buffers-for-block-size-page_size-fix +++ a/fs/buffer.c @@ -1099,7 +1099,7 @@ static bool grow_buffers(struct block_de } /* Create a folio with the proper size buffers */ - return grow_dev_folio(bdev, block, pos / PAGE_SIZE, size, gfp); + return grow_dev_folio(bdev, block, pos >> PAGE_SHIFT, size, gfp); } static struct buffer_head * _