From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E5C6FC4332F for ; Mon, 13 Nov 2023 08:24:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4DD116B01A5; Mon, 13 Nov 2023 03:24:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 48DC86B01A6; Mon, 13 Nov 2023 03:24:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37B196B01A7; Mon, 13 Nov 2023 03:24:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 2A02D6B01A5 for ; Mon, 13 Nov 2023 03:24:49 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 03CE740191 for ; Mon, 13 Nov 2023 08:24:48 +0000 (UTC) X-FDA: 81452245098.30.ED0C259 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf25.hostedemail.com (Postfix) with ESMTP id C7EF6A000F for ; Mon, 13 Nov 2023 08:24:46 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=dxfNd7LG; dmarc=none; spf=none (imf25.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699863887; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=li5b6HvrSAtd0lQREMWpvnGSM883ci1Av/YtBmCW+5U=; b=o9TNCi7pcwTK7hMp+a0K9fKX2Geh8iLyQ4Tj3jPnGYq+Mu7sUmn6DdsEAEi3NWaiGEbsSU GDjmHGDVE5AceDWaE3xQQbeRRgi6xIUjzzXURX655hRwp+P9lZIQSQvF9Zjcg4gUX/lanb 2KwydOQVJJvAgL1vqXk2v624a8rKA9c= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=dxfNd7LG; dmarc=none; spf=none (imf25.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699863887; a=rsa-sha256; cv=none; b=hYmG8NnT+70QSluC5aLeNbI67tGxgm/PqUlJyuFMLMoP1rerJL3PynRujRTHoJMNETaKqC +FGDeS3UDzkxhWSnCTVeOTHsbl0KGMc/Ac5DeRhX9zSvK9n4jP2isM8UTrz+c2H2HUhyci 1Ymp8jmgBPHxUZz9zv5b1NhjbANxT9Q= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=li5b6HvrSAtd0lQREMWpvnGSM883ci1Av/YtBmCW+5U=; b=dxfNd7LGxAT0Mlid+sCMoH0Q/+ qqcACWUxRaG8oZvfgWq5TkitzmsxtXvAfR47uagyYe8LiJVDn3CRMeryduiYF+GVCXdhrAZl3/dS4 BLgFrtbHXoJuRVLIMQ7Tdsh4WRd8YWk7GDI5crO1YFIKErDO5xbJJ4TlLhGwPBGvMa+cDx0wa8xZi +ejiYnZONuE6lYX4l9OzT+/bWOtBvD/vreSjw0VgAruOcsEuOAWug3EdwGxM97QKvZDO07ULT1AIC Z2iixbTctZTqJM2XK+9ps/AXFsXYCSmLmvvFpLO6Tc0rNJ8nfWPLGqBHOLV9VT5So8kiyccDGrWCC GFDbfllw==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1r2SFA-001M52-2r; Mon, 13 Nov 2023 08:24:33 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 5FAE4300427; Mon, 13 Nov 2023 09:24:28 +0100 (CET) Date: Mon, 13 Nov 2023 09:24:27 +0100 From: Peter Zijlstra To: "Matthew Wilcox (Oracle)" Cc: Ingo Molnar , Will Deacon , Waiman Long , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chandan Babu R , "Darrick J . Wong" , linux-xfs@vger.kernel.org, Mateusz Guzik Subject: Re: [PATCH v3 1/4] locking: Add rwsem_assert_held() and rwsem_assert_held_write() Message-ID: <20231113082427.GB16138@noisy.programming.kicks-ass.net> References: <20231110204119.3692023-1-willy@infradead.org> <20231110204119.3692023-2-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231110204119.3692023-2-willy@infradead.org> X-Rspamd-Queue-Id: C7EF6A000F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: kzp57chuo8ndj3gkr8n379qbn1bhwskj X-HE-Tag: 1699863886-273605 X-HE-Meta: U2FsdGVkX18VhH6LJaC+lQBhlKe3It+6rDxoaISwMy54m1p0LHHvQ7AnV53MZcA+Iw72PtPIbWrOs9Uw683ephjnNwsDjrFt6f76YNDVN5ca2cY4JSWpZXNzEcTQzur7no+QPBcHLq/uL4O7KGJUvOrA9g5M6oSW5ncUe4/cfAmDIzJPJxzJXKzdSU8ZCfAL8TOtQISLhybwtuoWl0364ojptW8JJwOxMSdy0lG19yJ/8VbNiIJvnhIXskx5ODkomEWXZbaLiayQeBYPtbgzHKqWcc+wn2oxK8+IMkGRYVgseLZUBLwtrFdXUZi0M5TME5haw0VOkGRYO6+L0cVlX/pqaFQAS0zdkPO1RTsdQSL/tEYU+tISdvqQQ/LR8ctSi9ztHdag1lSBELVZWsnJk4neO4oiy36Empba9KB/JE2sa2+9xgNe1opYstTnMrf82pni5Evq80omc2VnNHRv8CetZ6pz/FaXihlVHqW+L1w9l2bVKEga6KA4MB6DO73TTIaxwX8DQ41ZlZ72ZTzSNGD7U45WvXU82obfxUDxUgXZjHJg3p0J+mfiyt/xma7yky5RCzKAYg49K5Lffg/lXuIgFrcJ2tdFILBBNM3zRkcDZKVtJPXK/4WwXsalCAr8ctEQw7hdDh1SiyqVqebnGfgTrwSEzrx2q1r0tppEwLpNbBkYRihOotfJX+RzD8mvj7yodQg9RXClTT7hR7vtsoK8SN55vweNlF72NltPVs1O86Cv2lfCDepBHqLSfzNbL8f0UzIpKylyEsKpWK3XBXCnHW9Mg4IyHfB0PgfMbEi5hbR5F5nNo0xd4panq8hLyn9PkQokeQWfi+ngqI7Y19HAF0ivu8ToHh/NConTg6iye5AFOy01eX6LvypPjHCvb4SNWMxHb7tbxLFdCtzMNS7BE2Ml7JoxjgR9Dh6sEnn81tdjt1H2dxDDnN/Bt6vHgZJu0wq5PkWZAWvvpHG 0KuqxFGV 26itBjvd9+HKJot6xQk4uWBrB3rKR1aSsHgAzXLzJczFwxEEncxx93j7g2oaD75g1bcFLre+ti6Ux+de9j93Y4nvkIO5Y1mxzSU0q9Pga/i6+/NGVRytxNmdFxZmges6lYGqajUH9QQMgYaxMf2FC/J20R83iQ5178SMIaDmvc+jY4RGXmEXLAD12LMHP/XFu2ETK2p2V3UdzloDSeBrg4P6Gvg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 10, 2023 at 08:41:16PM +0000, Matthew Wilcox (Oracle) wrote: > +static inline void rwsem_assert_held_nolockdep(const struct rw_semaphore *sem) > +{ > + WARN_ON(atomic_long_read(&sem->count) == RWSEM_UNLOCKED_VALUE); > +} > + > +static inline void rwsem_assert_held_write_nolockdep(const struct rw_semaphore *sem) > +{ > + WARN_ON(!(atomic_long_read(&sem->count) & RWSEM_WRITER_LOCKED)); > +} > +static inline void rwsem_assert_held_nolockdep(const struct rw_semaphore *sem) > +{ > + BUG_ON(!rwsem_is_locked(sem)); > +} What's with the WARN_ON() vs BUG_ON() thing?