From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Levi Yun <ppbuk5246@gmail.com>
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Peng Zhang <zhangpeng.00@bytedance.com>
Subject: Re: [PATCH] mpale_tree: remove redundant check on mas_wr_append.
Date: Sun, 12 Nov 2023 10:37:19 -0500 [thread overview]
Message-ID: <20231112153719.63ooidpcb4kgmtco@revolver> (raw)
In-Reply-To: <20231111105455.37917-1-ppbuk5246@gmail.com>
* Levi Yun <ppbuk5246@gmail.com> [231111 05:55]:
> Checking data appending on node is done by
> mas->offsest == end
> which is identical with:
> mas->offset == wr_mas->node_end
>
> Remove redundant check and there shouldn't be functional change.
This was already sent out by Peng.
See http://lists.infradead.org/pipermail/maple-tree/2023-November/003051.html
Thanks,
Liam
>
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
> ---
> lib/maple_tree.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index bb24d84a4922..d16b8e211174 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -4141,9 +4141,6 @@ static inline bool mas_wr_append(struct ma_wr_state *wr_mas,
> if (mt_in_rcu(mas->tree))
> return false;
>
> - if (mas->offset != wr_mas->node_end)
> - return false;
> -
> end = wr_mas->node_end;
> if (mas->offset != end)
> return false;
> --
> 2.41.0
>
prev parent reply other threads:[~2023-11-12 15:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-11 10:54 Levi Yun
2023-11-12 15:37 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231112153719.63ooidpcb4kgmtco@revolver \
--to=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=ppbuk5246@gmail.com \
--cc=zhangpeng.00@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox