From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACB6CC4332F for ; Fri, 10 Nov 2023 18:22:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 476318D00F4; Fri, 10 Nov 2023 13:22:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4260D8D0005; Fri, 10 Nov 2023 13:22:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EDA48D00F4; Fri, 10 Nov 2023 13:22:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 1D5758D0005 for ; Fri, 10 Nov 2023 13:22:47 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id E5AC6B6305 for ; Fri, 10 Nov 2023 18:22:46 +0000 (UTC) X-FDA: 81442865532.01.413ABCC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf23.hostedemail.com (Postfix) with ESMTP id 4F178140015 for ; Fri, 10 Nov 2023 18:22:44 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f3srt1Ly; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699640564; a=rsa-sha256; cv=none; b=G9+I+/GZV8hkHktAlkwY5JluyBcSpdH9waK2yq6WkHOgFl1SExTTao9UuJWy8/o4YBxxDG JhsKUSPy0QdPYIIl+LO2JOdfnPf2hsYghtfLryqI7DGuC+dO6rcb05Wwbf8NCncDSHncfA rutrh7dISc/jmJFgjwxoZ4yzE27uFDo= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f3srt1Ly; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf23.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699640564; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=I3+3SCtjptxvydOT3O5l5m3dSCqa1TupqWQ7Sd3VhDY=; b=jNyMD2g1zXOoBHODDlQiyhluzKPOYjR9V4A6OwM4QDZhD0We/dlFJD+4BXMGO0Gyrf0NmG w7vmHsaJPH1oE9RQeFhyYuQpQ51wcniALmA2HQxtVRbaZwjwGHGbblUC8IKdtDzeNd7hiz Nm/OakwiVZF8M/aW7HY4jIzGMj7vUhU= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5501D61AA9; Fri, 10 Nov 2023 18:22:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44E36C433B6; Fri, 10 Nov 2023 18:22:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1699640562; bh=dyMQhGcWZjzZfmcqgh0a8rICldiyzNXwXP7ITv8rhaY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f3srt1Ly1o/qDEDNL+eya2zX0xuLm8X12MVvD1EN4K4oxmdjy5mhnx8YSwG3oIFpi pZDyU3qfdYjHiAScVczzHVaZZ6IVVfy7S8Rk+op1NBBQnHRI8p+/viB0b843KLfBKw Tx5S6JgndAXZDVhwScwTbSIEzNFjB1ZIsvvkev8+xPHtLhvhbsJKP3BN/VAASMPI5C lut0Se9SiKS5Pne8TGkJAZ990C1Bd9/6WnjNpIQYs0XBmJgMmITUQfsz8MolLtisVe bu10oMknarSV0RZqDv09k3t8rPfbrYq4dhhyXoleO4yq8Hiv4hDUD5VDpeACozdtwJ EewGbBBiqEjsg== From: SeongJae Park To: Hyeongtak Ji Cc: sj@kernel.org, akpm@linux-foundation.org, damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeongtak Ji Subject: Re: [PATCH] mm/damon/core.c: avoid unintentional filtering out of schemes Date: Fri, 10 Nov 2023 18:22:40 +0000 Message-Id: <20231110182240.65426-1-sj@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <1699594629-3816-1-git-send-email-hyeongtak.ji@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 4F178140015 X-Stat-Signature: bh5cntx6h48f3txx8imaetpaygn4shsa X-HE-Tag: 1699640564-430696 X-HE-Meta: U2FsdGVkX19vO2lz9FTNwFCVSE9r5WbtjNnPxZTm+qpYde/QBAQMbc5LL77+Nu1qhiQFq8VclNdOoVVyQDwS1H8uWZASMKQh8wL2pjbAc6d4khLhlMrRPyjWpW468osORAvq8y1HmjTFTGMs0LbYZGPy7T4w24bb06A7DfL4G3ieMiddw+iW0xcfXdir9rnmx6KfHiPwabq2jep0PqjyVlghhk7HD1NxJCwU1zoEa4PC122hi0lN7CLqMyxnmA+ZJIyYZqHyquZxqrPnU15yg41PuQjDz+cxTtLxJWaix5IYVm+K6Bc0LQTwnEosuy1rfni+CGYqRNY7Lh0EADhDOnpCCJPIUejR3/D86+QgyTV+esYG31j2vP9XzA5a2z68MX6QZwd9sR4ALuUfkrp6PDpZg05bUqJwIvwVrXWiLCzrAMjGNm8a/FesrtODNdzX1CAp1tJkXet8f5v6a9RhO3OXs60+6leF5CpT1Ud71gVjAPWBwHta7BMGTf674++PGnqMDuRpNqQuhj2yKwYYu0Gmby543GxgCc5CfiSM3HMFw5KAhLXQvXDYw9/qSSlm9+y7h8FZX3ZXP5BYia9LxyJJkvmDoGbEMkp3ZGCncHvDs2CnmHhbqCZNA7Hjgl81m95Iiozi0It+9YXSJxBdVdrzRfGStIHceoQ8umIPG/wPu7YjVIYC4qp/GKJlr7C/arM+pmKsBV2Yky+q/pKoylTjiX4DoZESO2ctJOy3568cX/wXbxkdu/tlgPZRGgZj6/qQ+eGIAxUm1k+Rpr9hY0bStwsI1Z0/xvGXXsVcLnYqo/+RkK+9I87auI3mUqwnhb6DC3gBRbmFlDNUtvtNalr6xRHt1buOcHA7Qkf8WnjWAzjIQzITXL80OAjfsDkeRL2kIItWZC4as2AsPPgt3HmjN/PXNwPJIrpzUiroOU1bsXBWDu6i/k2T689b2a6+C6Rb8ehTTMM8cZW6Bpf SK6haxzE wvT1Cxfyp+ILO2l2I51/bWTrMhvfRkd44ALsockMn8jlWZ++u+ZfbhFZlws+shuGnM33w6e06vpqH0DNN8wKrOUS4jJjDBcXE/Dt2jsurSa+hDjSA/a0W3XXxCGKFR7GfWYvIZTPYM5nmsTcJGBHmowfGZhbYpkiZi6JmVPza/2JstC56OaV/uqqrHHEZmP7KCHfn98MIpCROgJd0+o2fkprD6XDjRPGL6XW5BRGoiquujI9Zk53Zjl/sH0gPhZua3lCFwTmpWJB5YAHH214sOz0DajoBf19pe9NPF29IIhXK5JEHw30YSmaohvGFmYkRCB5Sddo5JI1QRB/PLf6sf9nja9rMaqD8r38zHvssjBRvCpfoJonO9U5TuA/KraGt/oZX9Wi6i1Akp171iSd06GQ4OEIIyv9a/VclGi0jpFccNEjWctVS048jnA3L9MpEX+VZPk2qPviq6uVYYib3m8lGP19j0YF6fBEe X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello Hyueongtak, On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji wrote: > The function '__damos_filter_out()' causes DAMON to always filter out > schemes whose filter type is anon or memcg if its matching value is set > to false. > > This commit addresses the issue by ensuring that '__damos_filter_out()' > no longer applies to filters whose type is 'anon' or 'memcg'. Nice catch, thank you! checkpatch.pl shows one warning, though: WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeongtak Ji ' != 'Signed-off-by: Hyeongtak Ji ' > > Signed-off-by: Hyeongtak Ji Reviewed-by: SeongJae Park Thanks, SJ > --- > mm/damon/core.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/damon/core.c b/mm/damon/core.c > index bcd2bd9d6c10..d5ef8945a343 100644 > --- a/mm/damon/core.c > +++ b/mm/damon/core.c > @@ -920,7 +920,7 @@ static bool __damos_filter_out(struct damon_ctx *ctx, struct damon_target *t, > matched = true; > break; > default: > - break; > + return false; > } > > return matched == filter->matching; > -- > 2.7.4 > >