From: "Liam R. Howlett" <Liam.Howlett@Oracle.com>
To: Levi Yun <ppbuk5246@gmail.com>
Cc: maple-tree@lists.infradead.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] maple_tree: change return type of mas_split_final_node as void.
Date: Fri, 10 Nov 2023 10:03:04 -0500 [thread overview]
Message-ID: <20231110150304.hvcrpc2g6badys5v@revolver> (raw)
In-Reply-To: <20231109160821.16248-2-ppbuk5246@gmail.com>
* Levi Yun <ppbuk5246@gmail.com> [231109 11:18]:
> mas_split_final_node always returns true and there is no usage
> for checking return value.
>
> change return type as void.
Thanks for the patch.
>
> Signed-off-by: Levi Yun <ppbuk5246@gmail.com>
Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>
> ---
> lib/maple_tree.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/lib/maple_tree.c b/lib/maple_tree.c
> index bb24d84a4922..9389a631483a 100644
> --- a/lib/maple_tree.c
> +++ b/lib/maple_tree.c
> @@ -3167,7 +3167,7 @@ static inline void mas_destroy_rebalance(struct ma_state *mas, unsigned char end
> * @mas: The maple state
> * @height: The height of the tree in case it's a new root.
> */
> -static inline bool mas_split_final_node(struct maple_subtree_state *mast,
> +static inline void mas_split_final_node(struct maple_subtree_state *mast,
> struct ma_state *mas, int height)
> {
> struct maple_enode *ancestor;
> @@ -3191,7 +3191,6 @@ static inline bool mas_split_final_node(struct maple_subtree_state *mast,
> mast->l->node = ancestor;
> mab_mas_cp(mast->bn, 0, mt_slots[mast->bn->type] - 1, mast->l, true);
> mas->offset = mast->bn->b_end - 1;
> - return true;
> }
>
> /*
> --
> 2.39.2
prev parent reply other threads:[~2023-11-10 15:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 16:08 Levi Yun
2023-11-10 15:03 ` Liam R. Howlett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231110150304.hvcrpc2g6badys5v@revolver \
--to=liam.howlett@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=maple-tree@lists.infradead.org \
--cc=ppbuk5246@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox