From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAEF0C4167D for ; Fri, 10 Nov 2023 18:31:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B9E68D00F6; Fri, 10 Nov 2023 13:31:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 342A88D0005; Fri, 10 Nov 2023 13:31:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 20A6E8D00F6; Fri, 10 Nov 2023 13:31:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 0B2FB8D0005 for ; Fri, 10 Nov 2023 13:31:31 -0500 (EST) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C60C980BF6 for ; Fri, 10 Nov 2023 18:31:30 +0000 (UTC) X-FDA: 81442887540.03.BA80517 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf13.hostedemail.com (Postfix) with ESMTP id AD1F320015 for ; Fri, 10 Nov 2023 18:31:27 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LW65BgWn; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699641088; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=O0OexSZQwoeWQTO5NPjcf9bEZLmnP+biUrE66mIHlnE=; b=F6N8Ni5WEj9bKbtsGfIYlHcF9exux8zZIl5oExSwfN7nAevHyMVgLwcWsKgjwyDhlE1s60 AXO62ODeJp9GIe8RoslTDsiOHj1dlM4JrwQJRwJhXYEsOUk4JKbL0DTGqiBmuxfpQ8H3XB pWCPpxIvuZ2MYE6+g8GpjhmeXKYggQ0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699641088; a=rsa-sha256; cv=none; b=DddMWaCbNq50CvBppGdEKL82heca57PYfP6oaG8EqhllvwZi7JaSg4OqRpbDquMZlxmTHK R7zP3lhSgLXFjUbYdvGv4pkJAIR/m66pam7r9U5JLtFPtaRiHpZm9U0zKPzJXn/UOfCbI4 79Inf7ObkAeBYg3be9RQtactFtYXgVU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=LW65BgWn; spf=pass (imf13.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.73.55 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id DA42CCE1733; Fri, 10 Nov 2023 18:31:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 16845C433BF; Fri, 10 Nov 2023 18:31:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1699641083; bh=hwCvephXkVaTmz22ATWp2p7mlz7+SKurkbCDiuKn4Vo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=LW65BgWnZC7HeHU+pkcCg+T+OR16Z6yZdHaj3NMy3LFgtdfdJhfNlRetWITbmG0Sg yAuSXeDpXHtDAa017hsIv+elgdjy2N5bik8uQvJJTVJnPKFugwhtLuxs7DvkDUqP+G IpwJ9b+R7+6MThAVIAB9+g1OvsDpdK7Wp7X+e/eo= Date: Fri, 10 Nov 2023 10:31:22 -0800 From: Andrew Morton To: SeongJae Park Cc: Hyeongtak Ji , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Hyeongtak Ji Subject: Re: [PATCH] mm/damon/core.c: avoid unintentional filtering out of schemes Message-Id: <20231110103122.21d5fb5f3d60f1f4f5bd143f@linux-foundation.org> In-Reply-To: <20231110182240.65426-1-sj@kernel.org> References: <1699594629-3816-1-git-send-email-hyeongtak.ji@gmail.com> <20231110182240.65426-1-sj@kernel.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: AD1F320015 X-Rspam-User: X-Rspamd-Server: rspam11 X-Stat-Signature: qg7a68fk5fmsi3j3dwdzbdit8bbxgis1 X-HE-Tag: 1699641087-544637 X-HE-Meta: U2FsdGVkX18Irke4do3CSh3kJmuLhn5p/PB6RcrV+DVioBqY4h9GdLRTVTrvV2cVjPUzhYU+adbJ5hIcsYr+nwyd7/23BXHT7lnrY8mV8+ScW4AZqZc62gCXgX/5W6+rHZiuLeRi19qmOdlvoYoKfMClhlN0gLQITVBiUZTelnhlIyYARfD1KNoomL1ucB3OuXVUlAy6XoLGjSr3xDg1hbXlGhtW8L1BF+Xt3DL4d0XoqS+sYYYcaNNttxmSjytJeFtHc9e0Q+2dPxhTbqtfxWTVnwCD2g19+4/cbVogV1CEhKvTCAhC+nlCo+J05q0HghWNWZXIPCxfSbQoJLLC2kwYMNtNYY7uu9sDed59R/5UQDTRKt6ZFJHSEEmnTjj7oZ+QcQ7R8D2NLGfea2VJvpIsf2fZnoUnRPxNpBblY1v8a2nSBRBgS4li8we4VKy+yoTW9dOOVmt6jn+YwnHbKFVKmm0jiCSZfORmMU0aFP7zc5Bb+xeSXTSyzZcuTpzUgk2r1DD7GoMo5qSwKxvGLCXQm2+tvj8gwoNsdAZHpNNjcpOCHNvjstkhyG09kD7AZOJKETZOGdSrXk8zKVS1lqyZuzE03s/FIleR2Jag86O3BtSBci556WJ/CkXGfQWoTuRLuSW1uFSZUwKDddEbWT3a0xuoLASe6wISIMW7MjRSNAYqytu8+2s1Z375iAcDTdu2nze/xrh6t2nk1fwK/RBHDAiIQ9Exwhwe/bgVLUILan5twa4vvQMgCwcF0KE8vtza5VH+MnmSOTY8c/V5EkVUMiAy4sqSOnjiaJeOdk8FI+PpxmaNbPQGN/e0RzykIA0aN6KK7uLtplowtAv621LbGcVWW95cu4vMotGIZCXa5kjQap3vH9sm3hCvz7rqbMXe/ybYfjhbo3Z2HXAsnfoTe5QVZFWVWQ4UvcKulFcYL0i/tGhUQU3VW2ZJ+MCDbTRX8A72LAfK2jwkA+s C5yNDcBZ a326hCA00OLVNJMWaI/Z/ccniUeigZr8Bk3+5Oshw2lBjBP9ke9rDGmVqMpbXjcO0gVFrBYQxws0CebDTNz1uRSuoe/DDN8eLizDon1hbXFM2X4XlHBJXhDyrPuJPnvlNKBL/ZCf0FFbFnGvM4p5aAXqUTjd1l3U7BzG6brq6v1EZjliqMrrXzQz58eQXmHydINPsAynx81c05ohkuiADRt4dWWHR6KjIN/uJQDxMPH8A4zg/4jCddsHArPRcX+EvS2WTt5NbSZ2EqvnpTP399VMyw7IslhyIHoXJ28YST+R/vNsItLjCRzTwZydkYlvEwCvLhFD2dZXHnbOA9dlM0OLzv3QyAsVyc1BTk72TP+P5Dw4tIQ7EcL9eIRTffUOH2yF6vpOfRnpVMWZqAoA2tDsAfrSQ8TWN6UWRuKDCsDHsIFX3hpO7jnyL+QMxl+GT+lV+aJ98wAgsmFzGeYxGi7BYOSZC5vhU78tC61PoLb3L5uiQPj8SJRHgPhCJ4rLTIAqK1ekSKvi3MkA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 10 Nov 2023 18:22:40 +0000 SeongJae Park wrote: > Hello Hyueongtak, > > On Fri, 10 Nov 2023 14:37:09 +0900 Hyeongtak Ji wrote: > > > The function '__damos_filter_out()' causes DAMON to always filter out > > schemes whose filter type is anon or memcg if its matching value is set > > to false. > > > > This commit addresses the issue by ensuring that '__damos_filter_out()' > > no longer applies to filters whose type is 'anon' or 'memcg'. > > Nice catch, thank you! > > checkpatch.pl shows one warning, though: > > WARNING: From:/Signed-off-by: email address mismatch: 'From: Hyeongtak Ji ' != 'Signed-off-by: Hyeongtak Ji ' This can be addressed by including an explicit From: line at start of changelog. Which should we use? > > > > Signed-off-by: Hyeongtak Ji > > Reviewed-by: SeongJae Park I'll add Fixes: ab9bda001b681 ("mm/damon/core: introduce address range type damos filter") Cc: