linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Kefeng Wang <wangkefeng.wang@huawei.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: <linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>,
	Matthew Wilcox <willy@infradead.org>,
	David Hildenbrand <david@redhat.com>,
	Gregory Price <gregory.price@memverge.com>,
	Kefeng Wang <wangkefeng.wang@huawei.com>
Subject: [PATCH v2 3/7] fs/proc/page: respect folio head-page flag placement
Date: Fri, 10 Nov 2023 11:33:20 +0800	[thread overview]
Message-ID: <20231110033324.2455523-4-wangkefeng.wang@huawei.com> (raw)
In-Reply-To: <20231110033324.2455523-1-wangkefeng.wang@huawei.com>

kpageflags reads page-flags directly from the page, even when the
respective flag is only updated on the headpage of a folio.

Since most flags are stored in head flags, make k = folio->flags,
and add new p = page->flags used for per-page flags.

Originally-from: Gregory Price <gregory.price@memverge.com>
Suggested-by: Matthew Wilcox <willy@infradead.org>
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
 fs/proc/page.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/fs/proc/page.c b/fs/proc/page.c
index dcef02471f91..553a7c921cb4 100644
--- a/fs/proc/page.c
+++ b/fs/proc/page.c
@@ -110,8 +110,7 @@ static inline u64 kpf_copy_bit(u64 kflags, int ubit, int kbit)
 u64 stable_page_flags(struct page *page)
 {
 	struct folio *folio;
-	u64 k;
-	u64 u;
+	u64 k, p, u;
 
 	/*
 	 * pseudo flag: KPF_NOPAGE
@@ -121,7 +120,8 @@ u64 stable_page_flags(struct page *page)
 		return 1 << KPF_NOPAGE;
 
 	folio = page_folio(page);
-	k = page->flags;
+	k = folio->flags;
+	p = page->flags;
 	u = 0;
 
 	/*
@@ -202,7 +202,7 @@ u64 stable_page_flags(struct page *page)
 	u |= kpf_copy_bit(k, KPF_MLOCKED,	PG_mlocked);
 
 #ifdef CONFIG_MEMORY_FAILURE
-	u |= kpf_copy_bit(k, KPF_HWPOISON,	PG_hwpoison);
+	u |= kpf_copy_bit(p, KPF_HWPOISON,	PG_hwpoison);
 #endif
 
 #ifdef CONFIG_ARCH_USES_PG_UNCACHED
@@ -211,13 +211,13 @@ u64 stable_page_flags(struct page *page)
 
 	u |= kpf_copy_bit(k, KPF_RESERVED,	PG_reserved);
 	u |= kpf_copy_bit(k, KPF_MAPPEDTODISK,	PG_mappedtodisk);
-	u |= kpf_copy_bit(k, KPF_PRIVATE,	PG_private);
-	u |= kpf_copy_bit(k, KPF_PRIVATE_2,	PG_private_2);
-	u |= kpf_copy_bit(k, KPF_OWNER_PRIVATE,	PG_owner_priv_1);
+	u |= kpf_copy_bit(p, KPF_PRIVATE,	PG_private);
+	u |= kpf_copy_bit(p, KPF_PRIVATE_2,	PG_private_2);
+	u |= kpf_copy_bit(p, KPF_OWNER_PRIVATE,	PG_owner_priv_1);
 	u |= kpf_copy_bit(k, KPF_ARCH,		PG_arch_1);
 #ifdef CONFIG_ARCH_USES_PG_ARCH_X
-	u |= kpf_copy_bit(k, KPF_ARCH_2,	PG_arch_2);
-	u |= kpf_copy_bit(k, KPF_ARCH_3,	PG_arch_3);
+	u |= kpf_copy_bit(p, KPF_ARCH_2,	PG_arch_2);
+	u |= kpf_copy_bit(p, KPF_ARCH_3,	PG_arch_3);
 #endif
 
 	return u;
-- 
2.27.0



  parent reply	other threads:[~2023-11-10  3:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10  3:33 [PATCH v2 0/7] mm: remove page idle and young wrapper Kefeng Wang
2023-11-10  3:33 ` [PATCH v2 1/7] fs/proc/page: remove unneeded PageTail && PageSlab check Kefeng Wang
2023-11-10 18:11   ` Matthew Wilcox
2023-11-10  3:33 ` [PATCH v2 2/7] fs/proc/page: use a folio in stable_page_flags() Kefeng Wang
2023-11-10 18:15   ` Matthew Wilcox
2023-11-11  3:21     ` Kefeng Wang
2023-11-10 21:50   ` Gregory Price
2023-11-10  3:33 ` Kefeng Wang [this message]
2023-11-10 18:19   ` [PATCH v2 3/7] fs/proc/page: respect folio head-page flag placement Matthew Wilcox
2023-11-11  9:49     ` Kefeng Wang
2023-11-10  3:33 ` [PATCH v2 4/7] mm: huge_memory: use more folio api in __split_huge_page_tail() Kefeng Wang
2023-11-10 18:20   ` Matthew Wilcox
2023-11-11 10:00     ` Kefeng Wang
2023-11-10  3:33 ` [PATCH v2 5/7] mm: task_mmu: use a folio in smaps_account() Kefeng Wang
2023-11-10 18:29   ` Matthew Wilcox
2023-11-11 10:57     ` Kefeng Wang
2023-11-10  3:33 ` [PATCH v2 6/7] mm: task_mmu: use a folio in clear_refs_pte_range() Kefeng Wang
2023-11-10  3:33 ` [PATCH v2 7/7] page_idle: kill page idle and young wrapper Kefeng Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231110033324.2455523-4-wangkefeng.wang@huawei.com \
    --to=wangkefeng.wang@huawei.com \
    --cc=akpm@linux-foundation.org \
    --cc=david@redhat.com \
    --cc=gregory.price@memverge.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox