From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95548C4167B for ; Thu, 9 Nov 2023 05:35:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DB2FA6B02C1; Thu, 9 Nov 2023 00:35:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D62E66B02C2; Thu, 9 Nov 2023 00:35:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C2A996B02C3; Thu, 9 Nov 2023 00:35:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B0A346B02C1 for ; Thu, 9 Nov 2023 00:35:56 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 7997180596 for ; Thu, 9 Nov 2023 05:35:56 +0000 (UTC) X-FDA: 81437304312.11.D7DDED4 Received: from invmail4.hynix.com (exvmail4.skhynix.com [166.125.252.92]) by imf24.hostedemail.com (Postfix) with ESMTP id CC45D18000E for ; Thu, 9 Nov 2023 05:35:53 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699508154; a=rsa-sha256; cv=none; b=Bv4vrD3CRUYtT6QRZJwf+Ey79Y/M+soy75wugTX59/2zu5sWm2mhu0iir3xSRxJE3Zvar5 1MCkYYcsTAqciCgN5naxQMoyF+0aaYaNgj38iOvfcf8ZjUwrX7Xwcq556NfqvVNZCfp+ih BZZYQEhW5XwHY0VOa0KgX1tf3VVxjQU= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of byungchul@sk.com designates 166.125.252.92 as permitted sender) smtp.mailfrom=byungchul@sk.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699508154; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=f4mWZAClpIlOi592QtJwmYyJigMzSb1wxsQOaD1tsag=; b=YJy9ulme1k2do05nJJPvfK6CzoDQNfv8ClKmQFcDKg7BjmxaXmnZNscNz1uNOrPKP0AGrb y1mHHqlNrESYguLd12gJ3OuC35UbBA3g5baUho7KfmJ7gyQdsSMbLiJPKz1MAjUlY+kGRo XMjKaQCP45hwZwWutMOSLuAw7NG53oc= X-AuditID: a67dfc5b-d85ff70000001748-d2-654c6fb5fb50 Date: Thu, 9 Nov 2023 14:35:44 +0900 From: Byungchul Park To: Nadav Amit Cc: Linux Kernel Mailing List , linux-mm , "kernel_team@skhynix.com" , Andrew Morton , "ying.huang@intel.com" , "xhao@linux.alibaba.com" , "mgorman@techsingularity.net" , "hughd@google.com" , "willy@infradead.org" , "david@redhat.com" , "peterz@infradead.org" , Andy Lutomirski , Thomas Gleixner , "mingo@redhat.com" , "bp@alien8.de" , "dave.hansen@linux.intel.com" Subject: Re: [v3 2/3] mm: Defer TLB flush by keeping both src and dst folios at migration Message-ID: <20231109053544.GA75729@system.software.com> References: <20231030072540.38631-1-byungchul@sk.com> <20231030072540.38631-3-byungchul@sk.com> <63C530D3-3A1D-4BE9-8AA7-EFF5B895BE80@vmware.com> <20231030125129.GD81877@system.software.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231030125129.GD81877@system.software.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrFIsWRmVeSWpSXmKPExsXC9ZZnke7WfJ9Ug7fHrS3mrF/DZvF5wz82 ixcb2hktvq7/xWzx9FMfi8XlXXPYLO6t+c9qcX7XWlaLHUv3MVlcOrCAyeL6roeMFsd7DzBZ bN40ldni9w+gujlTrCxOzprM4iDg8b21j8VjwaZSj80rtDwW73nJ5LFpVSebx6ZPk9g93p07 x+5xYsZvFo+dDy095p0M9Hi/7yqbx9Zfdh6fN8l5vJv/li2AL4rLJiU1J7MstUjfLoEro6vf p2AqS8X6k51sDYxLmbsYOTkkBEwkPnQeZYWxZ/Y+YQKxWQRUJE6fW8sGYrMJqEvcuPETrF5E QFHi0P57jCA2s8A7VonvnzRBbGGBaIlPe1+xg9i8AhYSj1u6gWwuDiGBI4wSW+/sYoFICEqc nPmEBaJZS+LGv5dAyziAbGmJ5f84QMKcApYS31ccBpsvKqAscWDbcSaQORICq9glNrXcYoM4 VFLi4IobLBMYBWYhGTsLydhZCGMXMDKvYhTKzCvLTczMMdHLqMzLrNBLzs/dxAiMwWW1f6J3 MH66EHyIUYCDUYmH98Zf71Qh1sSy4srcQ4wSHMxKIrwXTHxShXhTEiurUovy44tKc1KLDzFK c7AoifMafStPERJITyxJzU5NLUgtgskycXBKNTA2vNkyu+WLwlHFQotWrTsB0zzOGx+rjfrm 1VMdGRnuN7l8tX34X6VZzxqd+1akXjzYdOrmDZZLkik5e/u3+8ucOeFw5tD1l9IiUz6wHHoj HtDmkPJE/uD7tNNfmrbuXby/IHuD6JGt/+UWt3JLHnm4YdKPDZZnT2Vf2qWwrr1UyDL/Tvia KTt/K7EUZyQaajEXFScCAOOTmUa9AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsXC5WfdrLs13yfV4M9/BYs569ewWXze8I/N 4sWGdkaLr+t/MVs8/dTHYnF47klWi8u75rBZ3Fvzn9Xi/K61rBY7lu5jsrh0YAGTxfVdDxkt jvceYLLYvGkqs8XvH0B1c6ZYWZycNZnFQdDje2sfi8eCTaUem1doeSze85LJY9OqTjaPTZ8m sXu8O3eO3ePEjN8sHjsfWnrMOxno8X7fVTaPxS8+MHls/WXn8XmTnMe7+W/ZAvijuGxSUnMy y1KL9O0SuDK6+n0KprJUrD/ZydbAuJS5i5GTQ0LARGJm7xMmEJtFQEXi9Lm1bCA2m4C6xI0b P8FqRAQUJQ7tv8cIYjMLvGOV+P5JE8QWFoiW+LT3FTuIzStgIfG4pRvI5uIQEjjCKLH1zi4W iISgxMmZT1ggmrUkbvx7CbSMA8iWllj+jwMkzClgKfF9xWGw+aICyhIHth1nmsDIOwtJ9ywk 3bMQuhcwMq9iFMnMK8tNzMwx1SvOzqjMy6zQS87P3cQIjKhltX8m7mD8ctn9EKMAB6MSD2/C FO9UIdbEsuLK3EOMEhzMSiK8F0x8UoV4UxIrq1KL8uOLSnNSiw8xSnOwKInzeoWnJggJpCeW pGanphakFsFkmTg4pRoYH0zefKA8vfoiO+fG749WLU5jN/f7IjxrReS1kBjhxaLq7qUc7i63 1zfPnz/zqetU55ktm97ray3Z/W+rk1f71C877mneTf59XaCdg+nKwoDnn+S9Yt5OXvF7xZ01 s+aX1nUwXrwnKlL3sHFDOuO/+wYLZ2ZPnb9/wSoD5+1lB0/wrxByu6zK3KvEUpyRaKjFXFSc CAD43uR+pAIAAA== X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: CC45D18000E X-Stat-Signature: ggghkzbog3ptdq9orbp9pqrtgiwce3ar X-HE-Tag: 1699508153-444047 X-HE-Meta: U2FsdGVkX1+ej4wg6liKHMsHrbQYSwu0TnLrfkCIsg37gOAM/W6HdmC4TIJIMrbrEg4sCOWYzL7+LtKkxL5Vhj1/douF37cd475piHiZT80vVhKXJ+QvjILA1pWrTHS0NlOKlYCgV50IMTlGNrwb5Ysam5654gAxCGNeeXlQgm2I13zqZ92zCJh1gCM3RHkSFGeYOjP2YtOSyAax7orbnDBe7msModz2oAmk3yCh/ZuDvxXSEcftFYvfHBrw6EcKD8FmwQr7W1Vm2c5fGHYygZbOMJj/+18YkY9INoDXZXuXoprpH6RJaQAl5KwxnulKlaPA3MufIVu2YOWAfSva56sYLuUBrU2Hf1vb2/NgiUx4dAwMnKIvd9MVjFxZzt8GKwheJAQgphWM5yJrUYljD71GIS/Hu+Cmhsf89UQJUwxR30fKOc7jTB5hfNZoiXgDvCY8znnpgz9taUX0b/nR3XOF33mhy+H4DbNBrk048gQlOrRfNkJMzHOT950q08R8ZDbBPzXUeJ5gQbpuAqbFyPlja0B8GHf+rki3MvFEPtjO05+niJBsHZk0LuwRjQlzO1OYbSrZjYtyqLOtkhS5UgU70YwyxrG4CH6uubivqbrFPOmJRYyonwrGMbDRUGmVaiZmnCt/gkXwWedt08NIzf0AJvjCco/YCYs/TzPjdxGTigse8+2zizkKsbejRaTP77gUMtB229e3XT4ugCUYmB0uiyxLYwSUXqqLzPoZGXGLkIpuOisu0vX1FgEIfQpzBsEfA7XaozxZBBfUPwHpvQ4hd2+2UGN4v0dBYc1B3vdlbNGKHVurzXQIk665BkCHCLstGaDkxSuHfVnyN/QlY8lUF7m3RaOP+l8lPryY1grTjuek1PdOQ4tymnhej6zJVlC+Fyn4bbsQjKJ6uBVW5fy4paruZJdrMIANul0T6fDCk81EbFgT4VhKDoRCiFllWubrZ2w/gw4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Oct 30, 2023 at 09:51:30PM +0900, Byungchul Park wrote: > On Mon, Oct 30, 2023 at 08:50:20AM +0000, Nadav Amit wrote: > > I do not follow the ordering that ensures a migrated page would not > > become writable before the migration is over. Perhaps a comment on what > > guarantees the order would help. IIUC, it'd be safe because unmap is performed first at the beginning of each migration so as to be safe with page fault handlers. So I don't think it should be a concern. Or am I missing something? Byungchul