From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3E8FC4167D for ; Thu, 9 Nov 2023 04:43:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4439E8002C; Wed, 8 Nov 2023 23:43:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 3CBE98D0073; Wed, 8 Nov 2023 23:43:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21E3D8002C; Wed, 8 Nov 2023 23:43:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 0566B8D0073 for ; Wed, 8 Nov 2023 23:43:27 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id C4D3FC06F7 for ; Thu, 9 Nov 2023 04:43:27 +0000 (UTC) X-FDA: 81437172054.10.0F42667 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 147868000B for ; Thu, 9 Nov 2023 04:43:24 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of "SRS0=V+KD=GW=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=V+KD=GW=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699505005; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GXkVGQtWfolpPPwNqktMyuHXsBywgZ4DhHd6g4FbYqU=; b=A919zsAIIYRUU0jPSXQmNvUbK5uVti9cqASNKTotpH+feLpzg1j42PQFvaN3c+kDk1zzS/ +9ppvzFHRhvm9wn0kfSCfBDZPQSwoipWqGwgrT6pyC2GNGxS7H1iZEF4l68JP0dcvVqJL4 1++HNZEsybC0WUqB4l2XP2Hx4spH5ss= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699505005; a=rsa-sha256; cv=none; b=42/C/gZU0F5y/TNCcAIcWFoe+1Ny6pE48JjzW8funBVO4OVb9ZyLs0l/Y2DP4vaoJFM4KI 2PbdIViP3pSHlBW+E6MQueHrjGIB9Znay34RfLm2BRNt0ELGzmkz8uTZPqkn3p6wdUsj4S Ae/vAAJfaos6jjA/ZadiMKKJ9bNXRqE= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of "SRS0=V+KD=GW=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=V+KD=GW=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id C84AC617A7; Thu, 9 Nov 2023 04:43:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C2561C433C7; Thu, 9 Nov 2023 04:43:18 +0000 (UTC) Date: Wed, 8 Nov 2023 23:43:22 -0500 From: Steven Rostedt To: Herbert Xu Cc: Ankur Arora , linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com, "David S. Miller" , Kees Cook , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Graf Subject: Re: [RFC PATCH 71/86] treewide: lib: remove cond_resched() Message-ID: <20231108234322.31980c5f@gandalf.local.home> In-Reply-To: References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107230822.371443-1-ankur.a.arora@oracle.com> <20231107230822.371443-15-ankur.a.arora@oracle.com> <20231108100818.4bc238e7@gandalf.local.home> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: 3k5txqsomeqh53nm53aqzcae8trt7ys1 X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 147868000B X-Rspam-User: X-HE-Tag: 1699505004-213904 X-HE-Meta: U2FsdGVkX1+DclqqIZddR/onn5xvPgX8KYMueZudcAjmgVV6xu3CaWs1lQC8fEAAj5OrE0S9Scc5QB8DAvAvHw7HHNiY19qq7ewYE+7pRBfeWZlICRJyFngh04d3moy7HRPT8/DRgXcL/+2g2GH8Xj/WwdF5aDU0IxacS8l2PcarHMJ5ba1SlyMqIai0cqyi5zwPXOMRa5LZQsirc7s7u7jkEdtoNtncuR7J87aLmqgfKCphGP6nysxdQ4HYUqoEIj4F67o6em5hhoNJHCR8Tc1ie9SHQMZzzIDOQNRRhq7x8ewS9lMSAOPhsdb8QvFSoMko3UeGrsfeJLHCJW7rsfHsQ7M8TExUEJUGcGPVf7ldMKo+1sBNcF+legs6+4EVY1z8hrzzj79ta0G1NHqHzmP16aQU9i/R5mvmpvrdzBTEaiQ5H4M41QR8RPCQTHxIF3SgegacQ5M2bY+DhzofYGHZe7C3M1OrB1feNj1ozxt1At3f5UzTnEhY997jOp7rG1gpltH6y9Mp582HBDq3pbWDrDClVlqwN0yKOJR6y5XASCOdO+Eec4A6m5d2WwKNu2vKZ+VyBrB3YDMlkeSQkz71dsOpNH5ZltG434oPzKK7GbonPOecZpHT7BWMPSnBjNItHGLCHC5bg6EXe36fD8kxwSlprVNVBHMkapXaPTB6icIiw5KLlPzzOK1WZNkAy69j379WFk+8+5TUhnoYYLFJOoB35JshJLTIpqOWFkXaX18y0n6CBz4HFQZ5TiReWTFWGLsMmjyBqUpZ0ms8R3H4mb5ayRbAiwR2Ka407zLuxr6NViBxjna7L4YNBjoiSt3pZobFGJ5XWSyymc+GMABMVK4/J2Uv55t0n/jSy2OW83A9iF1wh6P2Jjkx9AMmxabhjsDu4kU5yPwmGPeScZAorEXfLqgu0rsOwzn5wSJU9Z/HHvphS2lGGB6Qzp2vl3e1mMoFS0stHRF39B/ rndGp1zS 7qzTJnmKkJN3sOsR+rcFyXhWrZT/gNQn6VZx9xs6bzKabJwd+0ab793/s6jTOqGk8JArpHJzhyH07S4mCbj/goFr2u2cepc580+DEzmnpQfEfSuPIf1EUO6jQFrH1+RjATdXCXDVm3CFMHgVbcji3LX+tSeF9MfOxdxa4ehIWAcuEqs1jEkK5HeeBGkxwkmTgKx+UFmzdLqOkxmGB70v6XzjfEcJ0QZ/ug1Rd3JuujQm0wr7JifzREi1HYUkDg0oUkSilOY9sEdmw//IGSEtK1ZTuPkNLiJ0RAsl0tl57S6uL0/uO4XDf3ugmP/WxJzXcR/Gwje3J1X+FL943GcWGUZmx+V2M1pzIVTU+ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 9 Nov 2023 12:19:55 +0800 Herbert Xu wrote: > On Wed, Nov 08, 2023 at 10:08:18AM -0500, Steven Rostedt wrote: > > > > A "Nack" with no commentary is completely useless and borderline offensive. > > Well you just sent me an email out of the blue, with zero context > about what you were doing, and you're complaining to me about giving > your a curt response? First, I didn't send the email, and your "Nack" wasn't directed at me. Second, with lore and lei, it's trivial today to find the cover letter from the message id. But I get it. It's annoying when you have to do that. > > > What is your rationale for the Nack? > > Next time perhaps consider sending the cover letter and the important > patches to everyone rather than the mailing list. Then that is how you should have responded. I see other maintainers respond as such. A "Nack" is still meaningless. You could have responded with: "What is this? And why are you doing it?" Which is a much better and a more meaningful response than a "Nack". > > > The cond_resched() is going away if the patches earlier in the series gets > > implemented. So either it is removed from your code, or it will become a > > nop, and just wasting bits in the source tree. Your choice. > > This is exactly what I should have received. Which is why I replied, as the original email author is still new at this, but is learning. -- Steve