From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45540C4167B for ; Wed, 8 Nov 2023 10:00:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D009080017; Wed, 8 Nov 2023 05:00:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB0DB8D00AD; Wed, 8 Nov 2023 05:00:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9EBC80017; Wed, 8 Nov 2023 05:00:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AAE5E8D00AD for ; Wed, 8 Nov 2023 05:00:50 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 65617140C35 for ; Wed, 8 Nov 2023 10:00:50 +0000 (UTC) X-FDA: 81434343060.20.CBEA0AC Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf28.hostedemail.com (Postfix) with ESMTP id 5433AC002A for ; Wed, 8 Nov 2023 10:00:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=aAsnAcQk; spf=pass (imf28.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699437648; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NhTufKW8b8qhbsPWI8Wwd9u/bwYvYxzYSGLJPVGDB+I=; b=7huSm4d3RX3UMNIIE+VoS+eHg2C4y+dhtTtKV37HNjAc+YPeXfwAdz88dCc8SJBBstcEsl FnSTcYfbEarCG19D5gr9sttGfNRQC2C2yXMCNPej/RjSRTiNjyUwfVCJquO5V2yHRijI7M aHtab6vcClGGkNrV3CFKc32cUZ2wbRw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699437648; a=rsa-sha256; cv=none; b=dnGqzNZUyQ1FXTqGR48KVbytpKtfw+nTp6S9CHhW4kkDGFcmQxC2bWtwsIxegY9tfKyOk3 uEgTWZEsJmdVcVTXw/GiK+NS9Hmah6HcZBNE4o0cXjmV755JFHj+LmpE6RjRVMN+eYlOPF LRBqCvWbTfiv+o7gK/tqWZzACAv0biY= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=linuxfoundation.org header.s=korg header.b=aAsnAcQk; spf=pass (imf28.hostedemail.com: domain of gregkh@linuxfoundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=gregkh@linuxfoundation.org; dmarc=pass (policy=none) header.from=linuxfoundation.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by ams.source.kernel.org (Postfix) with ESMTP id 568F6B81BAE; Wed, 8 Nov 2023 10:00:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D256AC433C8; Wed, 8 Nov 2023 10:00:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1699437645; bh=B+4MKlovPeoqzv47fSzDLSGUQ4Z4sQi7UhIm6VMMyZE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aAsnAcQkri9C2k7tpvk9uHQSWTibyVU0Vt7+XURKEh4uw5YG2SNSI5zvOVtRCEYmz Vmo8QiK97T8gMhDBnC12j2fmp2L633oKeBgRERu738/mrJx3DHTVhLRSRTvE2OGycX lpFvfLUmmTsnT/PlBo+9HXnaOr/xNRJ0ZkucHJK8= Date: Wed, 8 Nov 2023 11:00:42 +0100 From: Greg KH To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org, David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 06/86] Revert "entry: Fix compile error in dynamic_irqentry_exit_cond_resched()" Message-ID: <2023110821-sphere-mandarin-a726@gregkh> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-7-ankur.a.arora@oracle.com> <2023110801-bondless-disregard-795d@gregkh> <87v8acmx1l.fsf@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87v8acmx1l.fsf@oracle.com> X-Rspamd-Queue-Id: 5433AC002A X-Rspam-User: X-Stat-Signature: bhckyabpratcsswqg6e1suthkkobsph5 X-Rspamd-Server: rspam03 X-HE-Tag: 1699437648-967050 X-HE-Meta: U2FsdGVkX1+ltjRH6VtawaYGUbiYrqTQ9YoHJsRQZd1dlovUeAUP9TfCReR0ikuGh+jdZslKTpIb22DRMkYmNlG1+E0yZ6aOzaInrJsX1tar7Zc5WoHwN+WA6MqdaV8ylVzUPTFxJajwpFZxerUOouFhyXseEeyvVb7iSq90TY0+0AkfF0wUAhd1zFW0J2V0WLr8DpKGXlancKs9xmtdy2IpLpo5GmZQUeIkb+qLrX9wY64oI/zIorg35xxtcZAUEcOPiiAlUVk9mp3TYRPml79vpex/v70xa+FYVxe/vQviG7KuvXBF8r7RvExIrXbT+PgO7JGFNcZDkqVW5x/2xH2ZeYbH9pEj7Al7RK6vLfzO7xZJEBaqPPzNpDJ1lcAgRUGm76FzojcMmBd0oHx73fEOh+kK+MbfYfBKyGg6AejpSlCeZ+gSMCsPzxCU84bHtyHs1ED28fqW/PSeGZp0Ln+rg8Rs2FjdVv8GRsHS3zkwrCXX4qQqYqU9lTLbarkmQvQq6QXNkJXYm1cM3arzeSh40QpWlrZViDvu4wiDNFv0QizWpYBbAk/o7XRxp28b0VxF3QEGPwtGIf/XuDAk7UhSz3C+A6VfF0ELK+054LlFHEdNqRC5AXQ1Ojxd5p0Md4WfL7g6aGlYIH4ZqXUypCiMQlmETLlYJ3ITt+DoKsptkt5+42iQUbDkNrtl5DcjXqoWjolk83ssEj5YS0eZ4UiKLbGtz/2stDr0SUaj1I3LKhGK1v5jBCAoA3fOGP4sW4yQqLKmMaep01SvIN94Tl4nU3dcNo3ZGpLVGLIZkhexMLPB2vWcgRKeh4O2+TJ8C6dkfGf4jhzOT1vF7koTz4EimTAJLXH+NJKBosA4akQH5P+kSzXA/rCw9iHTsPp00Su+4lmGXVCf1atW3IDefBBI+koI3qdUyCohEs5gB/PTG6bprdZFG8l4rWLcxEP/83a9i1ZsiD6xRQZTLQU JLEPVJpc kknCstLuPstXtlx+YEpaaiQWevdDFbGseBKkaAjY/bglFUDV63zCTKYi0ZimhePvetWK4fwFfvyN3BocbfKgArBW7XpD0vbEMTAubrQI2hX4NPeHS1jCorxqEpwfaodrUBpWXMCgaMY21K7yXyPdJSnQ83RiETz/7iAcFIJSrMhTpTV0PNjWoHtMz/XHIjMTsr+OhfLDA/2ugP1jG/jrMh1Im5H03h4eeFdItIzdqGzVW8N7bu3JbbTHfPNyqZ6Hyj1QDHHRdlv2m+J78vs4nQx4iWXHeB4kFEHOpcvrpsANzYyJx0yDOIlmWH3AEBfNScQw1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 08, 2023 at 01:09:10AM -0800, Ankur Arora wrote: > > Greg KH writes: > > > On Tue, Nov 07, 2023 at 01:56:52PM -0800, Ankur Arora wrote: > >> This reverts commit 0a70045ed8516dfcff4b5728557e1ef3fd017c53. > >> > > > > None of these reverts say "why" the revert is needed, or why you even > > want to do this at all. Reverting a compilation error feels like you > > are going to be adding a compilation error to the build, which is > > generally considered a bad thing :( > > Yeah, one of the many issues with this string of reverts. > > I was concerned about repeating the same thing over and over enough > that I just put my explanation at the bottom of the cover-letter and > nowhere else. cover letters are not in the changelog when patches are committed :) thanks, greg k-h