From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1C92C4332F for ; Wed, 8 Nov 2023 17:11:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 914848D00BF; Wed, 8 Nov 2023 12:11:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C29B8D0073; Wed, 8 Nov 2023 12:11:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 78BC98D00BF; Wed, 8 Nov 2023 12:11:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 68AE48D0073 for ; Wed, 8 Nov 2023 12:11:48 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 3E630140D9D for ; Wed, 8 Nov 2023 17:11:48 +0000 (UTC) X-FDA: 81435429096.05.F413AC6 Received: from sin.source.kernel.org (sin.source.kernel.org [145.40.73.55]) by imf03.hostedemail.com (Postfix) with ESMTP id 371EC20008 for ; Wed, 8 Nov 2023 17:11:45 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of "SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699463506; a=rsa-sha256; cv=none; b=s5qWC2AXlGY6gjT9Fa3+dfqqZhoduY023V7Cqv5IZmjB3Y4obaoqMe+jsIXxshUhlGDz5U XgoD0gLMkgJlZ+H2U8dC6eOp9DJ59NM/IE92YjebUxMgjxcgjC23RsO24bumU7H5UlmV7Z 6OZNXA9xB52SO7pq5XmPxJVR5GOlFKA= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of "SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" designates 145.40.73.55 as permitted sender) smtp.mailfrom="SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699463506; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=julUklQyxYo8OTPRXkzJBx3/uZCRwIJYa6VZ5lalUak=; b=fcS9Z2wMTrsvMkwrKHXA/sadBw47ECpld/e2zKsriVkQmX+5K3qb0zLICHauP8+Vq0s6ZE 6LDmwecd77J2+g46dXxQ6jPyI3ImqjcHsVuubZkFiS8NSwG1LJXBuwZ/3wJjhQm1UDNx7r +dTy9mMgAKOS61ltOm3Ary5MMMXlc1k= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 7FCD5CE0F27; Wed, 8 Nov 2023 17:11:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDBD6C433C7; Wed, 8 Nov 2023 17:11:35 +0000 (UTC) Date: Wed, 8 Nov 2023 12:11:38 -0500 From: Steven Rostedt To: Eric Dumazet Cc: Ankur Arora , linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com, Marek Lindner , Simon Wunderlich , Antonio Quartulli , Sven Eckelmann , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Roopa Prabhu , Nikolay Aleksandrov , David Ahern , Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , Willem de Bruijn , Matthieu Baerts , Mat Martineau , Marcelo Ricardo Leitner , Xin Long , Trond Myklebust , Anna Schumaker , Jon Maloy , Ying Xue , Martin Schiller Subject: Re: [RFC PATCH 79/86] treewide: net: remove cond_resched() Message-ID: <20231108121138.114f0f15@gandalf.local.home> In-Reply-To: References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107230822.371443-1-ankur.a.arora@oracle.com> <20231107230822.371443-23-ankur.a.arora@oracle.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 371EC20008 X-Stat-Signature: 5a7ijb9pqkyu9rpw5dpatb8dbks1umhs X-HE-Tag: 1699463505-807760 X-HE-Meta: U2FsdGVkX1/O8tW6EbzGdxgLwmx3uAHvojI5nwD3aUkYcJNWF/TprobH/cnUfzZ9q1VXSkWVNF6AHp5bnLzqpyMX4vHHrvZiRQH24XpGfTgwiOAZp5ugSX1jRxPB540p46INmUzESXca9qtm0IL2LoQpiVfC48vtcvbICcm/FnR0VynPC/mgtMhEoqTsoaM5bVvtBfwnEyxkfXvLT9BSkjDxcby8unRZjrTiUYkT7r/zwXeWigemW6CiwQV9STRYfyq/p9CzGasQmz71Ecdw5FTuqTRIp5a6BvBKRsmcGCQQeE+LlTOSVgvq1UYwrC4qGBocC5lRJU4nYszCYNcd+v6Z69Q0R7uHLIXThPCDOT76Fj0JKGdMoqIdW6ZZOJ05yYDqsr0aRpQ3Ry1HFr0SI8vMY+LKho414in0EqrBzCbPqb6zUh3+4RYP7wqLPxerrO+yk3Yy/3O0TMIWfBxzcYb7HfqhNJKu+60DAsi7QnLzLGhHTtPAaPuOnZl0PwJ+MXHhy9RRDWUnduUri8GKiem2HWreGYtBMdfZjeOod37+62KIZ7y+dmbYfJWrreTaaLa2g7qW+W7MvpTinHfaKrh9THnNMvRpUJ67AU2CwCLmq+IOWcM8LlJvtSvk4aBnHW5e2jpkykK6siNF8gGtQjlWP5a5uqSl5V+ekXRd3TBViA753XWUKVd68Nk898sth9D+s5/I+fXmg81iynIJqOBj9hf9ELML1VjRkVbzAINgLVo9zshx6gNbhN9TLgpds85EoSLlaTYD0cz5wyzN0N3dFoJtXwxGIuJaeBTRL2p9400kp48KMVEIQorF29cOQ5Hu01k+AqtyyUy7Gufb7ND2UIJ+VDUBx5j054ZhObinZmTKRzFRbNJT6tP5LQLHOfsMQb0UfDK+7mVC1gNB/HBJfUlEyi38hIcMWPA5P7p5Iwhi/SUFkSNJrRBExGKX2j6rgolBcsYlUx5D6ER HKo6VN7F D+UXof33iZx5SYkruJ789jS0SXOqqwSFEC+0PxgArkqAUYK9OO4KfmmQwKnuTFFrIYdqsKxZUHUkGMNnBQAm+JReTUUOzp85OGFnbT5eWSWN1zESTH2N8IvMIKsoGp258YcEWVgf088NREHOn/Kr4dw+bxAnt1VoBrzbzkfP9I7pClMU0f12HQFfCbeLWJd2HpsUlmCd3LQD1jmvhzl5vjREWvFL2MvYx5qGigIHgE0l/Iy44/l4m8CEweeYn4LtzmmUQVClUDYyQZQE2s1KRpupZKqYyQPEIY/akJUHavzncTz8W67/pGnxnNGwoJ92SQl5PISeoFpYukFiM0x+6CnjMCu+dA9GZl0DlYbVKX5N6nyDa+szmRJ9UsEwq/XJwJqcXG1/jtqxyvp0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 8 Nov 2023 13:16:17 +0100 Eric Dumazet wrote: > > Most of the uses here are in set-1 (some right after we give up a > > lock or enable bottom-halves, causing an explicit preemption check.) > > > > We can remove all of them. > > A patch series of 86 is not reasonable. Agreed. The removal of cond_resched() wasn't needed for the RFC, as there's really no comments needed once we make cond_resched obsolete. I think Ankur just wanted to send all the work for the RFC to let people know what he has done. I chalk that up as a Noobie mistake. Ankur, next time you may want to break things up to get RFCs for each step before going to the next one. Currently, it looks like the first thing to do is to start with Thomas's patch, and get the kinks out of NEED_RESCHED_LAZY, as Thomas suggested. Perhaps work on separating PREEMPT_RCU from PREEMPT. Then you may need to work on handling the #ifndef PREEMPTION parts of the kernel. And so on. Each being a separate patch series that will affect the way the rest of the changes will be done. I want this change too, so I'm willing to help you out on this. If you didn't start it, I would have ;-) -- Steve