From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F436C4332F for ; Wed, 8 Nov 2023 19:31:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64F638D00C4; Wed, 8 Nov 2023 14:31:42 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D8578D0073; Wed, 8 Nov 2023 14:31:42 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 49FCB8D00C4; Wed, 8 Nov 2023 14:31:42 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 36F548D0073 for ; Wed, 8 Nov 2023 14:31:42 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 08E0A402AA for ; Wed, 8 Nov 2023 19:31:42 +0000 (UTC) X-FDA: 81435781644.27.E502434 Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf10.hostedemail.com (Postfix) with ESMTP id 2BF78C000F for ; Wed, 8 Nov 2023 19:31:39 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SivM1r2G; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699471900; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Mtrwa9hSdXFnIf5b0zx44D7ENUS147rdOzljUhuQ8RA=; b=2hTTUeDfoDXyup1Y/ZZd6HcwNXs9Ix+pBnDdwbm8rRdnQ8WPQFYaSFKWxr/w899jMIUAgg QWtoTfj58zVHSPnnyudO/CQESaiNDiW3b/Kmxl775nXiE4JmLME2EIYHicOfbGmR01mOOp ywzBUFAm/9laDKKAamICA/VrDzpZfrA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=SivM1r2G; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf10.hostedemail.com: domain of keescook@chromium.org designates 209.85.214.180 as permitted sender) smtp.mailfrom=keescook@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699471900; a=rsa-sha256; cv=none; b=5MgvgS2TkMmbiLKhJSSlt/xsGlkSRSqdMmLCRdCXpd8GIxs+6fq0QfQgJwJERGIfNfqWSR OSYeq5M/zBIjSHgm8lq+M13+B45jSwdW7J+98KG+Zk0jVsIUqBzOrhwDZ348ZcYPLQTqj7 KyYGsPzSFblaiMCxexE0X+pCD+7OHU8= Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1cc1ee2d8dfso65725495ad.3 for ; Wed, 08 Nov 2023 11:31:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1699471899; x=1700076699; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Mtrwa9hSdXFnIf5b0zx44D7ENUS147rdOzljUhuQ8RA=; b=SivM1r2G5cY4vX6y2bddqCsGDkSx5YaiwNdzfk15uLFXHHzRZ7sc2AaKHKgcQLpfyA vj6VgsbzcM/n8PaQJOjYATtU/Rsz6C1z6HGtB1iCB13S6y6sAo2NzebOLFXk1MfLE9Kq qGKNJgLjRcWG15CMG6GHiG0WU/fTlEzTOw0fI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699471899; x=1700076699; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Mtrwa9hSdXFnIf5b0zx44D7ENUS147rdOzljUhuQ8RA=; b=dA2bYHmUYbAoazXfBLlzWpVHN9edBZgbvAG3MiXN1oNPOj7DUjRfCAX+fCpbNwVae0 ObcJR/aGpkK7woR6gsC1V+DmDicaVjcd9FLf9pT+Hec4+yPNJIjECnEc5tVhEvsmLJIu r7TnDVzBzlTq8PWZjWXlZpGPzTHKmQArRM020Eauq00m7SPRMOFQiujr6FLLxn6KLYrR RugmDuUqNoSRdlLFYA8g2p5hWucs3NaxMhSbfzFiSzrO/OcwwGXMrQnhLcM1+jdbLA8V /sfCP4kg8aEddI+lqpkjO/qgAApSUn7Ye7wTboP/ELApEMYOaKnEQSmG7mFr5PjILRlG 8xJQ== X-Gm-Message-State: AOJu0Yy39VLAD+uyDkgWg86tp0CjVn3Ml48w0WT9Nc4Ld8oBex/TqJlr c0tFoLmdl+6KwAoxq1yoY0SNng== X-Google-Smtp-Source: AGHT+IEVKfGQFeW4SR4Q6rpbh+y6ExnHCJACd1kkHnlHnKUApaRxUeZJeTTiNd/t9L2b2ZH0RdK89g== X-Received: by 2002:a17:902:9b90:b0:1c3:3b5c:1fbf with SMTP id y16-20020a1709029b9000b001c33b5c1fbfmr2976900plp.10.1699471899041; Wed, 08 Nov 2023 11:31:39 -0800 (PST) Received: from www.outflux.net (198-0-35-241-static.hfc.comcastbusiness.net. [198.0.35.241]) by smtp.gmail.com with ESMTPSA id b21-20020a170902b61500b001c9c97beb9csm2085456pls.71.2023.11.08.11.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 08 Nov 2023 11:31:38 -0800 (PST) Date: Wed, 8 Nov 2023 11:31:37 -0800 From: Kees Cook To: Mateusz Guzik , Peter Zijlstra Cc: Kees Cook , Josh Triplett , Eric Biederman , Alexander Viro , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fs/exec.c: Add fast path for ENOENT on PATH search before allocating mm Message-ID: <202311081129.9E1EC8D34@keescook> References: <5c7333ea4bec2fad1b47a8fa2db7c31e4ffc4f14.1663334978.git.josh@joshtriplett.org> <202311071228.27D22C00@keescook> <20231107205151.qkwlw7aarjvkyrqs@f> <202311071445.53E5D72C@keescook> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 2BF78C000F X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: c7mnap81s5k34dwsmpgahiiz99qgmk9e X-HE-Tag: 1699471899-750259 X-HE-Meta: U2FsdGVkX193Qe7QwK9cARlRRkYH37zpB8NgjakN1WlH+vJwFPMeKr8Q9M6zR5okK/9RLo/5ZE5oji5SgGhYY71LOb7A3iYbdiBMtZvKwkCghv8HWB36ZLpkgxYbztHDbIMPBEaOicLLQ3tjAZFYz+PRteGOIY/SQXU44Qqh16mh5hq9GoVnlv0Xve5sOdXPOatUe3E+4NolTuozVNNq/XBQSZTSve4XeFp7lf67wWG7ZohWC/ACDHJW798GQqaIepJslY+o5m+eUm8XF/7yxqg/Rr0g4K9tMyjkxmzLqnYVRji3t180k/u8mDfQVt4XSwD6Oh6HIW6VyrOINOfFxsouIOWBprT1aQ2YUuTo1NcY/wZ4JNsHhDL+uALr4Ut6jHS9vvgCL2LMn2QPFDNb0ESXShpflHxN9ZkHB8/NM6e3MDLcDjI06bWurCe1R3OW+dU4A7HIU7243nuKHw6am1N/JY6QgEEkFv3RfPs4bovqLYeRXT9TKuvI1cvMMoAyEk5ghWLPGCuDMmErnWKWsu/vlfQUoJxfVwtYlEXnSlWAkIDhTCsGi5ds7VADUTnPKKTLCeyeIyGkIVxLcpiTdQ/Oqd36yCWYgyctw/d9F/Rb7FY48l8WEVl2KSDu7JLiu9R6wrp7O7wFsQVd/lKZbhbUjQ3yPOGAH6NXGvzBY54h2ae6c8lSUMPxnl6qoVFjHfSzRQafTLqC64xDoBgl58CdGHcoCHi3HfSyhq7Xsz3HRi2Mgc//7SwCFYhHFQyIP3VtB2dp1BUaRx38OrneB/KFtIgqBb7oMX6O4RyK/gUZwLVY3jsQ1J9gNP2dMHQ7YuMGGNfCj1+n2eMmMKZd65axIjLre9u9Ys5LKARQN/WxJ33WluUTOJ3pB1LcdQJriZTJFljP8YtyX+Wg3tthsX6gh+/heVkiLAj+FPzB7Rn/5eup3nA6pmxE60yVszhCqfFJI20p/Z8DTQwNIGO BleyrtWg piWIMJfIaKDx+nd9AVN9ancBpgXuRHwGRA3oggTfE8y84+cN4vg3clpm3jGs7XlTv0Z7kDCa5WeqHASuCdVLN5MbpzyWOdjGtJzVqWNwZJLtLCb/6JztAgE393l3ctNVsgoGHR5hX18ll3di9MTbFAKHl4dBmD34Ua82RtP7WfjRAyY4MXp2kLzy+NarGgEc7Pa/fssmd9g/H+QOtCPih1keoCaTr7AaNCixhSCqNtIMGglBLO5cNllRNq6cUZ+7Rh+vPwoifuaXiTdxApLH5/VrfqMRGXBMout1kKRqxoZnr255vzUGkuY8jItB6vprYID7HFxgH0ei83xyb4W2FCALrGoMxVZoyLPwi+BRubbcoDBSMbze4RRM3soOu6Qk8RRebo98yHMTdUq/bBjo26DWKJrZxVR4PritPcE6TVDCw3Q1MVJukPB+uJ6IJB0X9tAO9aHm7NUnyDoZV3RJcrFxjwtH8qFfHEHhbPLzv/xpX87nY+bYf7rexlT4T76Ymlq2Lch5HWowQyl3HI6cHr5tr52t7ZWibx4JhEY7wgsGok5E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000680, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 08, 2023 at 01:03:33AM +0100, Mateusz Guzik wrote: > On 11/8/23, Kees Cook wrote: > > > > > > On November 7, 2023 3:08:47 PM PST, Mateusz Guzik > > wrote: > >>On 11/7/23, Kees Cook wrote: > >>> On Tue, Nov 07, 2023 at 10:23:16PM +0100, Mateusz Guzik wrote: > >>>> If the patch which dodges second lookup still somehow appears slower a > >>>> flamegraph or other profile would be nice. I can volunteer to take a > >>>> look at what's going on provided above measurements will be done and > >>>> show funkyness. > >>> > >>> When I looked at this last, it seemed like all the work done in > >>> do_filp_open() (my patch, which moved the lookup earlier) was heavier > >>> than the duplicate filename_lookup(). > >>> > >>> What I didn't test was moving the sched_exec() before the mm creation, > >>> which Peter confirmed shouldn't be a problem, but I think that might be > >>> only a tiny benefit, if at all. > >>> > >>> If you can do some comparisons, that would be great; it always takes me > >>> a fair bit of time to get set up for flame graph generation, etc. :) > >>> > >> > >>So I spawned *one* process executing one statocally linked binary in a > >>loop, test case from http://apollo.backplane.com/DFlyMisc/doexec.c . > >> > >>The profile is definitely not what I expected: > >> 5.85% [kernel] [k] asm_exc_page_fault > >> 5.84% [kernel] [k] __pv_queued_spin_lock_slowpath > >>[snip] > >> > >>I'm going to have to recompile with lock profiling, meanwhile > >>according to bpftrace > >>(bpftrace -e 'kprobe:__pv_queued_spin_lock_slowpath { @[kstack()] = > >> count(); }') > >>top hits would be: > >> > >>@[ > >> __pv_queued_spin_lock_slowpath+1 > >> _raw_spin_lock+37 > >> __schedule+192 > >> schedule_idle+38 > >> do_idle+366 > >> cpu_startup_entry+38 > >> start_secondary+282 > >> secondary_startup_64_no_verify+381 > >>]: 181 > >>@[ > >> __pv_queued_spin_lock_slowpath+1 > >> _raw_spin_lock_irq+43 > >> wait_for_completion+141 > >> stop_one_cpu+127 > >> sched_exec+165 > > > > There's the suspicious sched_exec() I was talking about! :) > > > > I think it needs to be moved, and perhaps _later_ instead of earlier? > > Hmm... > > > > I'm getting around 3.4k execs/s. However, if I "taskset -c 3 > ./static-doexec 1" the number goes up to about 9.5k and lock > contention disappears from the profile. So off hand looks like the > task is walking around the box when it perhaps could be avoided -- it > is idle apart from running the test. Again this is going to require a > serious look instead of ad hoc pokes. Peter, is this something you can speak to? It seems like execve() forces a change in running CPU. Is this really something we want to be doing? Or is there some better way to keep it on the same CPU unless there is contention? -Kees -- Kees Cook