From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BDF30C4332F for ; Wed, 8 Nov 2023 11:14:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 522B78D00B8; Wed, 8 Nov 2023 06:14:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D3688D00AD; Wed, 8 Nov 2023 06:14:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3749F8D00B8; Wed, 8 Nov 2023 06:14:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 258948D00AD for ; Wed, 8 Nov 2023 06:14:45 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id A3740C0580 for ; Wed, 8 Nov 2023 11:14:44 +0000 (UTC) X-FDA: 81434529288.16.75F2251 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf06.hostedemail.com (Postfix) with ESMTP id 745C8180021 for ; Wed, 8 Nov 2023 11:14:42 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=QGsg4EwJ; dmarc=none; spf=none (imf06.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699442083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=LakYbXR3di9WRqWbciSUdlJrNzr3EZiBAXC/ZMZNW4g=; b=Yv2Lrk/mjaL3KEkeSCiQSZESdoGZjIFjRH8s9zrN2bL1mq71JiyTpj9FaBkrOOZGxIS7ZV 7XsA2xQ6AjHFjaDGQaVaEW7mrna6a7229ZoEW0Z7/lh81xI2ypl8tlYXesQPFt8mFHxeYh MMvT4Uq+dDWs+87Z8blgaY4oo8utcd4= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=QGsg4EwJ; dmarc=none; spf=none (imf06.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699442083; a=rsa-sha256; cv=none; b=50UBJ+qW/if1K54JVkOId2ri+SV8MTV1CZkIxMpFaSHKIjL7nliU9Qmpwg/NDj/ghx/m71 cRLmCYKFNhvxApU3sWjBw9nfxGuksM6CxkrnZHQ80RZ4RKE3nBdoFaQ4JmqRjty+DX8TCP ILh7Q9i6Y2mwRtvbaSPasZ85T9sO/Z8= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=LakYbXR3di9WRqWbciSUdlJrNzr3EZiBAXC/ZMZNW4g=; b=QGsg4EwJgCqNuGRPTI0kL4wSsi Y1tiUsZhpALUmcK71iy49kzBVviGpiZqeT0kugcoxjtWU0Wcftc8ra7EGyYo2qD8h72qMne2cej3/ hHUHjTdbWMGRFqtspUvAE7TNwbeb4RiN6r7al5zsDBjeEsZ1zMWDNCc6WDy3sfKtYC1lAa3mI97EQ 0iOHM1beg6B0bNmeiuc4Rax3Z0ynIt72v8dGIIXAx2Zp90FWRCpoFvBz8w6R/wZ1D0HeIDH9y9+GC vgtrpZSjuuWsXjWfB0yNjp8+hxyteRfgA129LsK6Ue/wIV0B6F4LdJ2SvKdZ8gcfS6IqKIrq9aPs/ SfeC7WPA==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1r0gVj-00DR3j-2x; Wed, 08 Nov 2023 11:14:16 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 38A2B30049D; Wed, 8 Nov 2023 12:14:15 +0100 (CET) Date: Wed, 8 Nov 2023 12:14:15 +0100 From: Peter Zijlstra To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org, David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 00/86] Make the kernel preemptible Message-ID: <20231108111415.GP8262@noisy.programming.kicks-ass.net> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231108085156.GD8262@noisy.programming.kicks-ass.net> <87bkc4lfxp.fsf@oracle.com> <20231108101330.GK3818@noisy.programming.kicks-ass.net> <87leb8ik6b.fsf@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87leb8ik6b.fsf@oracle.com> X-Rspamd-Queue-Id: 745C8180021 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: mutiogk18rfc9y1qkeimjzgomqjkqz4q X-HE-Tag: 1699442082-850091 X-HE-Meta: U2FsdGVkX1/gYo8LT/tHyuXmfLxLXYE2/SNJzwfKK4hOUGOM5vdpds2fwgbLfWNV/tnM16kHCt3Y3hjvsdEVRmXchV/EcEqHNOshbjam51O9+LWfZ7MEmPJXtKkCjf9zO2QeR6FYsVVkg4IYlPrDoiyO91IrLHyXbTKu3o8B98hlz/UVe4PNGbZth7izjpGCc7upgIiI3GMzzMw09HgN2I9UpRTEa+iL5DMttW+burcWK+8IXlNSWpVegsZvuvjkkZLa9Y9BIw0/69uS3eBMT6j4Xv00teVJUsTH3AKUANIT6YLdV49J+jsPhNnVt4Xze+ElCq+2rLrtzkGmmXKgkmbxmkP48WVNeBUHKPH60yR8gk3UZcrcqJ4a9FSSGJ9LTt08CsXksGVEjhs9z41blBAxfkmQdmoZ0JRfhfM1xtDafkfB2LWyngJ6J9fSBgwFMY6aFX0EW0z79x0XmDSGPIKAIhIsW+TJMRzBck36R/qQVxsYR0grlAaTzbbASdUkYw0pNPpPcPI44ZZAko9oHslhMLIQPHnYw2fYD4S28DwiyFPqx4akyS9RJ4ajwL8y+GLKkmVQr2McjaJ6PBemPPo8hA1NMVjOpe+yaCkxQV7ZiZHctLnd8uDJZqSlL2Z5bgXBaaCLPI2Qmb/HC8+57ufOYisETSC0ysgt1IHbkpx3laS2izieGCR4Lloh1QaRMv/I8HqYMDeFCfRtKW1AxopIyf1GMOFobn6+LTBUiazWnADp46osdvPL/nP4yyShjhPk7FZhlO0BERByiWDTAxDMldjLRBug42MxS9pNHa3RAzWlG7lWEMwmuU8qtnTynkJ7hpxR0zX1rOtomcCN7z3xw2whlZxj6h8GuxmDlDrcFVaG3tmETrhgApIshyYCK5Sb8ozI2j8o3DMG2M7O40cU5qtI8qVCkOWAd9tkkT7ysRXx9jbkIkQX2MBJXhSv7K54PzKsbr8Qen7DvYp Soj37b+t pFnVaE+hZAz3taORubbRb0Y20h9Av/3uG6l7UbJ1eBMoiA8w4sbxBC2+Q7iMxhoxQOvobn4XO6qF8cL/xhaXZZAyPJUjF/92oHeBA1diz++vOGDNG5PPI2gAnDdGLWYb+oZLgnh3j3Quk0X4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 08, 2023 at 03:00:44AM -0800, Ankur Arora wrote: > Ah now I see what you are saying. > > Quick thought: even if we were running under NONE, eventually you'll Well, NONE, you get what you pay for etc.. > want to forcibly preempt out a CPU hog. So we will need to have > at least this one enabled always: > > > * irqentry_exit_cond_resched <- irqentry_exit_cond_resched > > These two, it might make sense to toggle them based on model. > > > * preempt_schedule <- preempt_schedule > > * preempt_schedule_notrace <- preempt_schedule_notrace > > Anyway let me think about this more and respond tomorrow. That's more or less killing NONE. At that point there's really no point in having it. I would really suggest you start with transforming VOLUNTARY into the LAZY thing, keep it as simple and narrow as possible. Once you've got that done, then you can try and argue that NONE makes no sense and try and take it out. Smaller step etc..