From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6394C4167B for ; Wed, 8 Nov 2023 15:08:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 166CB8D00BA; Wed, 8 Nov 2023 10:08:23 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0F0838D0073; Wed, 8 Nov 2023 10:08:23 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id ED3B28D00BA; Wed, 8 Nov 2023 10:08:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id DB2A78D0073 for ; Wed, 8 Nov 2023 10:08:22 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id B3F99160CE0 for ; Wed, 8 Nov 2023 15:08:22 +0000 (UTC) X-FDA: 81435118044.17.69ABB08 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id E58691C0017 for ; Wed, 8 Nov 2023 15:08:20 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of "SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org"; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699456101; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7UfTtvOuRn/xDBn4DWCioLolWp5RDm0ISMx9XwYAg/M=; b=w4UmfBp//Gay8EdV05qtcbkCm4PDz4ccKNqxsumRLJtQg6VWu5XwMqFccuCAu9IBI1iLXO EGiriE4PlwDESKKpquczFyxpq9ZQgRIQ/A7E7vDA0fanOa2RcsMIxZeca/k1pOlqbe8+fT gSjk51bvQVKb4in4RfSt3uXE9B6QOQE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699456101; a=rsa-sha256; cv=none; b=Op7D5xhuRdgXtkpaeaQrSxH0G2u7fmuCf/dmnlu4BLQVgHAB7rgzqiDC5a9Y5pp+P0OAM6 pXySJugcuV+QduAwLKWvoCXf9iqurcxy0JRIovwL2ip5CJK2lSfRy5vrzrLr6wJjuliJwc Qr8NBC822Kvjf2qQs0Y6XoSuuWdoMug= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of "SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=kuE6=GV=goodmis.org=rostedt@kernel.org"; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id B84C8615F6; Wed, 8 Nov 2023 15:08:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1503EC433C7; Wed, 8 Nov 2023 15:08:14 +0000 (UTC) Date: Wed, 8 Nov 2023 10:08:18 -0500 From: Steven Rostedt To: Herbert Xu Cc: Ankur Arora , linux-kernel@vger.kernel.org, tglx@linutronix.de, peterz@infradead.org, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com, "David S. Miller" , Kees Cook , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Thomas Graf Subject: Re: [RFC PATCH 71/86] treewide: lib: remove cond_resched() Message-ID: <20231108100818.4bc238e7@gandalf.local.home> In-Reply-To: References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107230822.371443-1-ankur.a.arora@oracle.com> <20231107230822.371443-15-ankur.a.arora@oracle.com> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: mmem6sghhgyd6hncjg86wmqagses1brf X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: E58691C0017 X-Rspam-User: X-HE-Tag: 1699456100-584027 X-HE-Meta: U2FsdGVkX189FLAfi7ugVXgUfkA8CY08RgCBR5VxBeFkJJ1JESTIhRKSsEqftVuJGvSKPy+6Z4ojMuKznconsVZlMUt8lv6y/7CYE6Y5zMI2hyOUGbZ3XsPTUcxLHCWyBtIFBV+A9+gYhQ+4OsA9b6CX85a+SREvF+iJQHa0d5cGAtneguDTDb+MvNK+TGtuqTP9J7OqrM7voUisFTBcmtWp9ME1l2544wCIU76lOGzwtKdI3ZPDkEA8wxz+0oP7WnKgzQ6RFdVslBoAz9tmnxdw3d07Hj0XJU6hUqfiJ4TaISzCesqKYK2vt6IWJ30KxAz8LbVoZjrseDYCQ+IOkFwQp3NaqaEMTihwfA70koTtwDGRmnilnA9s6xAblOaAcXV4i2Q+++rlYYorI/2YH4izhh5UFnoW+424cEKgRltyg0bBzGctXzEE06B3e5Uwcnl5M9nYKM7YB5Id6ZLzPCUKil48VR2LF5GmQhtO+Zx3O+qfQxOiJAreocmdV3A5S1OH1P/vQuJq+b2Nv+LE65OOMQidqAlGPjPAcUXDt4/nSAId01wN/ze6finN61aoQ8735eAsdlCg9Vduo7EQ8gKpgvxHYNWL5o9XapqjO2o6yShOL/16j6ZBQoyorKLeCWxCwInZRbm2zwz2VTiRSwYtG4YdSNu+UDmOjUc3DSCQgbvVmFhBdaWQ+snQll8KvQXsI2c11GjsQVepr8OllIIzkQSFv7AX4v40i2HVc+0YEuDAq+24gghNkH2tBx3bg55l9cqLhf6yhlOFPnW2jOvQehuGtzxcBgV/m968w4pwCXnPNfIncVbipFPBsjsCJLrp1ZgcbFu1x0Vm/uFvk9SKS4Zdr3Qn/KqkjoJUqeYYV94I6MSvBp0Nw2phfpbQ6MulhKZSb3M5c4zEv7OKesI5ccgbD3/xta+Zou/Kn/aYxJ03nn1r8YEwWGdmr3xGIak0egz/nUHDkeZSKqq 1yh9P9SA Ocwa+rmfq4geliqcGEswzzZCLFnE1hpdsBNJHD3B+JQIi27nV6K9rCYyQPTRwpy5U2NfeT4qS91cYd1ABF/qxEG4L90ObTIyTkd/3eCIRm5ij86oKDjrjfR400Iw9xqV60sXiORWGcgCvr3uWhI/zJost9rTFwXedTTPZlxxaIDs+6lMBiBCbStNQWlAO8a85Iua1EcfOEUuFLJRNW9+A+tvU7PDibDF4A7ktm2q403JjMyiN/SOgkHPSfreCQraQ3pYO1evoBZwKrQus8Gcx/2dVxlQ/9kX79AXjutXwYRiQNB4szqfLzJABUml+Z0E5LBCiLphyaARg50iE4GL0IIcrBJWFuk4gU+KtbbDI4UMc61k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 8 Nov 2023 17:15:11 +0800 Herbert Xu wrote: > > lib/crc32test.c | 2 -- > > lib/crypto/mpi/mpi-pow.c | 1 - > > lib/memcpy_kunit.c | 5 ----- > > lib/random32.c | 1 - > > lib/rhashtable.c | 2 -- > > lib/test_bpf.c | 3 --- > > lib/test_lockup.c | 2 +- > > lib/test_maple_tree.c | 8 -------- > > lib/test_rhashtable.c | 10 ---------- > > 9 files changed, 1 insertion(+), 33 deletions(-) > > Nack. A "Nack" with no commentary is completely useless and borderline offensive. What is your rationale for the Nack? The cond_resched() is going away if the patches earlier in the series gets implemented. So either it is removed from your code, or it will become a nop, and just wasting bits in the source tree. Your choice. -- Steve