From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37313C4332F for ; Wed, 8 Nov 2023 09:00:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFF738D00B1; Wed, 8 Nov 2023 04:00:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CAF608D00AD; Wed, 8 Nov 2023 04:00:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B78018D00B1; Wed, 8 Nov 2023 04:00:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A39488D00AD for ; Wed, 8 Nov 2023 04:00:38 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 6E54280311 for ; Wed, 8 Nov 2023 09:00:38 +0000 (UTC) X-FDA: 81434191356.13.069DDB1 Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) by imf14.hostedemail.com (Postfix) with ESMTP id A7747100022 for ; Wed, 8 Nov 2023 09:00:36 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=UijKzCUt; spf=none (imf14.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699434036; a=rsa-sha256; cv=none; b=uP8FCv9UvthLTFLaQx9viLGhG8gvd8dHkALcNC/IBL46xo7Y/ZjOqhrOZtfxcr5MOZ9eEe 7RxMmgM7j5uGiXQrgFTotrzUwzOHyXpiYCrC79TzxTC5G5Vl6/12fNmJRQ4HtoYTMbJgNO fpqmbSRt7miMVf1rgQjGXdwZ16n39hY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=infradead.org header.s=desiato.20200630 header.b=UijKzCUt; spf=none (imf14.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.92.199) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699434036; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=o1k+9LWQfYbsH6i1YBwZRWYzVVi+NlhgulqChyyrbdM=; b=6Uq6TO5pIl/d/DamDOQ80Qj353wL8SIo8xAXlpik7BFCndJEccKn31lOOuXImWjBBzs4UM Mh6GymztPTO+izkVuZNAdp6NPiUiYONlNm6Gwfr8HM79mGDc+SiCIEFSRpeQaHE5fNCbKq FaO/a5Fb10HEzD2kSIfwubvckUDjVdw= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=o1k+9LWQfYbsH6i1YBwZRWYzVVi+NlhgulqChyyrbdM=; b=UijKzCUtSAjkXA/3c/Hfb7U+GB X22EpK22RyTqUR4yRClfaa5LOckiOPJvWXBFzCZ8esoeqIby5dvOUkK0LaRB+HJo+ubheya33SW73 7LOoAwO9OAE+GnMqTROOces4f2NKk6ASjVHUHPPadGNKzj/O1wv1jSPrieyxWOHapzEgVRVpBiKN0 qRap08yPkXO78wVLKbwjbjPG4LrYJ3vKAztZTXY+fLRAx3rgDdDa34mtLQNoBUDd/+5EE/rfW42NR roPg2tIhqjIkVFOU83rVba7ZgyhBddFzv/PBDudPuImnkz0IXEmjOJt6GCayyX92DKbZkixtnA/dJ xP1kSbIg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by desiato.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1r0ePz-00DMrH-25; Wed, 08 Nov 2023 09:00:12 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id 4C6BD30049D; Wed, 8 Nov 2023 10:00:11 +0100 (CET) Date: Wed, 8 Nov 2023 10:00:11 +0100 From: Peter Zijlstra To: Ankur Arora Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, torvalds@linux-foundation.org, paulmck@kernel.org, linux-mm@kvack.org, x86@kernel.org, akpm@linux-foundation.org, luto@kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, hpa@zytor.com, mingo@redhat.com, juri.lelli@redhat.com, vincent.guittot@linaro.org, willy@infradead.org, mgorman@suse.de, jon.grimm@amd.com, bharata@amd.com, raghavendra.kt@amd.com, boris.ostrovsky@oracle.com, konrad.wilk@oracle.com, jgross@suse.com, andrew.cooper3@citrix.com, mingo@kernel.org, bristot@kernel.org, mathieu.desnoyers@efficios.com, geert@linux-m68k.org, glaubitz@physik.fu-berlin.de, anton.ivanov@cambridgegreys.com, mattst88@gmail.com, krypton@ulrich-teichert.org, rostedt@goodmis.org, David.Laight@aculab.com, richard@nod.at, mjguzik@gmail.com Subject: Re: [RFC PATCH 35/86] thread_info: change to tif_need_resched(resched_t) Message-ID: <20231108090011.GF8262@noisy.programming.kicks-ass.net> References: <20231107215742.363031-1-ankur.a.arora@oracle.com> <20231107215742.363031-36-ankur.a.arora@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231107215742.363031-36-ankur.a.arora@oracle.com> X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: A7747100022 X-Stat-Signature: xy559i9jshkcd588zcecwnsgzxbhmcxf X-Rspam-User: X-HE-Tag: 1699434036-218210 X-HE-Meta: U2FsdGVkX1/dGf6e2LlwjPPPd+gmNePvK4HHhLMT2G70p4VzZu9S4xiQ2Q/ot5hVJsppC4Dsk5jV6gEl5s1rtEwkK1uzXAywZtCqZzaESjrYpRdVAg5Skkgg7dgmn/qqbsq1RIjxkSq4nVBo11NYkgcXifu7SRsh9dmLI7IgOesGgaV9STmagD547M7Tk4ct9++H2RN5ozeY4RtsCPblcStLVrpsFVAGY4oi+U9Es+x7JJNDTJd7b4O9KIr34qHKJYWa8EerroygMZmaPiRoi3a8NyYNvhaqhj4ETiXEm1WcUmbvM/+t+YaeqYLT1eOUd7s4xOCZ32S4ljTR7Q+UYh3xTISeM3sEWPXcLwzolqCJdbLtACqMoXJMv7TXTPZEmoQwhoK/Xz54aIMQdmRbwEc083tXzAxYQIp3A3E/whxHvW8ymV3AJ3kH1CUmk1boFa9DZi7R+schG+9f6uQQA7HDB08hm0X+BkK5S68QI9Uyi6NNzzZh7Wdz7UAz/NxmZgpDYQwzs8XYwTbRbjsZRF7TWTzuwsBcoGwPsIc1XDQeWkCqCBv9f2ih8CYI4mOcnxk1dyChmic3Ppf5+ICz5xF5ffkuRlbV/fUUDmeZxVWmSDT98g/mOkpqrXGoSkeR/D/U3lLTEaQSuvHpeYrRLaFuGR+VRIvTTI8//AL4SWWO7sBV8Kj1CWYDZieGJPBHmWNb4R6VtYWkDLAikvdAQJgcJ2a+ggO6c/iVbqIAfDIBjH/W0OVArML+3aF7oh9y5WVAtmJVNSqSSNZrdWBDIMAqjycTmdDG9FeA++PP+e8iBLXbAFW9iyVCZ+eH0KgNdqjEcsHccZIK1bOTbzk7qXf53/Rg9OO5iAROEpJ0vw7zNudDedDsNRMiivzeS9TwmTvg9UCyCSuYF16cT7ngH0M5LBQOuqZN/TdGp4YI9lTJlB/aOrcSiJNnadkGYHPGzYFxj/81b9SMlCpp9MH f+9eZlJy Ev+umnF2MHB7yZnw4korCls/ZfxfIf6lzlN9URbvxyq5FAHnH06xXGfAb9Fr6SiV68zL/SheaBTBn+BsP88MZ/z/MhpHadGHfR40Ymehnpxcpn8hx7zNyrnc+ZwiARqgodmXyQocJSBZDJTbfzvyLxVqooR818VyxgaN4E/Pwt+k4FWbhsqwvJAEXtA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 07, 2023 at 01:57:21PM -0800, Ankur Arora wrote: > diff --git a/include/linux/sched.h b/include/linux/sched.h > index 95d47783ff6e..5f0d7341cb88 100644 > --- a/include/linux/sched.h > +++ b/include/linux/sched.h > @@ -2172,9 +2172,11 @@ static inline int rwlock_needbreak(rwlock_t *lock) > > static __always_inline bool need_resched(void) > { > - return unlikely(tif_need_resched()); > + return unlikely(tif_need_resched(RESCHED_eager) || > + tif_need_resched(RESCHED_lazy)); > } > > + We really needed this extra blank line, yes? :-) > /* > * Wrappers for p->thread_info->cpu access. No-op on UP. > */ > diff --git a/include/linux/sched/idle.h b/include/linux/sched/idle.h > index 478084f9105e..719416fe8ddc 100644 > --- a/include/linux/sched/idle.h > +++ b/include/linux/sched/idle.h > @@ -63,7 +63,7 @@ static __always_inline bool __must_check current_set_polling_and_test(void) > */ > smp_mb__after_atomic(); > > - return unlikely(tif_need_resched()); > + return unlikely(need_resched()); > } You're stacking unlikely's, need_resched() already has unlikely.