From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B41C4167B for ; Tue, 7 Nov 2023 21:28:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6ADF28D005A; Tue, 7 Nov 2023 16:28:34 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 65DD08D0001; Tue, 7 Nov 2023 16:28:34 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 525E48D005A; Tue, 7 Nov 2023 16:28:34 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3D8C08D0001 for ; Tue, 7 Nov 2023 16:28:34 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 13233B5CFA for ; Tue, 7 Nov 2023 21:28:34 +0000 (UTC) X-FDA: 81432447348.02.CAC78D7 Received: from mail.alien8.de (mail.alien8.de [65.109.113.108]) by imf28.hostedemail.com (Postfix) with ESMTP id 0F65CC000B for ; Tue, 7 Nov 2023 21:28:31 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=QorMM4Su; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf28.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1699392512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bD4Og8jExEEHYDDGD4aZjJ2Y/F4MpIKryEXuaQivTig=; b=Tl/ivgnbljGKhFnw8LarIjbaVYFPnd4WNkUxlqpjyck+khMHZmNLOU8X3PwgIpOC1wAaan Ejb2m+CxcIRZPNlHYS9/ZxAhAJFVhNRzcMAfj+nNepORca105BBWeexzLUwufzSJmfI/aU p0uOjeVXoaeYWxqents3Xpx+2Wn1XTM= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=alien8.de header.s=alien8 header.b=QorMM4Su; dmarc=pass (policy=none) header.from=alien8.de; spf=pass (imf28.hostedemail.com: domain of bp@alien8.de designates 65.109.113.108 as permitted sender) smtp.mailfrom=bp@alien8.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1699392512; a=rsa-sha256; cv=none; b=Dd9huWKEIbXVCfVgMRtEADB+HfUOQVrVAIhiWKwyQuCss0/1x64rzSck8QCPAd2SCgrstQ b+1uRCjUmgvI2qvWTeUr8r5zx50oZjiwAC7aI+SGqvqGUIxoGjw0ynvdRbSeI9i6ea1E5K meBtEZ195d3rXx3WVQqIGjtqpJlofRw= Received: from localhost (localhost.localdomain [127.0.0.1]) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTP id D92F740E014B; Tue, 7 Nov 2023 21:28:28 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at mail.alien8.de Received: from mail.alien8.de ([127.0.0.1]) by localhost (mail.alien8.de [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id FJ3LN0HSu5qX; Tue, 7 Nov 2023 21:28:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=alien8; t=1699392506; bh=bD4Og8jExEEHYDDGD4aZjJ2Y/F4MpIKryEXuaQivTig=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QorMM4SuZdiKp7t2nZwe81UY7vOudNKGUcUY+TlNg43O9zYwwHCB7pozpT9nnl6q7 C/9DBfHFH7707N+ejUdjvjHyZllhX7kFCBjKoWk16nzMPlB2BAx+9SirMdgaWjLq4q GZCIhpj5To82xighWq74IFenape1WM3joOJuPmKsRTErh0iRJjKt2sxvxpQRol7vxS pHfJnnQGyq5L2W0OKXy0tcOO3oqw57IuzP7tLT0yis/CkXSGt1rp6miiOUMp7NGt69 9FornBvMJX5oj7URL8rY6jBvJ55f8LubZ9LR/Mhb2Svr3H57LsKQ8s6bv3C3isgv+R CkJlDmrwArgtzgFYsAISBw4FPh5DWOrTMVBNk+ZDXRZwaUxfixd5IfXXMXFzAkR2KJ 5SYifm7Ha0z0OLS/FEiuAhta0XbUky8UtoyodNL9OOtOCy/A2/n7EMWgCHQrKiGfqj qsl8iQptQLX56l5VUfaKv9pTlF/WwoIzeLXS96gjdBq71S/LFfc6SGaTlhFN9pM+9u 9h0iHI7asY53l9+P6SAeHxtynHF+/j/xMAwG+PpOtSPwAVjef6j95Y20t96CQufTOa LHb0OkqGowP6Rma1TpewhEYi6LnIvvZfhAgvm3A7/QIAQImr1nIPZa1usK5EloRu/e 7JIp4HZbQd3iCQjhw3NydAg8= Received: from zn.tnic (pd95304da.dip0.t-ipconnect.de [217.83.4.218]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature ECDSA (P-256) server-digest SHA256) (No client certificate requested) by mail.alien8.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 2926A40E0192; Tue, 7 Nov 2023 21:27:46 +0000 (UTC) Date: Tue, 7 Nov 2023 22:27:40 +0100 From: Borislav Petkov To: "Kalra, Ashish" Cc: Michael Roth , kvm@vger.kernel.org, linux-coco@lists.linux.dev, linux-mm@kvack.org, linux-crypto@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com, jroedel@suse.de, thomas.lendacky@amd.com, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com, seanjc@google.com, vkuznets@redhat.com, jmattson@google.com, luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com, pgonda@google.com, peterz@infradead.org, srinivas.pandruvada@linux.intel.com, rientjes@google.com, dovmurik@linux.ibm.com, tobin@ibm.com, vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com, tony.luck@intel.com, marcorr@google.com, sathyanarayanan.kuppuswamy@linux.intel.com, alpergun@google.com, jarkko@kernel.org, nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com, zhi.a.wang@intel.com, Brijesh Singh Subject: Re: [PATCH v10 06/50] x86/sev: Add the host SEV-SNP initialization support Message-ID: <20231107212740.GFZUqrzK7yzy41dRKp@fat_crate.local> References: <20231016132819.1002933-1-michael.roth@amd.com> <20231016132819.1002933-7-michael.roth@amd.com> <20231107163142.GAZUpmbt/i3himIf+E@fat_crate.local> <4a2016d6-dc1f-ff68-9827-0b72b7c8eac2@amd.com> <20231107191931.GCZUqNwxP8JcSbjZ0/@fat_crate.local> <20231107202757.GEZUqdzYyzVBHTBhZX@fat_crate.local> <250f5513-91c0-d0b5-cb59-439e26ba16dc@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <250f5513-91c0-d0b5-cb59-439e26ba16dc@amd.com> X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 0F65CC000B X-Stat-Signature: x1xs6ghiseseb77amqd7bi7xfjhhtfmd X-Rspam-User: X-HE-Tag: 1699392511-330616 X-HE-Meta: U2FsdGVkX1/GrOfwtXksTUdS+gLqm9OLDM4y1gIL3Q3cgFPTAPIywE3fr2Tf41EoTGQmm/qe6iBLbCldg/+oiuU1q8uEnzJuBdUm4P0jpOCpaJXz3Srg/LCs7CNqx6a+ZnIUWQDGqinZVn/Ii4KHkOmSS5jGZ9t7dzryUVuUwAaWwrmurRR7M3MX7KT2Ut93IMQ5hs0+EqL/H/4tFNNTIeQrpbhbOiZqSoMi66RKa3w7kjox9ehe3HENZIORciB6VsAF7wdaAjQt6CUkfWiG3gimCXhCHjY1/INEQhOi2mm9TRSZqWxYlgQCI8+ITEINXlv291NLRoPXVMGaF04+vDRPqztl6zlHsklZlU1SqfCSjgd9XglWF9VBKcBJoInD7HmklNQsE+a1cTN6FXwExMFIgo1u6yC53l7eFQx/2zK+oaLexwJIMYsNzPYyX1pljoFANg6B2ulQYkczVJom5y5WhGrCBW3iuXgha9BIp5lc3KSjuHlMKBEfUn+zUfqKG4FEgnRNc1F1Iiui61magb9M6QZUUX3e6bhjFXZwW3h4Z4CvRbujtEoMir7To82Hdv61pw5VGUuy6I1reJpsbjoJwOykJM+uWGOznUPES4Y3Gy94LrczlaJY97UVap8Xq8Q1VqTdTQoOszpx4tVGZ+4KF2mFuA79Syqa6Br0sQvP+480GWhrBqqnEnBHxJeyzImGRpMuS0CaAM5sIqGfdRPYepbPIoKxrcHkqDWKyPT8nJegfBo+xOWM+r8yRoFfONb9635fyrW9JgeVemCBYN9wW0703OgOrxgguQ35pFGftqqzmkwWJ0sP2HPkjbzmyE0NthlRHDdewB3ZtGJaCoCFGhaN6YiewMuaFvcIfHw5L9pRUwg5FHYyyGVUa+UK6ZiF6qEt7dHNLTK0qYg0kdpNs6fK6BUPXvva8XR1jIcqrH03ufRNslT5++At9U6qTqyP2f5phJN3nrJ84JP ZeasE8lM jfwwQ4ioL55LQCVHf1hgoV5GcTqUdYkh3DljxjBcL4Ff4fqHadZTlQHFY/kGQkKS2pRQdYnREkd2jtxsdZP4kEiEx+C44v4r+mkHhDfv1AYL16xHd7eZOojC3jGUR/fhNVwDe2KE9vsdapuogdjOb4loB0QoHKv4gjcdQYaDEtnx5mThL7Knx7xAPefibkqGpc+aMgwHHgyH86YQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 07, 2023 at 03:21:29PM -0600, Kalra, Ashish wrote: > No, this is not correct as this will always enable SNP support on > IOMMU even when SNP support is not supported and enabled on the > platform, You see that we set or clear X86_FEATURE_SEV_SNP depending on support, right? Which means, you need to test that bit in amd_iommu_snp_enable() first. > And isn't IOMMU driver always going to be built-in and isn't it part of the > platform support (not arch code, but surely platform specific code)? > (IOMMU enablement is requirement for SNP). Read the note again about the fragile ordering in my previous mail. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette